Skip to content

Commit 6e5cf86

Browse files
committed
Clean up the unnecessary test subsystem for now because the unit tests use ListWriter, and LLMObsSpanMapper is never reached.
1 parent 1154c16 commit 6e5cf86

File tree

5 files changed

+9
-39
lines changed

5 files changed

+9
-39
lines changed

dd-java-agent/agent-llmobs/llmobs-test-fixtures/build.gradle

Lines changed: 0 additions & 8 deletions
This file was deleted.

dd-java-agent/agent-llmobs/llmobs-test-fixtures/src/main/groovy/datadog/trace/llmobs/LlmObsSpecification.groovy

Lines changed: 0 additions & 26 deletions
This file was deleted.

dd-java-agent/instrumentation/openai-java/openai-java-3.0/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,5 @@ dependencies {
2121
latestDepTestImplementation group: 'com.openai', name: 'openai-java', version: '+'
2222

2323
testImplementation project(':dd-java-agent:instrumentation:okhttp:okhttp-3.0')
24-
25-
testImplementation project(':dd-java-agent:agent-llmobs:llmobs-test-fixtures')
2624
}
2725

dd-java-agent/instrumentation/openai-java/openai-java-3.0/src/test/groovy/OpenAiTest.groovy

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,16 @@ import com.openai.models.responses.ResponseCreateParams
2020
import com.openai.models.responses.ResponseFunctionToolCall
2121
import com.openai.models.responses.ResponseIncludable
2222
import com.openai.models.responses.ResponseInputItem
23+
import datadog.trace.agent.test.InstrumentationSpecification
2324
import datadog.trace.agent.test.server.http.TestHttpServer
25+
import datadog.trace.api.config.LlmObsConfig
2426
import datadog.trace.core.util.LRUCache
25-
import datadog.trace.llmobs.LlmObsSpecification
2627
import java.nio.file.Path
2728
import java.nio.file.Paths
2829
import spock.lang.AutoCleanup
2930
import spock.lang.Shared
3031

31-
abstract class OpenAiTest extends LlmObsSpecification {
32+
abstract class OpenAiTest extends InstrumentationSpecification {
3233

3334
// openai token - will use real openai backend and record request/responses to use later in the mock mode
3435
// empty or null - will use mockOpenAiBackend and read recorded request/responses
@@ -73,6 +74,12 @@ abstract class OpenAiTest extends LlmObsSpecification {
7374
}
7475
}
7576

77+
@Override
78+
void configurePreAgent() {
79+
super.configurePreAgent()
80+
injectSysConfig(LlmObsConfig.LLMOBS_ENABLED, "true")
81+
}
82+
7683
def setupSpec() {
7784
if (Strings.isNullOrEmpty(OPENAI_TOKEN)) {
7885
// mock backend uses request/response records

settings.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ include(
127127
// llm-observability
128128
include(
129129
":dd-java-agent:agent-llmobs",
130-
":dd-java-agent:agent-llmobs:llmobs-test-fixtures",
131130
)
132131

133132
// iast

0 commit comments

Comments
 (0)