updating strictness of config tests

Author: mhlidd

internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy

@@ -137,6 +137,7 @@ import static datadog.trace.api.config.TracerConfig.TRACE_SAMPLING_OPERATION_RUL
 import static datadog.trace.api.config.TracerConfig.TRACE_SAMPLING_SERVICE_RULES
 import static datadog.trace.api.config.TracerConfig.TRACE_X_DATADOG_TAGS_MAX_LENGTH
 import static datadog.trace.api.config.TracerConfig.WRITER_TYPE
+import datadog.trace.config.inversion.ConfigHelper
 
 class ConfigTest extends DDSpecification {
   private static final String PREFIX = "dd."
@@ -883,6 +884,9 @@ class ConfigTest extends DDSpecification {
 
   def "verify rule config #name"() {
     setup:
+    def strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+
     environmentVariables.set("DD_TRACE_TEST_ENABLED", "true")
     environmentVariables.set("DD_TRACE_TEST_ENV_ENABLED", "true")
     environmentVariables.set("DD_TRACE_DISABLED_ENV_ENABLED", "false")
@@ -894,6 +898,9 @@ class ConfigTest extends DDSpecification {
     expect:
     Config.get().isRuleEnabled(name) == enabled
 
+    cleanup:
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+
     where:
     // spotless:off
     name            | enabled
@@ -914,6 +921,9 @@ class ConfigTest extends DDSpecification {
 
   def "verify integration jmxfetch config"() {
     setup:
+    def strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+
     environmentVariables.set("DD_JMXFETCH_ORDER_ENABLED", "false")
     environmentVariables.set("DD_JMXFETCH_TEST_ENV_ENABLED", "true")
     environmentVariables.set("DD_JMXFETCH_DISABLED_ENV_ENABLED", "false")
@@ -925,6 +935,9 @@ class ConfigTest extends DDSpecification {
     expect:
     Config.get().isJmxFetchIntegrationEnabled(integrationNames, defaultEnabled) == expected
 
+    cleanup:
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+
     where:
     // spotless:off
     names                          | defaultEnabled | expected
@@ -950,6 +963,9 @@ class ConfigTest extends DDSpecification {
 
   def "verify integration trace analytics config"() {
     setup:
+    def strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+
     environmentVariables.set("DD_ORDER_ANALYTICS_ENABLED", "false")
     environmentVariables.set("DD_TEST_ENV_ANALYTICS_ENABLED", "true")
     environmentVariables.set("DD_DISABLED_ENV_ANALYTICS_ENABLED", "false")
@@ -967,6 +983,9 @@ class ConfigTest extends DDSpecification {
     expect:
     Config.get().isTraceAnalyticsIntegrationEnabled(integrationNames, defaultEnabled) == expected
 
+    cleanup:
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+
     where:
     // spotless:off
     names                           | defaultEnabled | expected
@@ -996,6 +1015,9 @@ class ConfigTest extends DDSpecification {
 
   def "test getFloatSettingFromEnvironment(#name)"() {
     setup:
+    def strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+
     environmentVariables.set("DD_ENV_ZERO_TEST", "0.0")
     environmentVariables.set("DD_ENV_FLOAT_TEST", "1.0")
     environmentVariables.set("DD_FLOAT_TEST", "0.2")
@@ -1009,6 +1031,9 @@ class ConfigTest extends DDSpecification {
     expect:
     Config.get().configProvider.getFloat(name, defaultValue) == (float) expected
 
+    cleanup:
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+
     where:
     name              | expected
     // spotless:off
@@ -1027,6 +1052,9 @@ class ConfigTest extends DDSpecification {
 
   def "test getDoubleSettingFromEnvironment(#name)"() {
     setup:
+    def strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+
     environmentVariables.set("DD_ENV_ZERO_TEST", "0.0")
     environmentVariables.set("DD_ENV_FLOAT_TEST", "1.0")
     environmentVariables.set("DD_FLOAT_TEST", "0.2")
@@ -1040,6 +1068,9 @@ class ConfigTest extends DDSpecification {
     expect:
     Config.get().configProvider.getDouble(name, defaultValue) == (double) expected
 
+    cleanup:
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+
     where:
     // spotless:off
     name              | expected

internal-api/src/test/groovy/datadog/trace/api/InstrumenterConfigTest.groovy

@@ -1,9 +1,21 @@
 package datadog.trace.api
 
+import datadog.trace.config.inversion.ConfigHelper
 import datadog.trace.test.util.DDSpecification
 
 class InstrumenterConfigTest extends DDSpecification {
 
+  def strictness
+
+  def setup(){
+    strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+  }
+
+  def cleanup(){
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+  }
+
   def "verify integration config"() {
     setup:
     environmentVariables.set("DD_INTEGRATION_ORDER_ENABLED", "false")

internal-api/src/test/groovy/datadog/trace/bootstrap/config/provider/ConfigProviderTest.groovy

@@ -5,6 +5,8 @@ import spock.lang.Shared
 import datadog.trace.api.ConfigCollector
 import datadog.trace.api.ConfigOrigin
 import datadog.trace.api.ConfigSetting
+import datadog.trace.config.inversion.ConfigHelper
+
 
 import static datadog.trace.api.config.TracerConfig.TRACE_HTTP_SERVER_PATH_RESOURCE_NAME_MAPPING
 
@@ -13,6 +15,17 @@ class ConfigProviderTest extends DDSpecification {
   @Shared
   ConfigProvider configProvider = ConfigProvider.withoutCollector()
 
+  def strictness
+
+  def setup(){
+    strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+  }
+
+  def cleanup() {
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+  }
+
   def "properties take precedence over env vars for ordered map"() {
     setup:
     injectEnvConfig("TRACE_HTTP_SERVER_PATH_RESOURCE_NAME_MAPPING", "/a:env,/b:env")

internal-api/src/test/groovy/datadog/trace/bootstrap/config/provider/StableConfigParserTest.groovy

@@ -2,9 +2,20 @@ package datadog.trace.bootstrap.config.provider
 import datadog.trace.test.util.DDSpecification
 import java.nio.file.Files
 import java.nio.file.Path
+import datadog.trace.config.inversion.ConfigHelper
 
 class StableConfigParserTest extends DDSpecification {
 
+  def strictness
+
+  def setup(){
+    strictness = ConfigHelper.get().configInversionStrictFlag()
+    ConfigHelper.get().setConfigInversionStrict(ConfigHelper.StrictnessPolicy.TEST)
+  }
+
+  def cleanup(){
+    ConfigHelper.get().setConfigInversionStrict(strictness)
+  }
   def "test parse valid"() {
     when:
     Path filePath = Files.createTempFile("testFile_", ".yaml")