Improving error reporting when process fails to start

Wrapped PortUtils.waitForPortToOpen with exception handling, when exception is raised log file indicating error is added to exception message

Suppressed FileNotException in cleanUpSpec, when process exits abormally since no file is expected and it creates noise

Author: dougqh

dd-smoke-tests/src/main/groovy/datadog/smoketest/AbstractServerSmokeTest.groovy

@@ -66,7 +66,12 @@ abstract class AbstractServerSmokeTest extends AbstractSmokeTest {
     (0..<numberOfProcesses).each { idx ->
       def port = httpPorts[idx]
       def process = testedProcesses[idx]
-      PortUtils.waitForPortToOpen(port, 240, TimeUnit.SECONDS, process)
+
+      try {
+        PortUtils.waitForPortToOpen(port, 240, TimeUnit.SECONDS, process)
+      } catch ( Exception e ) {
+        throw new RuntimeException(e.getMessage() + " - log file " + logFilePaths[idx], e);
+      }
     }
   }
 
@@ -76,7 +81,15 @@ abstract class AbstractServerSmokeTest extends AbstractSmokeTest {
       if (null != (outputFile = outputs[idx])) {
         // check the structures written out to the log,
         // and fail the run if anything unexpected was recorded
-        verifyLog(idx, outputFile)
+        try {
+          verifyLog(idx, outputFile)
+        } catch ( FileNotFoundException e ) {
+          if ( testedProcesses[idx].exitValue() == 0 ) {
+            // suppress file not found exception if process exited abnormally
+            // just creates confusing noise
+            throw e;
+          }
+        }
       }
     }
   }