Fix SymDB startup (#10493)

When SymDB explicitly disabled and Dynamic Instrumentation is enabled
honor correctly the disablemennt
Same for Code Origin

Author: jpbempel

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java

@@ -2,6 +2,7 @@
 
 import static datadog.environment.JavaVirtualMachine.isJavaVersionAtLeast;
 import static datadog.environment.JavaVirtualMachine.isOracleJDK8;
+import static datadog.trace.api.Config.isExplicitlyDisabled;
 import static datadog.trace.api.ConfigDefaults.DEFAULT_STARTUP_LOGS_ENABLED;
 import static datadog.trace.api.config.GeneralConfig.DATA_JOBS_COMMAND_PATTERN;
 import static datadog.trace.api.config.GeneralConfig.DATA_JOBS_ENABLED;
@@ -1457,11 +1458,6 @@ && isExplicitlyDisabled(DebuggerConfig.DISTRIBUTED_DEBUGGER_ENABLED)) {
     startDebuggerAgent(inst, scoClass, sco);
   }
 
-  private static boolean isExplicitlyDisabled(String booleanKey) {
-    return Config.get().configProvider().isSet(booleanKey)
-        && !Config.get().configProvider().getBoolean(booleanKey);
-  }
-
   private static synchronized void startDebuggerAgent(
       Instrumentation inst, Class<?> scoClass, Object sco) {
     StaticEventLogger.begin("Debugger");

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerAgent.java

@@ -27,6 +27,8 @@
 import datadog.remoteconfig.ConfigurationPoller;
 import datadog.remoteconfig.Product;
 import datadog.trace.api.Config;
+import datadog.trace.api.config.DebuggerConfig;
+import datadog.trace.api.config.TraceInstrumentationConfig;
 import datadog.trace.api.debugger.DebuggerConfigBridge;
 import datadog.trace.api.flare.TracerFlare;
 import datadog.trace.api.git.GitInfo;
@@ -89,8 +91,12 @@ public static synchronized void run(
     }
     if (config.isDynamicInstrumentationEnabled()) {
       startDynamicInstrumentation(config);
-      startCodeOriginForSpans(config);
-      startSymbolDatabase(config);
+      if (!Config.isExplicitlyDisabled(TraceInstrumentationConfig.CODE_ORIGIN_FOR_SPANS_ENABLED)) {
+        startCodeOriginForSpans(config);
+      }
+      if (!Config.isExplicitlyDisabled(DebuggerConfig.SYMBOL_DATABASE_ENABLED)) {
+        startSymbolDatabase(config);
+      }
       if (config.getDynamicInstrumentationInstrumentTheWorld() != null) {
         setupInstrumentTheWorldTransformer(config, instrumentation, sink);
       }

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DefaultDebuggerConfigUpdater.java

@@ -1,5 +1,7 @@
 package com.datadog.debugger.agent;
 
+import static datadog.trace.api.Config.isExplicitlyDisabled;
+
 import datadog.trace.api.Config;
 import datadog.trace.api.config.DebuggerConfig;
 import datadog.trace.api.config.TraceInstrumentationConfig;
@@ -67,11 +69,6 @@ public boolean isDistributedDebuggerEnabled() {
     return DebuggerAgent.distributedDebuggerEnabled.get();
   }
 
-  private static boolean isExplicitlyDisabled(String booleanKey) {
-    return Config.get().configProvider().isSet(booleanKey)
-        && !Config.get().configProvider().getBoolean(booleanKey);
-  }
-
   private static void startOrStopFeature(
       Config config,
       String booleanKey,

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -5705,6 +5705,11 @@ public static Config get() {
     return INSTANCE;
   }
 
+  public static boolean isExplicitlyDisabled(String booleanKey) {
+    return Config.get().configProvider().isSet(booleanKey)
+        && !Config.get().configProvider().getBoolean(booleanKey);
+  }
+
   /**
    * This method is deprecated since the method of configuration will be changed in the future. The
    * properties instance should instead be passed directly into the DDTracer builder: