Skip to content

Commit 81d8a79

Browse files
committed
IsTraceRoot is a tristate
1 parent ce2279b commit 81d8a79

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

dd-trace-core/src/main/java/datadog/trace/common/metrics/SerializingMetricWriter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public void add(MetricKey key, AggregateMetric aggregate) {
118118
writer.writeBoolean(key.isSynthetics());
119119

120120
writer.writeUTF8(IS_TRACE_ROOT);
121-
writer.writeBoolean(key.isTraceRoot());
121+
writer.writeInt(key.isTraceRoot() ? 1 : 2); // tristate (0 unknown, 1 true, 2 false)
122122

123123
writer.writeUTF8(SPAN_KIND);
124124
writer.writeUTF8(key.getSpanKind());

dd-trace-core/src/test/groovy/datadog/trace/common/metrics/SerializingMetricWriterTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ class SerializingMetricWriterTest extends DDSpecification {
177177
assert unpacker.unpackBoolean() == key.isSynthetics()
178178
++elementCount
179179
assert unpacker.unpackString() == "IsTraceRoot"
180-
assert unpacker.unpackBoolean() == key.isTraceRoot()
180+
assert unpacker.unpackInt() == (key.isTraceRoot() ? 1 : 2)
181181
++elementCount
182182
assert unpacker.unpackString() == "SpanKind"
183183
assert unpacker.unpackString() == key.getSpanKind() as String

0 commit comments

Comments
 (0)