Unique test names for okhttp (#7989)

smola · web-flow · commit 8353161a0c51 · 2024-11-21T10:46:31.000+01:00
diff --git a/dd-java-agent/instrumentation/okhttp-2/src/test/groovy/OkHttp2AsyncTest.groovy b/dd-java-agent/instrumentation/okhttp-2/src/test/groovy/OkHttp2AsyncTest.groovy
@@ -49,7 +49,7 @@ abstract class OkHttp2AsyncTest extends OkHttp2Test {
     return responseRef.get().code()
   }
 
-  def "callbacks should carry context" () {
+  def "callbacks should carry context with error = #error" () {
 
     when:
     def captured = AgentTracer.noopSpan()
diff --git a/dd-java-agent/instrumentation/okhttp-3/src/test/groovy/OkHttp3AsyncTest.groovy b/dd-java-agent/instrumentation/okhttp-3/src/test/groovy/OkHttp3AsyncTest.groovy
@@ -49,7 +49,7 @@ abstract class OkHttp3AsyncTest extends OkHttp3Test {
     return responseRef.get().code()
   }
 
-  def "callbacks should carry context" () {
+  def "callbacks should carry context with error = #error" () {
 
     when:
     def captured = AgentTracer.noopSpan()

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ abstract class OkHttp2AsyncTest extends OkHttp2Test {`
`49`	`49`	`return responseRef.get().code()`
`50`	`50`	`}`
`51`	`51`
`52`		`- def "callbacks should carry context" () {`
	`52`	`+ def "callbacks should carry context with error = #error" () {`
`53`	`53`
`54`	`54`	`when:`
`55`	`55`	`def captured = AgentTracer.noopSpan()`