Skip to content

Commit 89b8658

Browse files
Implement is_modified telemetry tag
1 parent ffe9afc commit 89b8658

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/config/ExecutionSettingsFactoryImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,8 @@ private Diff getPullRequestDiff(boolean impactedTestsDetectionEnabled) {
304304
if (repositoryRoot == null || !impactedTestsDetectionEnabled) {
305305
return Diff.EMPTY;
306306
}
307-
// FIXME nikita: add telemetry
308-
// FIXME nikita: add file-based granularity fallback if Git executable is not available?
307+
// FIXME nikita: add file-based granularity fallback if Git executable is not available (add
308+
// telemetry for backend)?
309309
// FIXME nikita: add integration/smoke tests
310310
try {
311311
GitClient gitClient = gitClientFactory.create(repositoryRoot);

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/TestImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import datadog.trace.api.civisibility.telemetry.CiVisibilityMetricCollector;
1919
import datadog.trace.api.civisibility.telemetry.tag.BrowserDriver;
2020
import datadog.trace.api.civisibility.telemetry.tag.EventType;
21+
import datadog.trace.api.civisibility.telemetry.tag.IsModified;
2122
import datadog.trace.api.civisibility.telemetry.tag.IsNew;
2223
import datadog.trace.api.civisibility.telemetry.tag.IsRetry;
2324
import datadog.trace.api.civisibility.telemetry.tag.IsRum;
@@ -262,6 +263,7 @@ public void end(@Nullable Long endTime) {
262263
instrumentation,
263264
EventType.TEST,
264265
span.getTag(Tags.TEST_IS_NEW) != null ? IsNew.TRUE : null,
266+
span.getTag(Tags.TEST_IS_MODIFIED) != null ? IsModified.TRUE : null,
265267
span.getTag(Tags.TEST_IS_RETRY) != null ? IsRetry.TRUE : null,
266268
span.getTag(Tags.TEST_IS_RUM_ACTIVE) != null ? IsRum.TRUE : null,
267269
CIConstants.SELENIUM_BROWSER_DRIVER.equals(span.getTag(Tags.TEST_BROWSER_DRIVER))

internal-api/src/main/java/datadog/trace/api/civisibility/telemetry/CiVisibilityCountMetric.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import datadog.trace.api.civisibility.telemetry.tag.HasCodeowner;
1818
import datadog.trace.api.civisibility.telemetry.tag.IsBenchmark;
1919
import datadog.trace.api.civisibility.telemetry.tag.IsHeadless;
20+
import datadog.trace.api.civisibility.telemetry.tag.IsModified;
2021
import datadog.trace.api.civisibility.telemetry.tag.IsNew;
2122
import datadog.trace.api.civisibility.telemetry.tag.IsRetry;
2223
import datadog.trace.api.civisibility.telemetry.tag.IsRum;
@@ -62,6 +63,7 @@ public enum CiVisibilityCountMetric {
6263
IsBenchmark.class,
6364
EarlyFlakeDetectionAbortReason.class,
6465
IsNew.class,
66+
IsModified.class,
6567
IsRetry.class,
6668
IsRum.class,
6769
BrowserDriver.class),
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package datadog.trace.api.civisibility.telemetry.tag;
2+
3+
import datadog.trace.api.civisibility.telemetry.TagValue;
4+
5+
/** Whether the definition of a test was modified. */
6+
public enum IsModified implements TagValue {
7+
TRUE;
8+
9+
@Override
10+
public String asString() {
11+
return "is_modified:true";
12+
}
13+
}

0 commit comments

Comments
 (0)