Renamed addCrashTracking to testCrashTracking for consistency

Renamed addCrashTracking to testCrashTracking for consistency with recently added testTelemetry

Author: dougqh

dd-smoke-tests/iast-util/src/testFixtures/groovy/datadog/smoketest/AbstractIastServerSmokeTest.groovy

@@ -23,7 +23,7 @@ abstract class AbstractIastServerSmokeTest extends AbstractServerSmokeTest {
   private final JsonSlurper jsonSlurper = new JsonSlurper()
 
   @Override
-  def addCrashTracking() {
+  def testCrashTracking() {
     // DQH - 2024 Nov
     // Disabled crash tracking in IAST tests for initial GA
     // NOTE: That tests that concatenate JVM arguments into JAVA_TOOL_OPTIONS may

dd-smoke-tests/springboot-openliberty-20/src/test/groovy/datadog/smoketest/SpringBootOpenLibertySmokeTest.groovy

@@ -20,10 +20,10 @@ class SpringBootOpenLibertySmokeTest extends AbstractServerSmokeTest {
   String openLibertyShadowJar = System.getProperty("datadog.smoketest.openliberty.jar.path")
 
   @Override
-  def addCrashTracking() {
+  def testCrashTracking() {
     // DQH - 2024 Nov
     // Concatenating into a single string to use JAVA_TOOL_OPTIONS doesn't play nice
-    // with the quote currently used by crash tracking smoke testing in AbstractSmokeTest,
+    // with the quoting currently used by crash tracking smoke testing in AbstractSmokeTest,
     // so skipping for this test.
     return false
   }

dd-smoke-tests/springboot-openliberty-23/src/test/groovy/datadog/smoketest/SpringBootOpenLibertySmokeTest.groovy

@@ -20,10 +20,10 @@ class SpringBootOpenLibertySmokeTest extends AbstractServerSmokeTest {
   String openLibertyShadowJar = System.getProperty("datadog.smoketest.openliberty.jar.path")
 
   @Override
-  def addCrashTracking() {
+  def testCrashTracking() {
     // DQH - 2024 Nov
     // Concatenating into a single string to use JAVA_TOOL_OPTIONS doesn't play nice
-    // with the quote currently used by crash tracking smoke testing in AbstractSmokeTest,
+    // with the quoting currently used by crash tracking smoke testing in AbstractSmokeTest,
     // so skipping for this test.
     return false
   }

dd-smoke-tests/springboot-openliberty-23/src/test/groovy/datadog/smoketest/SpringBootOpenLibertySmokeVulnerabilityTest.groovy

@@ -22,10 +22,10 @@ class SpringBootOpenLibertySmokeVulnerabilityTest extends AbstractServerSmokeTes
   String openLibertyShadowJar = System.getProperty("datadog.smoketest.openliberty.jar.path")
 
   @Override
-  def addCrashTracking() {
+  def testCrashTracking() {
     // DQH - 2024 Nov
     // Concatenating into a single string to use JAVA_TOOL_OPTIONS doesn't play nice
-    // with the quote currently used by crash tracking smoke testing in AbstractSmokeTest,
+    // with the quoting currently used by crash tracking smoke testing in AbstractSmokeTest,
     // so skipping for this test.
     return false
   }

dd-smoke-tests/src/main/groovy/datadog/smoketest/AbstractSmokeTest.groovy

@@ -164,7 +164,7 @@ abstract class AbstractSmokeTest extends ProcessManager {
     "-Ddd.version=${VERSION}"
   ]
 
-  def addCrashTracking() {
+  def testCrashTracking() {
     return true
   }
 
@@ -194,9 +194,8 @@ abstract class AbstractSmokeTest extends ProcessManager {
       ret += "-Ddd.service.name=${SERVICE_NAME}"
     }
 
-    // DQH - 13 Nov 2024 - Crashtracking bash script doesn't work on OS X,
-    // so skipping crash tracking on OS X
-    if (addCrashTracking() && !Platform.isJ9() && !Platform.isMac()) {
+    // DQH - Nov 2024 - skipping for J9 which doesn't have full crash tracking support
+    if (testCrashTracking() && !Platform.isJ9()) {
       def extension = getScriptExtension()
 
       ret += "-XX:OnError=\"${tmpDir}/dd_crash_uploader.${extension} %p\""

dd-smoke-tests/vertx-3.4/src/test/groovy/datadog/smoketest/VertxSmokeTest.groovy

@@ -14,7 +14,7 @@ class VertxSmokeTest extends AbstractServerSmokeTest {
   int totalInvocations = 1000
 
   @Override
-  def addCrashTracking() {
+  def testCrashTracking() {
     // DQH - 2024 Nov
     // Disabled crash tracking in IAST tests for initial GA
     // NOTE: That tests that concatenate JVM arguments into JAVA_TOOL_OPTIONS may