Skip to content

Commit 8c3f56e

Browse files
committed
move JDBC test on injection with generated keys to SQL Server file
1 parent 0cf4569 commit 8c3f56e

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

dd-java-agent/instrumentation/jdbc/src/test/groovy/DBMInjectionForkedTest.groovy

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,4 @@ class DBMInjectionForkedTest extends AgentTestRunner {
4747
then:
4848
assert statement.sql == "/*${fullInjection}*/ ${query}"
4949
}
50-
51-
def "single query with generated keys"() {
52-
setup:
53-
def connection = new TestConnection(false)
54-
55-
when:
56-
def statement = connection.createStatement() as TestStatement
57-
statement.executeUpdate(query, 1)
58-
59-
then:
60-
assert statement.sql == "${query} /*${fullInjection}*/"
61-
}
6250
}

dd-java-agent/instrumentation/jdbc/src/test/groovy/SQLServerInjectionForkedTest.groovy

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,19 @@ class SQLServerInjectionForkedTest extends AgentTestRunner {
3636
// Verify that the SQL does NOT contain traceparent
3737
assert !statement.sql.contains("traceparent")
3838
}
39+
40+
def "SQL Server apend comment when getting generated keys"() {
41+
setup:
42+
def connection = new TestConnection(false)
43+
def metadata = new TestDatabaseMetaData()
44+
metadata.setURL("jdbc:microsoft:sqlserver://localhost:1433;DatabaseName=testdb;")
45+
connection.setMetaData(metadata)
46+
47+
when:
48+
def statement = connection.createStatement() as TestStatement
49+
statement.executeUpdate(query, 1)
50+
51+
then:
52+
assert statement.sql == "${query} /*${serviceInjection}*/"
53+
}
3954
}

0 commit comments

Comments
 (0)