Skip to content

Commit 8eaed7d

Browse files
authored
add restriction on munit version in build.gradle (#7503)
1 parent 2b7a97c commit 8eaed7d

File tree

1 file changed

+5
-2
lines changed
  • dd-java-agent/instrumentation/junit-4.10/munit-junit-4

1 file changed

+5
-2
lines changed

dd-java-agent/instrumentation/junit-4.10/munit-junit-4/build.gradle

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ muzzle {
55
pass {
66
group = 'org.scalameta'
77
module = 'munit_2.13'
8-
versions = '[0.7.28,)'
8+
versions = '[0.7.28,1.0.0]'
99
}
1010
}
1111

@@ -28,7 +28,10 @@ dependencies {
2828
testImplementation group: 'org.scala-lang', name: 'scala-library', version: '2.13.10'
2929
testImplementation group: 'org.scalameta', name: 'munit_2.13', version: '0.7.28'
3030

31-
latestDepTestImplementation group: 'org.scalameta', name: 'munit_2.13', version: '+'
31+
// latest version as of august 2024 is 1.0.1, but that version changes which notifications are sent when a test is skipped,
32+
// making the tests fail. See https://github.com/scalameta/munit/issues/813 and https://github.com/DataDog/dd-trace-java/pull/7502/commits/ecda25e
33+
// TODO replace the fixed version with '+' once the github issue is resolved OR the code/tests are updated to accept the new behavior.
34+
latestDepTestImplementation group: 'org.scalameta', name: 'munit_2.13', version: '1.0.0'
3235
}
3336

3437
compileTestGroovy {

0 commit comments

Comments
 (0)