adding EnvironmentVariables linter

Author: mhlidd

components/environment/src/main/java/datadog/environment/EnvironmentVariables.java

@@ -37,7 +37,6 @@ public static String getOrDefault(@Nonnull String name, String defaultValue) {
       return defaultValue;
     }
     try {
-      //      String value = EnvironmentVariables.get(name);
       String value = System.getenv(name);
       return value == null ? defaultValue : value;
     } catch (SecurityException e) {

dd-java-agent/build.gradle

@@ -35,6 +35,7 @@ tasks.compileJava.dependsOn compileMain_java6Java
 
 dependencies {
   main_java6CompileOnly 'de.thetaphi:forbiddenapis:3.8'
+  implementation project(':components:environment')
   testImplementation sourceSets.main_java6.output
 }
 

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

@@ -1,7 +1,7 @@
 package datadog.trace.bootstrap;
 
+import datadog.environment.ConfigHelper;
 import datadog.json.JsonWriter;
-import datadog.trace.bootstrap.environment.EnvironmentVariables;
 import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.Closeable;
 import java.io.OutputStream;
@@ -146,7 +146,7 @@ public void onError(Throwable t) {
     }
 
     private int maxTags() {
-      String maxTags = EnvironmentVariables.get("DD_TELEMETRY_FORWARDER_MAX_TAGS");
+      String maxTags = ConfigHelper.getEnvironmentVariable("DD_TELEMETRY_FORWARDER_MAX_TAGS");
 
       if (maxTags != null) {
         try {

gradle/logEnvVarUsages.gradle

@@ -65,10 +65,48 @@ tasks.register('logEnvVarUsages') {
   }
 }
 
+tasks.register('checkEnvironmentVariablesUsage') {
+  group = "verification"
+  description = "Scans src/main/java for direct usages of EnvironmentVariables.get(...)"
+
+  doLast {
+    def pattern = ~/EnvironmentVariables\.get\s*\(/
+    def repoRoot = projectDir.toPath()
+
+    def javaFiles = fileTree(projectDir) {
+      include '**/src/main/java/**/*.java'
+
+      // Exclude specific files (relative to projectDir)
+      exclude 'components/environment/src/main/java/datadog/environment/ConfigHelper.java'
+    }
+
+    def matches = []
+
+    javaFiles.each { file ->
+      def relativePath = repoRoot.relativize(file.toPath())
+      file.eachLine { line, index ->
+        if (line =~ pattern) {
+          matches << "${relativePath}:${index + 1} -> ${line.trim()}"
+        }
+      }
+    }
+
+    if (!matches.isEmpty()) {
+      println "\n❌ Found forbidden usages of EnvironmentVariables.get(...):"
+      matches.each { println it }
+      throw new GradleException("Forbidden usage of EnvironmentVariables.get(...) found in Java files.")
+    } else {
+      println "✅ No forbidden EnvironmentVariables.get(...) usages found in src/main/java."
+    }
+  }
+}
+
 tasks.named('spotlessCheck') {
   dependsOn tasks.named('logEnvVarUsages')
+  dependsOn tasks.named('checkEnvironmentVariablesUsage')
 }
 
 tasks.named('spotlessApply') {
   dependsOn tasks.named('logEnvVarUsages')
+  dependsOn tasks.named('checkEnvironmentVariablesUsage')
 }