convert suffixes and exclusions to SetProperty

Author: amarziali

buildSrc/src/main/kotlin/datadog/gradle/plugin/naming/InstrumentationNamingExtension.kt

@@ -1,7 +1,7 @@
 package datadog.gradle.plugin.naming
 
-import org.gradle.api.provider.ListProperty
 import org.gradle.api.provider.Property
+import org.gradle.api.provider.SetProperty
 
 /**
  * Extension for configuring instrumentation naming convention checks.
@@ -10,8 +10,8 @@ import org.gradle.api.provider.Property
  * ```
  * instrumentationNaming {
  *   instrumentationsDir.set(file("dd-java-agent/instrumentation"))
- *   exclusions.set(listOf("http-url-connection", "sslsocket"))
- *   suffixes.set(listOf("-common", "-stubs""))
+ *   exclusions.set(setOf("http-url-connection", "sslsocket"))
+ *   suffixes.set(setOf("-common", "-stubs"))
  * }
  * ```
  */
@@ -23,21 +23,21 @@ abstract class InstrumentationNamingExtension {
   abstract val instrumentationsDir: Property<String>
 
   /**
-   * List of module names to exclude from naming convention checks.
+   * Set of module names to exclude from naming convention checks.
    * These modules will not be validated against the naming rules.
    */
-  abstract val exclusions: ListProperty<String>
+  abstract val exclusions: SetProperty<String>
 
   /**
-   * List of allowed suffixes for module names (e.g., "-common", "-stubs").
+   * Set of allowed suffixes for module names (e.g., "-common", "-stubs").
    * Module names must end with either one of these suffixes or a version number.
    * Defaults to ["-common", "-stubs"].
    */
-  abstract val suffixes: ListProperty<String>
+  abstract val suffixes: SetProperty<String>
 
   init {
     instrumentationsDir.convention("dd-java-agent/instrumentation")
-    exclusions.convention(emptyList())
-    suffixes.convention(listOf("-common", "-stubs"))
+    exclusions.convention(emptySet())
+    suffixes.convention(setOf("-common", "-stubs"))
   }
 }

buildSrc/src/main/kotlin/datadog/gradle/plugin/naming/InstrumentationNamingPlugin.kt

@@ -33,7 +33,7 @@ class InstrumentationNamingPlugin : Plugin<Project> {
 
       doLast {
         val instrumentationsDir = target.rootProject.file(extension.instrumentationsDir)
-        val exclusions = extension.exclusions.get().toSet()
+        val exclusions = extension.exclusions.get()
         val suffixes = extension.suffixes.get()
 
         if (!instrumentationsDir.exists() || !instrumentationsDir.isDirectory) {
@@ -62,8 +62,8 @@ class InstrumentationNamingPlugin : Plugin<Project> {
 
               To exclude specific modules or customize suffixes, configure the plugin:
                 instrumentationNaming {
-                  exclusions.set(listOf("module-name"))
-                  suffixes.set(listOf("-common", "-stubs"))
+                  exclusions.set(setOf("module-name"))
+                  suffixes.set(setOf("-common", "-stubs"))
                 }
               """.trimIndent())
           }
@@ -78,7 +78,7 @@ class InstrumentationNamingPlugin : Plugin<Project> {
   private fun validateInstrumentations(
     instrumentationsDir: File,
     exclusions: Set<String>,
-    suffixes: List<String>
+    suffixes: Set<String>
   ): List<NamingViolation> {
     val violations = mutableListOf<NamingViolation>()
 
@@ -123,7 +123,7 @@ class InstrumentationNamingPlugin : Plugin<Project> {
     moduleName: String,
     parentName: String,
     relativePath: String,
-    suffixes: List<String>
+    suffixes: Set<String>
   ): List<NamingViolation> {
     // Rule 1: Module name must end with version pattern or one of the configured suffixes
     validateVersionOrSuffix(moduleName, relativePath, suffixes)?.let { return listOf(it) }
@@ -146,7 +146,7 @@ class InstrumentationNamingPlugin : Plugin<Project> {
   private fun validateLeafModuleName(
     moduleName: String,
     relativePath: String,
-    suffixes: List<String>
+    suffixes: Set<String>
   ): NamingViolation? {
     return validateVersionOrSuffix(moduleName, relativePath, suffixes)
   }
@@ -157,7 +157,7 @@ class InstrumentationNamingPlugin : Plugin<Project> {
   private fun validateVersionOrSuffix(
     moduleName: String,
     relativePath: String,
-    suffixes: List<String>
+    suffixes: Set<String>
   ): NamingViolation? {
     val endsWithSuffix = suffixes.any { moduleName.endsWith(it) }
     val endsWithVersion = versionPattern.containsMatchIn(moduleName)