Skip to content

Commit 9bf1b6b

Browse files
Update Spock only for one module.
1 parent d0916a9 commit 9bf1b6b

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

dd-java-agent/instrumentation/java-concurrent/java-concurrent-21/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ tasks.named("check").configure {
4646

4747
dependencies {
4848
testImplementation project(':dd-java-agent:instrumentation:trace-annotation')
49+
testImplementation libs.bundles.spock24
4950
}
5051

5152
// Set all compile tasks to use JDK21 but let instrumentation code targets 1.8 compatibility

dd-java-agent/instrumentation/spring-webflux-6/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ dependencies {
5353
}
5454
bootTestImplementation project(':dd-java-agent:instrumentation:spring-webflux-5')
5555
// our default version of spock is too old
56-
bootTestImplementation libs.bundles.spock.spring
56+
bootTestImplementation libs.bundles.spock24.spring
5757

5858
latestDepBootTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-webflux', version: '3.+'
5959
latestDepBootTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-test', version: '3.+', {
@@ -62,7 +62,7 @@ dependencies {
6262
}
6363
latestDepBootTestImplementation project(':dd-java-agent:instrumentation:spring-webflux-5')
6464
// our default version of spock is too old
65-
latestDepBootTestImplementation libs.bundles.spock.spring
65+
latestDepBootTestImplementation libs.bundles.spock24.spring
6666

6767
iastTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-reactor-netty', version: '3.0.0'
6868
iastTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-json', version: '3.0.0'
@@ -80,6 +80,6 @@ dependencies {
8080
iastTestImplementation group: 'org.springframework.boot', name: 'spring-boot-starter-json', version: '3.0.0'
8181

8282
// our default version of spock is too old
83-
iastTestImplementation libs.bundles.spock.spring
83+
iastTestImplementation libs.bundles.spock24.spring
8484
}
8585

dd-smoke-tests/apm-tracing-disabled/build.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ dependencies {
1919
implementation project(':dd-trace-api')
2020
testImplementation project(':dd-smoke-tests')
2121
testImplementation(testFixtures(project(":dd-smoke-tests:iast-util")))
22-
23-
// Spock 2.4 requires
24-
testRuntimeOnly("org.junit.platform:junit-platform-engine:1.12.2")
2522
}
2623

2724
tasks.withType(Test).configureEach {

gradle/libs.versions.toml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ okhttp = "3.12.15" # Datadog fork to support Java 7
66
okhttp-legacy = "[3.0,3.12.12]" # 3.12.x is last version to support Java7
77
okio = "1.17.6" # Datadog fork
88

9-
spock = "2.4-M6-groovy-3.0"
9+
spock = "2.3-groovy-3.0"
10+
spock24 = "2.4-M6-groovy-3.0"
1011
groovy = "3.0.24"
1112
junit5 = "5.9.2"
1213
logback = "1.2.13"
@@ -63,8 +64,12 @@ aircompressor = { module = 'io.airlift:aircompressor', version = '2.0.2'}
6364
# Testing
6465
spock-core = { module = "org.spockframework:spock-core", version.ref = "spock" }
6566
spock-junit4 = { module = "org.spockframework:spock-junit4", version.ref = "spock" }
66-
spock-spring = { module = "org.spockframework:spock-spring", version.ref = "spock" }
67-
objenesis = { module = "org.objenesis:objenesis", version = "3.4" } # Used by Spock for mocking:
67+
objenesis = { module = "org.objenesis:objenesis", version = "3.3" } # Used by Spock for mocking:
68+
69+
spock24-core = { module = "org.spockframework:spock-core", version.ref = "spock24" }
70+
spock24-junit4 = { module = "org.spockframework:spock-junit4", version.ref = "spock24" }
71+
spock24-spring = { module = "org.spockframework:spock-spring", version.ref = "spock24" }
72+
objenesis34 = { module = "org.objenesis:objenesis", version = "3.4" }
6873

6974
groovy = { module = "org.codehaus.groovy:groovy-all", version.ref = "groovy" }
7075
groovy-yaml = { module = "org.codehaus.groovy:groovy-yaml", version.ref = "groovy" }
@@ -103,7 +108,8 @@ asm = ["asm", "asmcommons"]
103108
cafe-crypto = ["cafe-crypto-curve25519", "cafe-crypto-ed25519"]
104109
# Testing
105110
spock = ["spock-core", "spock-junit4", "objenesis"]
106-
spock-spring = ["spock-core", "spock-junit4", "spock-spring"]
111+
spock24 = ["spock24-core", "spock24-junit4", "objenesis34"]
112+
spock24-spring = ["spock24-core", "spock24-junit4", "spock24-spring"]
107113
junit5 = ["junit-jupiter", "junit-jupiter-params"]
108114
mockito = ["mokito-core", "mokito-junit-jupiter", "byte-buddy", "byte-buddy-agent"]
109115
test-logging = ["logback-classic", "log4j-over-slf4j", "jcl-over-slf4j", "jul-to-slf4j"]

0 commit comments

Comments
 (0)