Skip to content

Commit 9e81cc7

Browse files
test: remove ftr from instrumentation tests (not used)
1 parent 19b4edf commit 9e81cc7

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -632,7 +632,7 @@ public void execute() {
632632
}
633633

634634
maybeStartAppSec(scoClass, sco);
635-
// start before debugger to enable Failed Test Replay correctly
635+
// start civisibility before debugger to enable Failed Test Replay correctly in headless mode
636636
maybeStartCiVisibility(instrumentation, scoClass, sco);
637637
maybeStartLLMObs(instrumentation, scoClass, sco);
638638
// start debugger before remote config to subscribe to it before starting to poll

dd-java-agent/agent-ci-visibility/src/testFixtures/groovy/datadog/trace/civisibility/CiVisibilityInstrumentationTest.groovy

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
9696
injectSysConfig(CiVisibilityConfig.TEST_MANAGEMENT_ENABLED, "true")
9797
injectSysConfig(CiVisibilityConfig.TEST_MANAGEMENT_ATTEMPT_TO_FIX_RETRIES, "5")
9898
injectSysConfig(CiVisibilityConfig.CIVISIBILITY_TEST_ORDER, CIConstants.FAIL_FAST_TEST_ORDER)
99-
injectSysConfig(CiVisibilityConfig.TEST_FAILED_TEST_REPLAY_ENABLED, "true")
10099
}
101100

102101
private static final class Settings {
@@ -113,7 +112,7 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
113112
private volatile boolean earlyFlakinessDetectionEnabled
114113
private volatile boolean impactedTestsDetectionEnabled
115114
private volatile boolean testManagementEnabled
116-
private volatile boolean failedTestReplayEnabled
115+
private volatile boolean failedTestReplayEnabled = false
117116
}
118117

119118
private final Settings settings = new Settings()
@@ -349,10 +348,6 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
349348
settings.impactedTestsDetectionEnabled = impactedTestsDetectionEnabled
350349
}
351350

352-
def givenFailedTestReplayEnabled(boolean failedTestReplayEnabled) {
353-
settings.failedTestReplayEnabled = failedTestReplayEnabled
354-
}
355-
356351
def assertSpansData(String testcaseName, Map<String, String> replacements = [:], List<String> ignoredTags = []) {
357352
Predicate<DDSpan> sessionSpan = span -> span.spanType == "test_session_end"
358353
spanFilter.waitForSpan(sessionSpan, TimeUnit.SECONDS.toMillis(20))

0 commit comments

Comments
 (0)