Skip to content

Commit 9ffc32b

Browse files
committed
Fix jboss and improve comments
1 parent 88ef43c commit 9ffc32b

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

dd-java-agent/instrumentation/jboss/jboss-modules-1.3/build.gradle

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,12 @@ addTestSuite("latestDepTest")
1313
dependencies {
1414
compileOnly group: 'org.jboss.modules', name: 'jboss-modules', version: '1.3.0.Final'
1515
testImplementation group: 'org.jboss.modules', name: 'jboss-modules', version: '1.3.0.Final'
16-
// jboss-modules 2.1+ requires Java 11, so cap at 2.0.x to maintain Java 8 compatibility
17-
latestDepTestImplementation group: 'org.jboss.modules', name: 'jboss-modules', version: '2.0.+'
16+
latestDepTestImplementation group: 'org.jboss.modules', name: 'jboss-modules', version: '+'
17+
}
18+
19+
// jboss-modules requires Java 11: https://github.com/jboss-modules/jboss-modules/blob/2.x/README.md
20+
tasks.named("latestDepTest", Test) {
21+
onlyIf { javaVersion.isJava11Compatible() }
1822
}
1923

2024
tasks.withType(Test).configureEach {

dd-java-agent/instrumentation/karate/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ tasks.named("compileLatestDepTestJava", JavaCompile) {
8484
configureCompiler(it, 11, JavaVersion.VERSION_1_8)
8585
}
8686

87-
// Latest Karate 1.4.0+ versions require Java 11
87+
// karate 1.4.0+ requires Java 11: https://github.com/karatelabs/karate/releases/tag/v1.4.0
8888
tasks.named("latestDepTest", Test) {
8989
onlyIf { javaVersion.isJava11Compatible() }
9090
}

0 commit comments

Comments
 (0)