Skip to content

Commit a3a5c79

Browse files
committed
adding configs and updating specific tests to TEST strictness
1 parent 493be18 commit a3a5c79

File tree

5 files changed

+35
-15
lines changed

5 files changed

+35
-15
lines changed

components/environment/src/generator/resources/supported-configurations.json

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,10 +277,15 @@
277277
"DD_PROFILING_ASYNC_CPU_INTERVAL_MS": ["A"],
278278
"DD_PROFILING_ASYNC_CSTACK": ["A"],
279279
"DD_PROFILING_ASYNC_DEBUG_LIB": ["A"],
280+
"DD_PROFILING_EXPERIMENTAL_ASYNC_WALL_JVMTI": ["A"],
281+
"DD_PROFILING_ASYNC_LINENUMBERS": ["A"],
280282
"DD_PROFILING_ASYNC_LIVEHEAP_CAPACITY": ["A"],
281283
"DD_PROFILING_ASYNC_LIVEHEAP_INTERVAL": ["A"],
282284
"DD_PROFILING_ASYNC_LIVEHEAP_SAMPLE_PERCENT": ["A"],
285+
"DD_PROFILING_ASYNC_LOGLEVEL": ["A"],
283286
"DD_PROFILING_ASYNC_SAFEMODE": ["A"],
287+
"DD_PROFILING_ASYNC_WALL_COLLAPSING": ["A"],
288+
"DD_PROFILING_ASYNC_WALL_CONTEXT_FILTER": ["A"],
284289
"DD_PROFILING_ASYNC_WALL_INTERVAL_MS": ["A"],
285290
"DD_PROFILING_AUXILIARY": ["A"],
286291
"DD_PROFILING_BACKPRESSURE_SAMPLE_LIMIT": ["A"],
@@ -515,7 +520,7 @@
515520
"DD_TRACE_ARMERIA_JETTY_ENABLED": ["A"],
516521
"DD_TRACE_AUTH0_JWT_ENABLED": ["A"],
517522
"DD_TRACE_AVRO_ENABLED": ["A"],
518-
"DD_TRACE_AWS_ADD_SPAN_POINTERS": ["A"],
523+
"DD_TRACE_AWSADD_SPAN_POINTERS": ["A"],
519524
"DD_TRACE_AWS_DYNAMODB_ENABLED": ["A"],
520525
"DD_TRACE_AWS_LAMBDA_ENABLED": ["A"],
521526
"DD_TRACE_AWS_PROPAGATION_ENABLED": ["A"],
@@ -1304,11 +1309,14 @@
13041309
"OTEL_INSTRUMENTATION_HTTP_SERVER_CAPTURE_RESPONSE_HEADERS": ["A"],
13051310
"OTEL_JAVAAGENT_CONFIGURATION_FILE": ["A"],
13061311
"OTEL_JAVAAGENT_EXTENSIONS": ["A"],
1312+
"OTEL_LOGS_EXPORTER": ["A"],
13071313
"OTEL_LOG_LEVEL": ["A"],
1314+
"OTEL_METRICS_EXPORTER": ["A"],
13081315
"OTEL_PROPAGATORS": ["A"],
13091316
"OTEL_RESOURCE_ATTRIBUTES": ["A"],
13101317
"OTEL_SDK_DISABLED": ["A"],
13111318
"OTEL_SERVICE_NAME": ["A"],
1319+
"OTEL_TRACES_EXPORTER": ["A"],
13121320
"OTEL_TRACES_SAMPLER": ["A"]
13131321
},
13141322
"aliases": {
@@ -1360,6 +1368,7 @@
13601368
"DD_TRACE_ARMERIA_JETTY_ENABLED": ["DD_TRACE_INTEGRATION_ARMERIA_JETTY_ENABLED","DD_INTEGRATION_ARMERIA_JETTY_ENABLED"],
13611369
"DD_TRACE_AUTH0_JWT_ENABLED": ["DD_TRACE_INTEGRATION_AUTH0_JWT_ENABLED","DD_INTEGRATION_AUTH0_JWT_ENABLED"],
13621370
"DD_TRACE_AVRO_ENABLED": ["DD_TRACE_INTEGRATION_AVRO_ENABLED","DD_INTEGRATION_AVRO_ENABLED"],
1371+
"DD_TRACE_AWSADD_SPAN_POINTERS": ["DD_AWSADD_SPAN_POINTERS"],
13631372
"DD_TRACE_AWS_DYNAMODB_ENABLED": ["DD_TRACE_INTEGRATION_AWS_DYNAMODB_ENABLED","DD_INTEGRATION_AWS_DYNAMODB_ENABLED"],
13641373
"DD_TRACE_AWS_LAMBDA_ENABLED": ["DD_TRACE_INTEGRATION_AWS_LAMBDA_ENABLED","DD_INTEGRATION_AWS_LAMBDA_ENABLED"],
13651374
"DD_TRACE_AWS_PROPAGATION_ENABLED": ["DD_TRACE_INTEGRATION_AWS_PROPAGATION_ENABLED","DD_INTEGRATION_AWS_PROPAGATION_ENABLED"],
@@ -1569,6 +1578,7 @@
15691578
"DD_TRACE_KAFKA_STREAMS_ENABLED": ["DD_TRACE_INTEGRATION_KAFKA_STREAMS_ENABLED","DD_INTEGRATION_KAFKA_STREAMS_ENABLED"],
15701579
"DD_TRACE_KARATE_ENABLED": ["DD_TRACE_INTEGRATION_KARATE_ENABLED","DD_INTEGRATION_KARATE_ENABLED"],
15711580
"DD_TRACE_KOTLIN_COROUTINE_ENABLED": ["DD_TRACE_INTEGRATION_KOTLIN_COROUTINE_ENABLED","DD_INTEGRATION_KOTLIN_COROUTINE_ENABLED"],
1581+
"DD_TRACE_LEGACY_E2E_DURATION_ENABLED": ["DD_LEGACY_E2E_DURATION_ENABLED"],
15721582
"DD_TRACE_LETTUCE_4_ASYNC_ENABLED": ["DD_TRACE_INTEGRATION_LETTUCE_4_ASYNC_ENABLED","DD_INTEGRATION_LETTUCE_4_ASYNC_ENABLED"],
15731583
"DD_TRACE_LETTUCE_4_ENABLED": ["DD_TRACE_INTEGRATION_LETTUCE_4_ENABLED","DD_INTEGRATION_LETTUCE_4_ENABLED"],
15741584
"DD_TRACE_LETTUCE_5_ASYNC_ENABLED": ["DD_TRACE_INTEGRATION_LETTUCE_5_ASYNC_ENABLED","DD_INTEGRATION_LETTUCE_5_ASYNC_ENABLED"],
@@ -1717,9 +1727,11 @@
17171727
"DD_TRACE_SERVICETALK_ENABLED": ["DD_TRACE_INTEGRATION_SERVICETALK_ENABLED","DD_INTEGRATION_SERVICETALK_ENABLED"],
17181728
"DD_TRACE_SERVLET_2_ANALYTICS_SAMPLE_RATE": ["DD_SERVLET_2_ANALYTICS_SAMPLE_RATE"],
17191729
"DD_TRACE_SERVLET_2_ENABLED": ["DD_TRACE_INTEGRATION_SERVLET_2_ENABLED","DD_INTEGRATION_SERVLET_2_ENABLED"],
1730+
"DD_TRACE_SERVLET_3_ANALYTICS_ENABLED": ["DD_SERVLET_3_ANALYTICS_ENABLED"],
17201731
"DD_TRACE_SERVLET_3_ANALYTICS_SAMPLE_RATE": ["DD_SERVLET_3_ANALYTICS_SAMPLE_RATE"],
17211732
"DD_TRACE_SERVLET_3_ENABLED": ["DD_TRACE_INTEGRATION_SERVLET_3_ENABLED","DD_INTEGRATION_SERVLET_3_ENABLED"],
17221733
"DD_TRACE_SERVLET_5_ENABLED": ["DD_TRACE_INTEGRATION_SERVLET_5_ENABLED","DD_INTEGRATION_SERVLET_5_ENABLED"],
1734+
"DD_TRACE_SERVLET_ANALYTICS_ENABLED": ["DD_SERVLET_ANALYTICS_ENABLED"],
17231735
"DD_TRACE_SERVLET_ANALYTICS_SAMPLE_RATE": ["DD_SERVLET_ANALYTICS_SAMPLE_RATE"],
17241736
"DD_TRACE_SERVLET_COOKIE_ENABLED": ["DD_TRACE_INTEGRATION_SERVLET_COOKIE_ENABLED","DD_INTEGRATION_SERVLET_COOKIE_ENABLED"],
17251737
"DD_TRACE_SERVLET_DISPATCHER_ANALYTICS_SAMPLE_RATE": ["DD_SERVLET_DISPATCHER_ANALYTICS_SAMPLE_RATE"],
@@ -1773,6 +1785,7 @@
17731785
"DD_TRACE_SPRING_WEBFLUX_CLIENT_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_WEBFLUX_CLIENT_ENABLED","DD_INTEGRATION_SPRING_WEBFLUX_CLIENT_ENABLED"],
17741786
"DD_TRACE_SPRING_WEBFLUX_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_WEBFLUX_ENABLED","DD_INTEGRATION_SPRING_WEBFLUX_ENABLED"],
17751787
"DD_TRACE_SPRING_WEBFLUX_FUNCTIONAL_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_WEBFLUX_FUNCTIONAL_ENABLED","DD_INTEGRATION_SPRING_WEBFLUX_FUNCTIONAL_ENABLED"],
1788+
"DD_TRACE_SPRING_WEB_ANALYTICS_ENABLED": ["DD_SPRING_WEB_ANALYTICS_ENABLED"],
17761789
"DD_TRACE_SPRING_WEB_ANALYTICS_SAMPLE_RATE": ["DD_SPRING_WEB_ANALYTICS_SAMPLE_RATE"],
17771790
"DD_TRACE_SPRING_WEB_CODE_ORIGIN_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_WEB_CODE_ORIGIN_ENABLED","DD_INTEGRATION_SPRING_WEB_CODE_ORIGIN_ENABLED"],
17781791
"DD_TRACE_SPRING_WEB_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_WEB_ENABLED","DD_INTEGRATION_SPRING_WEB_ENABLED"],
@@ -1808,8 +1821,10 @@
18081821
"DD_TRACE_TOMCAT_CLASSLOADING_ENABLED": ["DD_TRACE_INTEGRATION_TOMCAT_CLASSLOADING_ENABLED","DD_INTEGRATION_TOMCAT_CLASSLOADING_ENABLED"],
18091822
"DD_TRACE_TOMCAT_ENABLED": ["DD_TRACE_INTEGRATION_TOMCAT_ENABLED","DD_INTEGRATION_TOMCAT_ENABLED"],
18101823
"DD_TRACE_TOMCAT_WEBSOCKET_ENABLED": ["DD_TRACE_INTEGRATION_TOMCAT_WEBSOCKET_ENABLED","DD_INTEGRATION_TOMCAT_WEBSOCKET_ENABLED"],
1824+
"DD_TRACE_TRACE_ANNOTATION_ANALYTICS_ENABLED": ["DD_TRACE_ANNOTATION_ANALYTICS_ENABLED"],
18111825
"DD_TRACE_TRACE_ANNOTATION_ANALYTICS_SAMPLE_RATE": ["DD_TRACE_ANNOTATION_ANALYTICS_SAMPLE_RATE"],
18121826
"DD_TRACE_TRACE_ANNOTATION_ENABLED": ["DD_TRACE_INTEGRATION_TRACE_ANNOTATION_ENABLED","DD_INTEGRATION_TRACE_ANNOTATION_ENABLED"],
1827+
"DD_TRACE_TRACE_CONFIG_ANALYTICS_ENABLED": ["DD_TRACE_CONFIG_ANALYTICS_ENABLED"],
18131828
"DD_TRACE_TRACE_CONFIG_ANALYTICS_SAMPLE_RATE": ["DD_TRACE_CONFIG_ANALYTICS_SAMPLE_RATE"],
18141829
"DD_TRACE_TRACE_CONFIG_ENABLED": ["DD_TRACE_INTEGRATION_TRACE_CONFIG_ENABLED","DD_INTEGRATION_TRACE_CONFIG_ENABLED"],
18151830
"DD_TRACE_TRACE_ENABLED": ["DD_TRACE_INTEGRATION_TRACE_ENABLED","DD_INTEGRATION_TRACE_ENABLED"],
@@ -1818,8 +1833,11 @@
18181833
"DD_TRACE_UNDERTOW_2_0_ENABLED": ["DD_TRACE_INTEGRATION_UNDERTOW_2_0_ENABLED","DD_INTEGRATION_UNDERTOW_2_0_ENABLED"],
18191834
"DD_TRACE_UNDERTOW_2_2_ENABLED": ["DD_TRACE_INTEGRATION_UNDERTOW_2_2_ENABLED","DD_INTEGRATION_UNDERTOW_2_2_ENABLED"],
18201835
"DD_TRACE_UNDERTOW_ENABLED": ["DD_TRACE_INTEGRATION_UNDERTOW_ENABLED","DD_INTEGRATION_UNDERTOW_ENABLED"],
1836+
"DD_TRACE_UNDERTOW_HTTP_ANALYTICS_ENABLED": ["DD_UNDERTOW_HTTP_ANALYTICS_ENABLED"],
18211837
"DD_TRACE_UNDERTOW_HTTP_ANALYTICS_SAMPLE_RATE": ["DD_UNDERTOW_HTTP_ANALYTICS_SAMPLE_RATE"],
1838+
"DD_TRACE_UNDERTOW_HTTP_SERVER_ANALYTICS_ENABLED": ["DD_UNDERTOW_HTTP_SERVER_ANALYTICS_ENABLED"],
18221839
"DD_TRACE_UNDERTOW_HTTP_SERVER_ANALYTICS_SAMPLE_RATE": ["DD_UNDERTOW_HTTP_SERVER_ANALYTICS_SAMPLE_RATE"],
1840+
"DD_TRACE_UNDERTOW_LEGACY_TRACING_ENABLED": ["DD_UNDERTOW_LEGACY_TRACING_ENABLED"],
18231841
"DD_TRACE_UNDERTOW_REQUEST_PARSE_ENABLED": ["DD_TRACE_INTEGRATION_UNDERTOW_REQUEST_PARSE_ENABLED","DD_INTEGRATION_UNDERTOW_REQUEST_PARSE_ENABLED"],
18241842
"DD_TRACE_URLCONNECTION_ANALYTICS_SAMPLE_RATE": ["DD_URLCONNECTION_ANALYTICS_SAMPLE_RATE"],
18251843
"DD_TRACE_URLCONNECTION_ENABLED": ["DD_TRACE_INTEGRATION_URLCONNECTION_ENABLED","DD_INTEGRATION_URLCONNECTION_ENABLED"],

dd-trace-api/src/main/java/datadog/trace/api/config/TracerConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public final class TracerConfig {
3838
"trace.experimental.features.enabled";
3939

4040
public static final String SPAN_TAGS = "trace.span.tags";
41-
public static final String TRACE_ANALYTICS_ENABLED = "trace.analytics.enabled";
41+
public static final String TRACE_ANALYTICS_ENABLED = "trace.1analytics.enabled";
4242

4343
@Deprecated
4444
public static final String TRACE_SAMPLING_SERVICE_RULES = "trace.sampling.service.rules";

internal-api/src/test/groovy/datadog/trace/api/telemetry/OtelEnvMetricCollectorTest.groovy

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package datadog.trace.api.telemetry
22

33
import datadog.trace.test.util.DDSpecification
4-
import datadog.environment.ConfigHelper
5-
import datadog.trace.api.ConfigInversionStrictStyle
64

75
// PLEASE READ
86
// When a metric is generated, it's duplicated in these tests. We call twice setupOteEnvironment() because of the separation of the configuration done in the rebuild function of DDSpecification between datadog/trace/api/InstrumenterConfig.java and internal-api/src/main/java/datadog/trace/api/Config.java.
@@ -12,16 +10,6 @@ import datadog.trace.api.ConfigInversionStrictStyle
1210

1311

1412
class OtelEnvMetricCollectorTest extends DDSpecification {
15-
// def strictness
16-
// def setup() {
17-
// strictness = ConfigHelper.configInversionStrictFlag()
18-
// ConfigHelper.setConfigInversionStrict(ConfigInversionStrictStyle.TEST)
19-
// }
20-
//
21-
// def cleanup(){
22-
// ConfigHelper.setConfigInversionStrict(strictness)
23-
// }
24-
2513
def "otel disabled - no metric"() {
2614
setup:
2715
injectEnvConfig('DD_SERVICE_NAME', 'DD_TEST_SERVICE', false)
@@ -213,5 +201,4 @@ class OtelEnvMetricCollectorTest extends DDSpecification {
213201
'OTEL_TRACES_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_traces_exporter'
214202
'OTEL_LOGS_EXPORTER' | 'otlp' || 'count' | 1 | 'tracers' | 'otel.env.unsupported' | 'config_opentelemetry:otel_logs_exporter'
215203
}
216-
217204
}

internal-api/src/test/groovy/datadog/trace/bootstrap/config/provider/ConfigProviderTest.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ package datadog.trace.bootstrap.config.provider
22

33
import datadog.trace.test.util.DDSpecification
44
import spock.lang.Shared
5+
import datadog.trace.api.ConfigInversionStrictStyle
6+
import datadog.environment.ConfigHelper
57

68
import static datadog.trace.api.config.TracerConfig.TRACE_HTTP_SERVER_PATH_RESOURCE_NAME_MAPPING
79

@@ -29,13 +31,18 @@ class ConfigProviderTest extends DDSpecification {
2931
injectEnvConfig("CONFIG_NAME", configNameValue)
3032
injectEnvConfig("CONFIG_ALIAS1", configAlias1Value)
3133
injectEnvConfig("CONFIG_ALIAS2", configAlias2Value)
34+
def strictness = ConfigHelper.configInversionStrictFlag()
35+
ConfigHelper.setConfigInversionStrict(ConfigInversionStrictStyle.TEST)
3236

3337
when:
3438
def config = configProvider.getString("CONFIG_NAME", null, "CONFIG_ALIAS1", "CONFIG_ALIAS2")
3539

3640
then:
3741
config == expected
3842

43+
cleanup:
44+
ConfigHelper.setConfigInversionStrict(strictness)
45+
3946
where:
4047
configNameValue | configAlias1Value | configAlias2Value | expected
4148
"default" | null | null | "default"

internal-api/src/test/groovy/datadog/trace/bootstrap/config/provider/StableConfigParserTest.groovy

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
package datadog.trace.bootstrap.config.provider
2+
3+
import datadog.environment.ConfigHelper
4+
import datadog.trace.api.ConfigInversionStrictStyle
25
import datadog.trace.test.util.DDSpecification
36
import java.nio.file.Files
47
import java.nio.file.Path
@@ -233,10 +236,15 @@ apm_configuration_rules:
233236
if (envKey != null) {
234237
injectEnvConfig(envKey, envVal)
235238
}
239+
def strictness = ConfigHelper.configInversionStrictFlag()
240+
ConfigHelper.setConfigInversionStrict(ConfigInversionStrictStyle.TEST)
236241

237242
then:
238243
StableConfigParser.processTemplate(templateVar) == expect
239244

245+
cleanup:
246+
ConfigHelper.setConfigInversionStrict(strictness)
247+
240248
where:
241249
templateVar | envKey | envVal | expect
242250
"{{environment_variables['DD_KEY']}}" | "DD_KEY" | "value" | "value"

0 commit comments

Comments
 (0)