Skip to content

Commit aae1e80

Browse files
Made latest SpotBugs passing.
1 parent 095d027 commit aae1e80

File tree

33 files changed

+57
-56
lines changed

33 files changed

+57
-56
lines changed

build.gradle.kts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@ plugins {
77
id("datadog.dump-hanged-test")
88

99
id("com.diffplug.spotless") version "6.13.0"
10-
// id("com.github.spotbugs") version "5.0.14"
11-
id("com.github.spotbugs") version "6.4.2"
12-
id("de.thetaphi.forbiddenapis") version "3.8"
10+
id("com.github.spotbugs") version "6.4.4"
11+
id("de.thetaphi.forbiddenapis") version "3.10"
1312
id("io.github.gradle-nexus.publish-plugin") version "2.0.0"
1413
id("com.gradleup.shadow") version "8.3.6" apply false
1514
id("me.champeau.jmh") version "0.7.3" apply false

buildSrc/call-site-instrumentation-plugin/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ dependencies {
3939
testImplementation("org.objenesis", "objenesis", "3.0.1")
4040
testImplementation(libs.groovy)
4141
testImplementation("javax.servlet", "javax.servlet-api", "3.0.1")
42-
testImplementation("com.github.spotbugs", "spotbugs-annotations", "4.2.0")
42+
testImplementation(libs.spotbugs.annotations)
4343
}
4444

4545
sourceSets {

communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public class SharedCommunicationObjects {
4747
@SuppressFBWarnings("PA_PUBLIC_PRIMITIVE_ATTRIBUTE")
4848
public boolean forceClearTextHttpForIntakeClient;
4949

50+
@SuppressFBWarnings("PA_PUBLIC_PRIMITIVE_ATTRIBUTE")
5051
public HttpUrl agentUrl;
5152

5253
@SuppressFBWarnings("PA_PUBLIC_PRIMITIVE_ATTRIBUTE")

dd-java-agent/agent-profiling/profiling-controller/src/main/java/com/datadog/profiling/controller/EnvironmentChecker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public static boolean checkEnvironment(String temp, StringBuilder sb) {
5050
boolean result = false;
5151
result |= checkJFR(sb);
5252
result |= checkDdprof(sb);
53-
if (!result) {;
53+
if (!result) {
5454
appendLine("Profiler is not supported on this JVM.", sb);
5555
return false;
5656
} else {

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/usm/UsmMessageImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ enum MessageType {
2222
private static final Logger log = LoggerFactory.getLogger(BaseUsmMessage.class);
2323

2424
// TODO: sync with systemprobe code
25-
static final NativeLong USM_IOCTL_ID = new NativeLong(0xda7ad09L);;
25+
static final NativeLong USM_IOCTL_ID = new NativeLong(0xda7ad09L);
2626

2727
abstract static class BaseUsmMessage implements UsmMessage {
2828

dd-java-agent/build.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
2-
32
import java.util.concurrent.atomic.AtomicBoolean
43

54
plugins {
@@ -29,7 +28,6 @@ tasks.named("processResources") {
2928
sourceSets {
3029
"main_java6" {
3130
java.srcDirs "${project.projectDir}/src/main/java6"
32-
3331
}
3432
main.resources.srcDir(includedAgentDir)
3533
}
@@ -43,7 +41,7 @@ tasks.named("compileJava") {
4341
}
4442

4543
dependencies {
46-
main_java6CompileOnly 'de.thetaphi:forbiddenapis:3.8'
44+
main_java6CompileOnly libs.forbiddenapis
4745
testImplementation sourceSets.main_java6.output
4846
}
4947

dd-java-agent/instrumentation/akka/akka-http/akka-http-10.0/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ dependencies {
117117
baseTestImplementation group: 'com.typesafe.akka', name: 'akka-http-spray-json_2.11', version: '10.0.10'
118118

119119
iastTestImplementation project(':dd-java-agent:agent-iast:iast-test-fixtures')
120-
iastTestCompileOnly group: 'de.thetaphi', name: 'forbiddenapis', version: '3.4'
120+
iastTestCompileOnly libs.forbiddenapis
121121
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core')
122122
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core:jackson-core-2.8')
123123
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:iast-instrumenter')

dd-java-agent/instrumentation/exception-profiling/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ apply from: "$rootDir/gradle/java.gradle"
1111
apply plugin: "idea"
1212

1313
dependencies {
14-
testImplementation 'de.thetaphi:forbiddenapis:3.8'
14+
testImplementation libs.forbiddenapis
1515
testImplementation libs.bundles.junit5
1616
testImplementation libs.bundles.jmc
1717
testImplementation libs.commons.math

dd-java-agent/instrumentation/kotlin-coroutines/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ dependencies {
6060
testFixturesApi project(':dd-trace-api')
6161
testFixturesApi project(':dd-java-agent:instrumentation:trace-annotation')
6262
testFixturesApi project(':dd-java-agent:instrumentation-testing')
63-
testFixturesApi 'com.github.spotbugs:spotbugs-annotations:4.2.0'
63+
testFixturesApi libs.spotbugs.annotations
6464

6565
testImplementation libs.kotlin
6666
testImplementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.0"

dd-java-agent/instrumentation/pekko/pekko-http-1.0/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ dependencies {
6363

6464
iastTestImplementation group: 'com.github.pjfanning', name: 'pekko-http-jackson_2.12', version: '2.1.0'
6565
iastTestImplementation project(':dd-java-agent:agent-iast:iast-test-fixtures')
66-
iastTestCompileOnly group: 'de.thetaphi', name: 'forbiddenapis', version: '3.4'
66+
iastTestCompileOnly libs.forbiddenapis
6767
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core')
6868
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:jackson-core:jackson-core-2.12')
6969
iastTestRuntimeOnly project(':dd-java-agent:instrumentation:iast-instrumenter')

0 commit comments

Comments
 (0)