Protect exception advices from NoClassDefFound

Author: amarziali

dd-java-agent/agent-bootstrap/src/main/java11/datadog/trace/bootstrap/instrumentation/jfr/exceptions/ExceptionProfiling.java

@@ -2,16 +2,29 @@
 
 import datadog.trace.api.Config;
 import datadog.trace.bootstrap.CallDepthThreadLocalMap;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * JVM-wide singleton exception profiling service. Uses {@linkplain Config} class to configure
  * itself using either system properties, environment or properties override.
  */
 public final class ExceptionProfiling {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(ExceptionProfiling.class);
+
   /** Lazy initialization-on-demand. */
   private static final class Holder {
-    static final ExceptionProfiling INSTANCE = new ExceptionProfiling(Config.get());
+    static final ExceptionProfiling INSTANCE = create();
+
+    private static ExceptionProfiling create() {
+      try {
+        return new ExceptionProfiling(Config.get());
+      } catch (Throwable t) {
+        LOGGER.debug("Unable to create ExceptionProfiling", t);
+        return null;
+      }
+    }
   }
 
   /**

dd-java-agent/agent-bootstrap/src/main/java11/datadog/trace/bootstrap/instrumentation/jfr/exceptions/ExceptionSampleEvent.java

@@ -45,7 +45,8 @@ public ExceptionSampleEvent(Throwable e, boolean sampled, boolean firstOccurrenc
   }
 
   private static String getMessage(Throwable t) {
-    if (ExceptionProfiling.getInstance().recordExceptionMessage()) {
+    final ExceptionProfiling exceptionProfiling = ExceptionProfiling.getInstance();
+    if (exceptionProfiling != null && exceptionProfiling.recordExceptionMessage()) {
       try {
         return t.getMessage();
       } catch (Throwable ignored) {

dd-java-agent/agent-profiling/profiling-controller-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/OpenJdkController.java

@@ -258,7 +258,10 @@ && isEventEnabled(recordingSettings, "jdk.NativeMethodSample")) {
     this.recordingSettings = Collections.unmodifiableMap(recordingSettings);
 
     if (isEventEnabled(this.recordingSettings, "datadog.ExceptionSample")) {
-      ExceptionProfiling.getInstance().start();
+      final ExceptionProfiling exceptionProfiling = ExceptionProfiling.getInstance();
+      if (exceptionProfiling != null) {
+        exceptionProfiling.start();
+      }
     }
 
     if (Config.get().isProfilingBackPressureSamplingEnabled()) {

dd-java-agent/instrumentation/exception-profiling/src/main/java11/datadog/exceptions/instrumentation/ThrowableInstanceAdvice.java

@@ -45,7 +45,11 @@ public static void onExit(@Advice.This final Object t) {
        * JFR will assign the stacktrace depending on the place where the event is committed.
        * Therefore, we need to commit the event here, right in the 'Exception' constructor
        */
-      final ExceptionSampleEvent event = ExceptionProfiling.getInstance().process((Throwable) t);
+      final ExceptionSampleEvent event = null;
+      final ExceptionProfiling exceptionProfiling = ExceptionProfiling.getInstance();
+      if (exceptionProfiling != null) {
+        exceptionProfiling.process((Throwable) t);
+      }
       if (event != null && event.shouldCommit()) {
         event.commit();
       }