Use mockito mocks in Runtime CSI tests (#9376)

Author: manuel-alvarez-alvarez

dd-java-agent/instrumentation/java-lang/build.gradle

@@ -11,4 +11,6 @@ addTestSuiteForDir('latestDepTest', 'test')
 
 dependencies {
   testRuntimeOnly project(':dd-java-agent:instrumentation:iast-instrumenter')
+  testImplementation libs.bundles.mockito
+  testImplementation group: 'org.mockito', name: 'mockito-inline', version: '4.11.0'
 }

dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/RuntimeCallSiteTest.groovy

@@ -1,17 +1,12 @@
 package datadog.trace.instrumentation.java.lang
 
-import datadog.environment.JavaVirtualMachine
 import datadog.trace.agent.test.AgentTestRunner
 import datadog.trace.api.iast.InstrumentationBridge
 import datadog.trace.api.iast.sink.CommandInjectionModule
 import foo.bar.TestRuntimeSuite
-import groovy.transform.CompileDynamic
-import spock.lang.IgnoreIf
 
-@CompileDynamic
-@IgnoreIf(reason = "TODO: Fix for Java 25.", value = {
-  JavaVirtualMachine.isJavaVersionAtLeast(25)
-})
+import static org.mockito.Mockito.mock
+
 class RuntimeCallSiteTest extends AgentTestRunner {
 
   @Override
@@ -21,7 +16,7 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
   def 'test exec with command string'() {
     setup:
-    final runtime = Mock(Runtime)
+    final runtime = mock(Runtime)
     CommandInjectionModule iastModule = Mock(CommandInjectionModule)
     final command = 'ls'
     InstrumentationBridge.registerIastModule(iastModule)
@@ -31,13 +26,12 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
     then:
     1 * iastModule.onRuntimeExec(command)
-    1 * runtime.exec(command)
     0 * _
   }
 
   def 'test exec with command string and env array'() {
     setup:
-    final runtime = Mock(Runtime)
+    final runtime = mock(Runtime)
     CommandInjectionModule iastModule = Mock(CommandInjectionModule)
     final command = 'ls'
     final env = ['DD_TRACE_DEBUG=true'] as String[]
@@ -48,13 +42,12 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
     then:
     1 * iastModule.onRuntimeExec(env, command)
-    1 * runtime.exec(command, env)
     0 * _
   }
 
   def 'test exec with command string array'() {
     setup:
-    final runtime = Mock(Runtime)
+    final runtime = mock(Runtime)
     CommandInjectionModule iastModule = Mock(CommandInjectionModule)
     final command = ['ls', '-lah'] as String[]
     InstrumentationBridge.registerIastModule(iastModule)
@@ -64,13 +57,12 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
     then:
     1 * iastModule.onRuntimeExec(command)
-    1 * runtime.exec(command)
     0 * _
   }
 
   def 'test exec with command string array and env array'() {
     setup:
-    final runtime = Mock(Runtime)
+    final runtime = mock(Runtime)
     CommandInjectionModule iastModule = Mock(CommandInjectionModule)
     final command = ['ls', '-lah'] as String[]
     final env = ['DD_TRACE_DEBUG=true'] as String[]
@@ -81,13 +73,12 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
     then:
     1 * iastModule.onRuntimeExec(env, command)
-    1 * runtime.exec(command, env)
     0 * _
   }
 
   def 'test exec with command string and env array and dir'() {
     setup:
-    final runtime = Mock(Runtime)
+    final runtime = mock(Runtime)
     CommandInjectionModule iastModule = Mock(CommandInjectionModule)
     final command = 'ls'
     final env = ['DD_TRACE_DEBUG=true'] as String[]
@@ -99,13 +90,12 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
     then:
     1 * iastModule.onRuntimeExec(env, command)
-    1 * runtime.exec(command, env, file)
     0 * _
   }
 
   def 'test exec with command string array and env array and dir'() {
     setup:
-    final runtime = Mock(Runtime)
+    final runtime = mock(Runtime)
     CommandInjectionModule iastModule = Mock(CommandInjectionModule)
     final command = ['ls', '-lah'] as String[]
     final env = ['DD_TRACE_DEBUG=true'] as String[]
@@ -117,7 +107,6 @@ class RuntimeCallSiteTest extends AgentTestRunner {
 
     then:
     1 * iastModule.onRuntimeExec(env, command)
-    1 * runtime.exec(command, env, file)
     0 * _
   }
 }