Skip to content

Commit b4e8516

Browse files
committed
fix errors and add tests
1 parent 6edb6f9 commit b4e8516

File tree

26 files changed

+418
-38
lines changed

26 files changed

+418
-38
lines changed

dd-java-agent/appsec/src/main/java/com/datadog/appsec/ddwaf/WAFModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ private Flow.Action.RequestBlockingAction createBlockRequestAction(
486486
log.warn("Unknown content type: {}; using auto", contentType);
487487
}
488488
return new Flow.Action.RequestBlockingAction(
489-
statusCode, blockingContentType, null, securityResponseId);
489+
statusCode, blockingContentType, Collections.emptyMap(), securityResponseId);
490490
} catch (RuntimeException cce) {
491491
log.warn("Invalid blocking action data", cce);
492492
if (!isRasp) {

dd-java-agent/instrumentation/grizzly/grizzly-http-2.3.20/src/main/java/datadog/trace/instrumentation/grizzlyhttp232/GrizzlyDecorator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ public boolean tryCommitBlockingResponse(
186186
return false;
187187
}
188188
return GrizzlyHttpBlockingHelper.block(
189-
ctx, acceptHeader, statusCode, templateType, extraHeaders, segment);
189+
ctx, acceptHeader, statusCode, templateType, extraHeaders, segment, securityResponseId);
190190
}
191191
}
192192
}

dd-java-agent/instrumentation/jetty/jetty-server/jetty-server-10.0/src/main/java11/datadog/trace/instrumentation/jetty10/JettyOnCommitBlockingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public static boolean block(
5454
BlockingActionHelper.TemplateType type =
5555
BlockingActionHelper.determineTemplateType(bct, acceptHeader);
5656
putHeader(fields, "Content-type", BlockingActionHelper.getContentType(type));
57-
byte[] template = BlockingActionHelper.getTemplate(type, securityResponseId);
57+
byte[] template = BlockingActionHelper.getTemplate(type, rba.getSecurityResponseId());
5858
putHeader(fields, "Content-length", Integer.toString(template.length));
5959

6060
info = new MetaData.Response(request.getHttpVersion(), statusCode, fields, template.length);

dd-java-agent/instrumentation/jetty/jetty-server/jetty-server-9.0.4/src/main/java/datadog/trace/instrumentation/jetty904/JettyOnCommitBlockingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public static boolean block(
5656
BlockingActionHelper.TemplateType type =
5757
BlockingActionHelper.determineTemplateType(bct, acceptHeader);
5858
fields.put("Content-type", BlockingActionHelper.getContentType(type));
59-
byte[] template = BlockingActionHelper.getTemplate(type, securityResponseId);
59+
byte[] template = BlockingActionHelper.getTemplate(type, rba.getSecurityResponseId());
6060
fields.put("Content-length", Integer.toString(template.length));
6161

6262
info =

dd-java-agent/instrumentation/jetty/jetty-server/jetty-server-9.3/src/main/java/datadog/trace/instrumentation/jetty93/JettyOnCommitBlockingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static boolean block(
5555
BlockingActionHelper.TemplateType type =
5656
BlockingActionHelper.determineTemplateType(bct, acceptHeader);
5757
fields.put("Content-type", BlockingActionHelper.getContentType(type));
58-
byte[] template = BlockingActionHelper.getTemplate(type, securityResponseId);
58+
byte[] template = BlockingActionHelper.getTemplate(type, rba.getSecurityResponseId());
5959
fields.put("Content-length", Integer.toString(template.length));
6060

6161
info = new MetaData.Response(request.getHttpVersion(), statusCode, fields, template.length);

dd-java-agent/instrumentation/jetty/jetty-server/jetty-server-9.4.21/src/main/java/datadog/trace/instrumentation/jetty9421/JettyOnCommitBlockingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static boolean block(
5555
BlockingActionHelper.TemplateType type =
5656
BlockingActionHelper.determineTemplateType(bct, acceptHeader);
5757
fields.put("Content-type", BlockingActionHelper.getContentType(type));
58-
byte[] template = BlockingActionHelper.getTemplate(type, securityResponseId);
58+
byte[] template = BlockingActionHelper.getTemplate(type, rba.getSecurityResponseId());
5959
fields.put("Content-length", Integer.toString(template.length));
6060

6161
info = new MetaData.Response(request.getHttpVersion(), statusCode, fields, template.length);

dd-java-agent/instrumentation/liberty/liberty-20.0/src/main/java/datadog/trace/instrumentation/liberty20/LibertyBlockingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static BlockingException syncBufferEnter(
9090
BlockingActionHelper.TemplateType type =
9191
BlockingActionHelper.determineTemplateType(
9292
bct, thiz.getRequest().getHeader("Accept").asString());
93-
byte[] template = BlockingActionHelper.getTemplate(type, securityResponseId);
93+
byte[] template = BlockingActionHelper.getTemplate(type, rba.getSecurityResponseId());
9494
response.setHeader("Content-length", Integer.toString(template.length));
9595
response.setHeader("Content-type", BlockingActionHelper.getContentType(type));
9696
WsByteBufferImpl buffer = new WsByteBufferImpl(ByteBuffer.wrap(template));

dd-java-agent/instrumentation/liberty/liberty-20.0/src/main/java/datadog/trace/instrumentation/liberty20/LibertyDecorator.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,13 @@ public boolean tryCommitBlockingResponse(
193193
return false;
194194
}
195195
ServletBlockingHelper.commitBlockingResponse(
196-
segment, request, (HttpServletResponse) response, statusCode, bct, extraHeaders);
196+
segment,
197+
request,
198+
(HttpServletResponse) response,
199+
statusCode,
200+
bct,
201+
extraHeaders,
202+
securityResponseId);
197203

198204
return true;
199205
}

dd-java-agent/instrumentation/liberty/liberty-23.0/src/main/java/datadog/trace/instrumentation/liberty23/LibertyBlockingHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static BlockingException syncBufferEnter(
9090
BlockingActionHelper.TemplateType type =
9191
BlockingActionHelper.determineTemplateType(
9292
bct, thiz.getRequest().getHeader("Accept").asString());
93-
byte[] template = BlockingActionHelper.getTemplate(type, securityResponseId);
93+
byte[] template = BlockingActionHelper.getTemplate(type, rba.getSecurityResponseId());
9494
response.setHeader("Content-length", Integer.toString(template.length));
9595
response.setHeader("Content-type", BlockingActionHelper.getContentType(type));
9696
WsByteBufferImpl buffer = new WsByteBufferImpl(ByteBuffer.wrap(template));

dd-java-agent/instrumentation/liberty/liberty-23.0/src/main/java/datadog/trace/instrumentation/liberty23/LibertyDecorator.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,13 @@ public boolean tryCommitBlockingResponse(
194194
return false;
195195
}
196196
JakartaServletBlockingHelper.commitBlockingResponse(
197-
segment, request, (HttpServletResponse) response, statusCode, bct, extraHeaders);
197+
segment,
198+
request,
199+
(HttpServletResponse) response,
200+
statusCode,
201+
bct,
202+
extraHeaders,
203+
securityResponseId);
198204

199205
return true;
200206
}

0 commit comments

Comments
 (0)