Skip to content

Commit c08d6d9

Browse files
fix(ci): Allow CI to use unpinned version of docker build image (#8943)
1 parent c4c5d62 commit c08d6d9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/update-docker-build-image.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
echo "::notice::Using Docker build image tag: ${TAG}"
5353
- name: Update the Docker build image in GitLab CI config
5454
run: |
55-
sed -i 's|JAVA_BUILD_IMAGE_VERSION:.*|JAVA_BUILD_IMAGE_VERSION:"${{ steps.define-tag.outputs.tag }}"|' .gitlab-ci.yml
55+
sed -i 's|BUILDER_IMAGE_VERSION_PREFIX:.*|BUILDER_IMAGE_VERSION_PREFIX:"${{ steps.define-tag.outputs.tag }}-"|' .gitlab-ci.yml
5656
- name: Commit and push changes
5757
env:
5858
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

.gitlab-ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ variables:
2727
GRADLE_VERSION: "8.5" # must match gradle-wrapper.properties
2828
MAVEN_REPOSITORY_PROXY: "http://artifactual.artifactual.all-clusters.local-dc.fabric.dog:8081/repository/maven-central/"
2929
GRADLE_PLUGIN_PROXY: "http://artifactual.artifactual.all-clusters.local-dc.fabric.dog:8081/repository/gradle-plugin-portal-proxy/"
30-
JAVA_BUILD_IMAGE_VERSION: "v25.05"
30+
BUILDER_IMAGE_VERSION_PREFIX: "v25.05-"
3131
REPO_NOTIFICATION_CHANNEL: "#apm-java-escalations"
3232
DEFAULT_TEST_JVMS: /^(8|11|17|21)$/
3333
PROFILE_TESTS:
@@ -97,7 +97,7 @@ default:
9797
- echo "NORMALIZED_NODE_TOTAL=${NORMALIZED_NODE_TOTAL}, NORMALIZED_NODE_INDEX=$NORMALIZED_NODE_INDEX"
9898

9999
.gradle_build: &gradle_build
100-
image: ghcr.io/datadog/dd-trace-java-docker-build:${JAVA_BUILD_IMAGE_VERSION}-base
100+
image: ghcr.io/datadog/dd-trace-java-docker-build:${BUILDER_IMAGE_VERSION_PREFIX}base
101101
stage: build
102102
variables:
103103
MAVEN_OPTS: "-Xms64M -Xmx512M"
@@ -228,7 +228,7 @@ spotless:
228228

229229
test_published_artifacts:
230230
extends: .gradle_build
231-
image: ghcr.io/datadog/dd-trace-java-docker-build:${JAVA_BUILD_IMAGE_VERSION}-7 # Needs Java7 for some tests
231+
image: ghcr.io/datadog/dd-trace-java-docker-build:${BUILDER_IMAGE_VERSION_PREFIX}7 # Needs Java7 for some tests
232232
stage: tests
233233
needs: [ build ]
234234
variables:
@@ -366,7 +366,7 @@ muzzle-dep-report:
366366

367367
.test_job:
368368
extends: .gradle_build
369-
image: ghcr.io/datadog/dd-trace-java-docker-build:$testJvm
369+
image: ghcr.io/datadog/dd-trace-java-docker-build:${BUILDER_IMAGE_VERSION_PREFIX}$testJvm
370370
tags: [ "docker-in-docker:amd64" ] # use docker-in-docker runner for testcontainers
371371
needs: [ build_tests ]
372372
stage: tests

0 commit comments

Comments
 (0)