add basic exception replay integration in agent mode

Author: daniel-mohedano

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/CiVisibilitySystem.java

@@ -101,6 +101,10 @@ public static void start(Instrumentation inst, SharedCommunicationObjects sco) {
         inst.addTransformer(new CoverageClassTransformer(instrumentationFilter));
       }
 
+      if (executionSettings.isFailedTestReplayEnabled()) {
+        // TODO
+      }
+
       CiVisibilityCoverageServices.Child coverageServices =
           new CiVisibilityCoverageServices.Child(services, repoServices, executionSettings);
       TestEventsHandlerFactory testEventsHandlerFactory =

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/buildsystem/BuildSystemModuleImpl.java

@@ -12,7 +12,9 @@
 import datadog.trace.api.civisibility.domain.JavaAgent;
 import datadog.trace.api.civisibility.telemetry.CiVisibilityMetricCollector;
 import datadog.trace.api.config.CiVisibilityConfig;
+import datadog.trace.api.config.DebuggerConfig;
 import datadog.trace.api.config.GeneralConfig;
+import datadog.trace.api.config.RemoteConfigConfig;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpanContext;
 import datadog.trace.bootstrap.instrumentation.api.Tags;
@@ -182,6 +184,20 @@ private Map<String, String> getPropertiesPropagatedToChildProcess(
         Strings.propertyNameToSystemPropertyName(CiVisibilityConfig.TEST_MANAGEMENT_ENABLED),
         Boolean.toString(executionSettings.getTestManagementSettings().isEnabled()));
 
+    // enable exception replay if failed test replay is enabled
+    if (executionSettings.isFailedTestReplayEnabled()) {
+      propagatedSystemProperties.put(
+          Strings.propertyNameToSystemPropertyName(
+              CiVisibilityConfig.TEST_FAILED_TEST_REPLAY_ENABLED),
+          "true");
+      propagatedSystemProperties.put(
+          Strings.propertyNameToSystemPropertyName(DebuggerConfig.EXCEPTION_REPLAY_ENABLED),
+          "true");
+      propagatedSystemProperties.put(
+          Strings.propertyNameToSystemPropertyName(RemoteConfigConfig.REMOTE_CONFIGURATION_ENABLED),
+          "true");
+    }
+
     // explicitly disable build instrumentation in child processes,
     // because some projects run "embedded" Maven/Gradle builds as part of their integration tests,
     // and we don't want to show those as if they were regular build executions

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception/DefaultExceptionDebugger.java

@@ -9,6 +9,7 @@
 import com.datadog.debugger.sink.Snapshot;
 import com.datadog.debugger.util.CircuitBreaker;
 import com.datadog.debugger.util.ExceptionHelper;
+import datadog.trace.api.Config;
 import datadog.trace.bootstrap.debugger.DebuggerContext;
 import datadog.trace.bootstrap.debugger.DebuggerContext.ClassNameFilter;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
@@ -34,6 +35,10 @@ public class DefaultExceptionDebugger implements DebuggerContext.ExceptionDebugg
   public static final String ERROR_DEBUG_INFO_CAPTURED = "error.debug_info_captured";
   public static final String SNAPSHOT_ID_TAG_FMT = DD_DEBUG_ERROR_PREFIX + "%d.snapshot_id";
 
+  // Test Optimization / Failed Test Replay specific
+  public static final String TEST_DEBUG_ERROR_FILE_TAG_FMT = DD_DEBUG_ERROR_PREFIX + "%d.file";
+  public static final String TEST_DEBUG_ERROR_LINE_TAG_FMT = DD_DEBUG_ERROR_PREFIX + "%d.line";
+
   private final ExceptionProbeManager exceptionProbeManager;
   private final ConfigurationUpdater configurationUpdater;
   private final ClassNameFilter classNameFiltering;
@@ -69,7 +74,7 @@ public DefaultExceptionDebugger(
 
   @Override
   public void handleException(Throwable t, AgentSpan span) {
-    if (t instanceof Error) {
+    if (t instanceof Error && !Config.get().isCiVisibilityEnabled()) {
       if (LOGGER.isDebugEnabled()) {
         LOGGER.debug("Skip handling error: {}", t.toString());
       }
@@ -93,6 +98,7 @@ public void handleException(Throwable t, AgentSpan span) {
     if (exceptionProbeManager.isAlreadyInstrumented(fingerprint)) {
       ThrowableState state = exceptionProbeManager.getStateByThrowable(innerMostException);
       if (state == null) {
+        LOGGER.info("Unable to find state for throwable: {}", innerMostException.toString());
         LOGGER.debug("Unable to find state for throwable: {}", innerMostException.toString());
         return;
       }
@@ -108,7 +114,12 @@ public void handleException(Throwable t, AgentSpan span) {
             exceptionProbeManager.createProbesForException(
                 throwable.getStackTrace(), chainedExceptionIdx);
         if (creationResult.probesCreated > 0) {
-          AgentTaskScheduler.INSTANCE.execute(() -> applyExceptionConfiguration(fingerprint));
+          LOGGER.info("Creating probes for: {}", t.getMessage());
+          if (Config.get().isCiVisibilityEnabled()) {
+             applyExceptionConfiguration(fingerprint);
+          } else {
+            AgentTaskScheduler.INSTANCE.execute(() -> applyExceptionConfiguration(fingerprint));
+          }
           break;
         } else {
           if (LOGGER.isDebugEnabled()) {
@@ -147,6 +158,7 @@ private static void processSnapshotsAndSetTags(
                 }
               });
     }
+    LOGGER.info("Processing exception snapshot for: {}", t.getMessage());
     boolean snapshotAssigned = false;
     List<Snapshot> snapshots = state.getSnapshots();
     int maxSnapshotSize = Math.min(snapshots.size(), maxCapturedFrames);
@@ -166,10 +178,26 @@ private static void processSnapshotsAndSetTags(
       String tagName = String.format(SNAPSHOT_ID_TAG_FMT, frameIndex);
       span.setTag(tagName, snapshot.getId());
       LOGGER.debug("add tag to span[{}]: {}: {}", span.getSpanId(), tagName, snapshot.getId());
+
+      StackTraceElement stackFrame = innerTrace[currentIdx];
+      String fileTag = String.format(TEST_DEBUG_ERROR_FILE_TAG_FMT, frameIndex);
+      String lineTag = String.format(TEST_DEBUG_ERROR_LINE_TAG_FMT, frameIndex);
+      span.setTag(fileTag, stackFrame.getFileName());
+      span.setTag(lineTag, stackFrame.getLineNumber());
+
+      LOGGER.debug(
+          "add ftr debug tags to span[{}]: {}={}, {}={}",
+          span.getSpanId(),
+          fileTag,
+          stackFrame.getFileName(),
+          lineTag,
+          stackFrame.getLineNumber());
+
       if (!state.isSnapshotSent()) {
         DebuggerAgent.getSink().addSnapshot(snapshot);
       }
       snapshotAssigned = true;
+      LOGGER.info("Capture for {}: {}", t.getMessage(), snapshots.get(i).getVariables());
     }
     if (snapshotAssigned) {
       state.markAsSnapshotSent();

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/Snapshot.java

@@ -12,6 +12,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.stream.Collectors;
 
 /** Data class representing all data collected at a probe location */
 public class Snapshot {
@@ -161,6 +162,18 @@ public List<EvaluationError> getEvaluationErrors() {
     return evaluationErrors;
   }
 
+  public String getVariables() {
+    String variables = "";
+    CapturedContext returnContext = captures.getReturn();
+    if (returnContext != null) {
+      Map<String, CapturedContext.CapturedValue> allVars = new HashMap<>();
+      if (returnContext.getArguments() != null) allVars.putAll(returnContext.getArguments());
+      if (returnContext.getLocals() != null) allVars.putAll(returnContext.getLocals());
+      variables = allVars.entrySet().stream().map(e -> e.getKey() + "=" + e.getValue().getStrValue()).collect(Collectors.joining(", "));
+    }
+    return variables;
+  }
+
   public void addEvaluationErrors(List<EvaluationError> errors) {
     if (errors == null || errors.isEmpty()) {
       return;

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -4009,7 +4009,13 @@ public Set<String> getThirdPartyShadingIdentifiers() {
   }
 
   private String getFinalDebuggerBaseUrl() {
-    if (agentUrl.startsWith("unix:")) {
+    if (isCiVisibilityEnabled() && isCiVisibilityAgentlessEnabled()) {
+      String agentlessUrl = getCiVisibilityAgentlessUrl();
+      if (Strings.isNotBlank(agentlessUrl)) {
+        return agentlessUrl;
+      }
+      return "https://http-intake.logs." + getSite();
+    } else if (agentUrl.startsWith("unix:")) {
       // provide placeholder agent URL, in practice we'll be tunnelling over UDS
       return "http://" + agentHost + ":" + agentPort;
     } else {