Skip to content

Commit c7eeac8

Browse files
fix: tests
1 parent 4f2d6a9 commit c7eeac8

File tree

12 files changed

+26
-6
lines changed

12 files changed

+26
-6
lines changed

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/buildsystem/BuildSystemModuleImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import datadog.trace.api.config.CiVisibilityConfig;
1515
import datadog.trace.api.config.DebuggerConfig;
1616
import datadog.trace.api.config.GeneralConfig;
17-
import datadog.trace.api.config.RemoteConfigConfig;
1817
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
1918
import datadog.trace.bootstrap.instrumentation.api.AgentSpanContext;
2019
import datadog.trace.bootstrap.instrumentation.api.Tags;

dd-java-agent/agent-ci-visibility/src/testFixtures/groovy/datadog/trace/civisibility/CiVisibilityInstrumentationTest.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
9696
injectSysConfig(CiVisibilityConfig.TEST_MANAGEMENT_ENABLED, "true")
9797
injectSysConfig(CiVisibilityConfig.TEST_MANAGEMENT_ATTEMPT_TO_FIX_RETRIES, "5")
9898
injectSysConfig(CiVisibilityConfig.CIVISIBILITY_TEST_ORDER, CIConstants.FAIL_FAST_TEST_ORDER)
99+
injectSysConfig(CiVisibilityConfig.TEST_FAILED_TEST_REPLAY_ENABLED, "true")
99100
}
100101

101102
private static final class Settings {
@@ -112,6 +113,7 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
112113
private volatile boolean earlyFlakinessDetectionEnabled
113114
private volatile boolean impactedTestsDetectionEnabled
114115
private volatile boolean testManagementEnabled
116+
private volatile boolean failedTestReplayEnabled
115117
}
116118

117119
private final Settings settings = new Settings()
@@ -233,6 +235,7 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
233235
settings.itrEnabled,
234236
settings.flakyRetryEnabled,
235237
settings.impactedTestsDetectionEnabled,
238+
settings.failedTestReplayEnabled,
236239
earlyFlakinessDetectionSettings,
237240
testManagementSettings,
238241
settings.itrEnabled ? "itrCorrelationId" : null,
@@ -346,6 +349,10 @@ abstract class CiVisibilityInstrumentationTest extends AgentTestRunner {
346349
settings.impactedTestsDetectionEnabled = impactedTestsDetectionEnabled
347350
}
348351

352+
def givenFailedTestReplayEnabled(boolean failedTestReplayEnabled) {
353+
settings.failedTestReplayEnabled = failedTestReplayEnabled
354+
}
355+
349356
def assertSpansData(String testcaseName, Map<String, String> replacements = [:], List<String> ignoredTags = []) {
350357
Predicate<DDSpan> sessionSpan = span -> span.spanType == "test_session_end"
351358
spanFilter.waitForSpan(sessionSpan, TimeUnit.SECONDS.toMillis(20))

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception/DefaultExceptionDebugger.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ public void handleException(Throwable t, AgentSpan span) {
115115
throwable.getStackTrace(), chainedExceptionIdx);
116116
if (creationResult.probesCreated > 0) {
117117
if (Config.get().isCiVisibilityFailedTestReplayEnabled()) {
118-
// Assume Exception Replay is working under Failed Test Replay logic,
119-
// instrumentation applied sync for immediate test retries
120-
applyExceptionConfiguration(fingerprint);
118+
// Assume Exception Replay is working under Failed Test Replay logic,
119+
// instrumentation applied sync for immediate test retries
120+
applyExceptionConfiguration(fingerprint);
121121
} else {
122122
AgentTaskScheduler.INSTANCE.execute(() -> applyExceptionConfiguration(fingerprint));
123123
}

dd-java-agent/instrumentation/junit-4.10/cucumber-junit-4/src/main/java/datadog/trace/instrumentation/junit4/CucumberUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public static String getVersion() {
7373
LibraryCapability.TIA,
7474
LibraryCapability.ATR,
7575
LibraryCapability.EFD,
76+
LibraryCapability.FTR,
7677
LibraryCapability.QUARANTINE,
7778
LibraryCapability.DISABLED,
7879
LibraryCapability.ATTEMPT_TO_FIX);

dd-java-agent/instrumentation/junit-4.10/munit-junit-4/src/main/java/datadog/trace/instrumentation/junit4/MUnitUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public abstract class MUnitUtils {
2727
LibraryCapability.ATR,
2828
LibraryCapability.EFD,
2929
LibraryCapability.IMPACTED,
30+
LibraryCapability.FTR,
3031
LibraryCapability.QUARANTINE,
3132
LibraryCapability.ATTEMPT_TO_FIX);
3233

dd-java-agent/instrumentation/junit-4.10/src/main/java/datadog/trace/instrumentation/junit4/JUnit4Utils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public abstract class JUnit4Utils {
6565
LibraryCapability.ATR,
6666
LibraryCapability.EFD,
6767
LibraryCapability.IMPACTED,
68+
LibraryCapability.FTR,
6869
LibraryCapability.QUARANTINE,
6970
LibraryCapability.DISABLED,
7071
LibraryCapability.ATTEMPT_TO_FIX);

dd-java-agent/instrumentation/junit-5.3/src/main/java/datadog/trace/instrumentation/junit5/JUnitPlatformUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ public abstract class JUnitPlatformUtils {
5959
LibraryCapability.ATR,
6060
LibraryCapability.EFD,
6161
LibraryCapability.IMPACTED,
62+
LibraryCapability.FTR,
6263
LibraryCapability.QUARANTINE,
6364
LibraryCapability.DISABLED,
6465
LibraryCapability.ATTEMPT_TO_FIX);
@@ -69,6 +70,7 @@ public abstract class JUnitPlatformUtils {
6970
LibraryCapability.ATR,
7071
LibraryCapability.EFD,
7172
LibraryCapability.IMPACTED,
73+
LibraryCapability.FTR,
7274
LibraryCapability.QUARANTINE,
7375
LibraryCapability.DISABLED,
7476
LibraryCapability.ATTEMPT_TO_FIX,
@@ -80,6 +82,7 @@ public abstract class JUnitPlatformUtils {
8082
LibraryCapability.ATR,
8183
LibraryCapability.EFD,
8284
LibraryCapability.IMPACTED,
85+
LibraryCapability.FTR,
8386
LibraryCapability.QUARANTINE,
8487
LibraryCapability.DISABLED,
8588
LibraryCapability.ATTEMPT_TO_FIX);
@@ -89,6 +92,7 @@ public abstract class JUnitPlatformUtils {
8992
LibraryCapability.TIA,
9093
LibraryCapability.ATR,
9194
LibraryCapability.EFD,
95+
LibraryCapability.FTR,
9296
LibraryCapability.QUARANTINE,
9397
LibraryCapability.DISABLED,
9498
LibraryCapability.ATTEMPT_TO_FIX);

dd-java-agent/instrumentation/karate/src/main/java/datadog/trace/instrumentation/karate/KarateUtils.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,15 @@ private KarateUtils() {}
5656
Arrays.asList(
5757
LibraryCapability.ATR,
5858
LibraryCapability.EFD,
59+
LibraryCapability.FTR,
5960
LibraryCapability.QUARANTINE,
6061
LibraryCapability.ATTEMPT_TO_FIX);
6162

6263
public static final List<LibraryCapability> CAPABILITIES_SKIPPING =
6364
Arrays.asList(
6465
LibraryCapability.ATR,
6566
LibraryCapability.EFD,
67+
LibraryCapability.FTR,
6668
LibraryCapability.QUARANTINE,
6769
LibraryCapability.ATTEMPT_TO_FIX,
6870
LibraryCapability.TIA,

dd-java-agent/instrumentation/scalatest/src/main/java/datadog/trace/instrumentation/scalatest/ScalatestUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public abstract class ScalatestUtils {
2424
LibraryCapability.EFD,
2525
LibraryCapability.ATR,
2626
LibraryCapability.IMPACTED,
27+
LibraryCapability.FTR,
2728
LibraryCapability.QUARANTINE,
2829
LibraryCapability.DISABLED,
2930
LibraryCapability.ATTEMPT_TO_FIX);

dd-java-agent/instrumentation/testng/src/main/java/datadog/trace/instrumentation/testng/TestNGUtils.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,10 @@ public static List<LibraryCapability> capabilities(String version) {
282282
List<LibraryCapability> baseCapabilities =
283283
new ArrayList<>(
284284
Arrays.asList(
285-
LibraryCapability.TIA, LibraryCapability.IMPACTED, LibraryCapability.DISABLED));
285+
LibraryCapability.TIA,
286+
LibraryCapability.IMPACTED,
287+
LibraryCapability.FTR,
288+
LibraryCapability.DISABLED));
286289

287290
boolean isEFDSupported = isEFDSupported(version);
288291
boolean isExceptionSuppressionSupported = isExceptionSuppressionSupported(version);

0 commit comments

Comments
 (0)