fix: conditional trigger for test env should be conditional

Author: daniel-mohedano

.gitlab/ci-visibility-tests.yml

@@ -21,30 +21,28 @@ check-ci-visibility-label:
     - |
       # Source utility functions
       source .gitlab/ci_visibility_utils.sh
+      touch ci-visibility-pr.env
       
       # Get PR number
-      if ! PR_NUMBER=$(get_pr_number "${CI_COMMIT_BRANCH}"); then
+      if ! CI_VIS_PR_NUMBER=$(get_pr_number "${CI_COMMIT_BRANCH}"); then
         echo "No open PR found for branch ${CI_COMMIT_BRANCH}"
-        exit 1
+        exit 0
       fi
       
-      echo "Found PR #${PR_NUMBER}"
+      echo "Found PR #${CI_VIS_PR_NUMBER}"
       
       # Check if PR has the CI visibility label
-      if pr_has_label "$PR_NUMBER" "comp: ci visibility"; then
-        echo "PR_NUMBER=${PR_NUMBER}" > pr.env
-        echo "PR #${PR_NUMBER} detected as CI Visibility PR"
-        exit 0
+      if pr_has_label "$CI_VIS_PR_NUMBER" "comp: ci visibility"; then
+        echo "CI_VIS_PR_NUMBER=${CI_VIS_PR_NUMBER}" > ci-visibility-pr.env
+        echo "PR #${CI_VIS_PR_NUMBER} detected as CI Visibility PR"
       else
-        echo "PR #${PR_NUMBER} not a CI Visibility PR, ignoring trigger"
-        exit 1
+        echo "PR #${CI_VIS_PR_NUMBER} not a CI Visibility PR, ignoring trigger"
       fi
   after_script:
     - dd-octo-sts revoke -t $(cat github-token.txt) || true
   artifacts:
     reports:
-      dotenv: pr.env
-  allow_failure: true
+      dotenv: ci-visibility-pr.env
   retry:
     max: 2
     when: always
@@ -57,7 +55,7 @@ run-ci-visibility-test-environment:
   rules:
     - if: '$POPULATE_CACHE'
       when: never
-    - if: '$CI_COMMIT_BRANCH && $CI_COMMIT_BRANCH !~ /^(master|release\/)/'
+    - if: '$CI_COMMIT_BRANCH && $CI_COMMIT_BRANCH !~ /^(master|release\/)/ && $CI_VIS_PR_NUMBER'
       when: on_success
   trigger:
     project: DataDog/apm-reliability/test-environment
@@ -74,4 +72,4 @@ run-ci-visibility-test-environment:
     UPSTREAM_COMMIT_SHORT_SHA: $CI_COMMIT_SHORT_SHA
     TRACER_LANG: java
     JAVA_TRACER_REF_TO_TEST: $CI_COMMIT_BRANCH
-    JAVA_TRACER_PR_TO_TEST: $PR_NUMBER
+    JAVA_TRACER_PR_TO_TEST: $CI_VIS_PR_NUMBER