Refactored AssertJ, Hamcrest and Google.Truth to Junit5.Assertions. (#9556)

Author: AlexeyKuznetsov-DD

buildSrc/build.gradle.kts

@@ -76,7 +76,6 @@ testing {
     val integTest by registering(JvmTestSuite::class) {
       dependencies {
         implementation(gradleTestKit())
-        implementation("org.assertj:assertj-core:3.25.3")
       }
       // Makes the gradle plugin publish its declared plugins to this source set
       gradlePlugin.testSourceSet(sources)

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt

@@ -1,10 +1,8 @@
 package datadog.gradle.plugin.version
 
-import org.assertj.core.api.Assertions.assertThat
 import org.gradle.testkit.runner.GradleRunner
-import org.junit.jupiter.api.Disabled
+import org.junit.jupiter.api.Assertions.assertEquals
 import org.junit.jupiter.api.Test
-import org.junit.jupiter.api.io.CleanupMode
 import org.junit.jupiter.api.io.TempDir
 import java.io.File
 import java.io.IOException
@@ -289,7 +287,7 @@ class TracerVersionIntegrationTest {
       // .withDebug(true)
       .build()
 
-    assertThat(buildResult.output).isEqualToIgnoringNewLines(expectedVersion)
+    assertEquals(expectedVersion, buildResult.output.lines().first())
   }
 
   private fun exec(workingDirectory: File, vararg args: String) {

communication/build.gradle.kts

@@ -23,7 +23,6 @@ dependencies {
 
   testImplementation(project(":utils:test-utils"))
   testImplementation(libs.bundles.junit5)
-  testImplementation(libs.truth)
   testImplementation(libs.bytebuddy)
   testImplementation("org.msgpack:msgpack-core:0.8.20")
   testImplementation("org.msgpack:jackson-dataformat-msgpack:0.8.20")

communication/src/test/groovy/datadog/communication/http/SafeRequestBuilderTest.groovy

@@ -1,31 +1,34 @@
 package datadog.communication.http
 
-import com.google.common.truth.Truth
 import okhttp3.Request
-import org.junit.jupiter.api.Assertions
 import org.junit.jupiter.api.Test
 
+import static org.junit.jupiter.api.Assertions.assertFalse
+import static org.junit.jupiter.api.Assertions.assertThrows
+import static org.junit.jupiter.api.Assertions.assertTrue
+
 class SafeRequestBuilderTest {
   Request.Builder testBuilder = new Request.Builder()
 
   @Test
   void "test adding bad header"() {
     def name = 'bad'
     def password = 'very-secret-password'
-    IllegalArgumentException ex = Assertions.assertThrows(IllegalArgumentException, {
+    IllegalArgumentException ex = assertThrows(IllegalArgumentException, {
       testBuilder.url("http:localhost").addHeader(name, "$password\n")
     })
-    Truth.assertThat(ex).hasMessageThat().contains(name)
-    Truth.assertThat(ex).hasMessageThat().doesNotContain(password)
+    assertTrue(ex.getMessage().contains(name))
+    assertFalse(ex.getMessage().contains(password))
   }
+
   @Test
   void "test adding bad header2"(){
     def name = '\u0019'
     def password = 'very-secret-password'
-    IllegalArgumentException ex = Assertions.assertThrows(IllegalArgumentException, {
+    IllegalArgumentException ex = assertThrows(IllegalArgumentException, {
       testBuilder.url("http:localhost").addHeader(name, "\u0080$password")
     })
-    Truth.assertThat(ex).hasMessageThat().contains(name)
-    Truth.assertThat(ex).hasMessageThat().doesNotContain(password)
+    assertTrue(ex.getMessage().contains(name))
+    assertFalse(ex.getMessage().contains(password))
   }
 }

dd-java-agent/agent-profiling/profiling-controller-openjdk/build.gradle

@@ -26,7 +26,6 @@ dependencies {
 
   testImplementation libs.bundles.junit5
   testImplementation libs.bundles.mockito
-  testImplementation group: 'org.hamcrest', name: 'hamcrest', version: '2.1'
   testImplementation files(project(':dd-java-agent:agent-profiling:profiling-controller-jfr').sourceSets.test.output)
   testImplementation project(':dd-java-agent:agent-profiling')
 }

dd-java-agent/agent-profiling/profiling-controller-openjdk/src/test/java/com/datadog/profiling/controller/openjdk/OpenJdkRecordingDataTest.java

@@ -1,9 +1,8 @@
 package com.datadog.profiling.controller.openjdk;
 
-import static org.hamcrest.CoreMatchers.containsString;
-import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assumptions.assumeFalse;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -76,7 +75,7 @@ public void testGetName() {
 
   @Test
   public void testToString() {
-    assertThat(recordingData.toString(), containsString(TEST_NAME));
+    assertTrue(recordingData.toString().contains(TEST_NAME));
   }
 
   @Test

dd-java-agent/agent-profiling/profiling-controller-oracle/build.gradle

@@ -24,7 +24,6 @@ dependencies {
 
   testImplementation libs.bundles.junit5
   testImplementation libs.bundles.mockito
-  testImplementation group: 'org.hamcrest', name: 'hamcrest', version: '2.1'
   testImplementation files(project(':dd-java-agent:agent-profiling:profiling-controller-jfr').sourceSets.test.output)
   testImplementation project(':dd-java-agent:agent-profiling')
 }

dd-java-agent/agent-profiling/profiling-controller-oracle/src/test/java/com/datadog/profiling/controller/oracle/JfrMBeanHelperTest.java

@@ -1,6 +1,12 @@
 package com.datadog.profiling.controller.oracle;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import com.datadog.profiling.controller.jfr.JfpUtils;
 import java.io.IOException;

dd-java-agent/appsec/build.gradle

@@ -20,7 +20,6 @@ dependencies {
   testImplementation libs.bytebuddy
   testImplementation project(':remote-config:remote-config-core')
   testImplementation project(':utils:test-utils')
-  testImplementation group: 'org.hamcrest', name: 'hamcrest', version: '2.2'
   testImplementation group: 'com.flipkart.zjsonpatch', name: 'zjsonpatch', version: '0.4.11'
   testImplementation libs.logback.classic
   testImplementation libs.jackson.databind

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/ddwaf/WAFModuleSpecification.groovy

@@ -55,7 +55,6 @@ import java.util.concurrent.atomic.AtomicLong
 
 import static datadog.trace.api.config.AppSecConfig.APPSEC_OBFUSCATION_PARAMETER_KEY_REGEXP
 import static datadog.trace.api.config.AppSecConfig.APPSEC_OBFUSCATION_PARAMETER_VALUE_REGEXP
-import static org.hamcrest.Matchers.hasSize
 
 class WAFModuleSpecification extends DDSpecification {
   @Shared
@@ -508,7 +507,7 @@ class WAFModuleSpecification extends DDSpecification {
     then:
     1 * ctx.getOrCreateWafContext(_, true, false)
     2 * tracer.activeSpan()
-    1 * ctx.reportEvents(hasSize(1))
+    1 * ctx.reportEvents({ it.size() == 1 })
     2 * ctx.getWafMetrics()
     1 * ctx.isWafContextClosed() >> false
     1 * ctx.closeWafContext()