Skip to content

Commit d2a91cc

Browse files
committed
move shared sql commenter to bootstrap package
1 parent 5476cd6 commit d2a91cc

File tree

10 files changed

+13
-12
lines changed

10 files changed

+13
-12
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ dd-java-agent/agent-llmobs/ @DataDog/ml-observability
137137
dd-trace-core/src/main/java/datadog/trace/llmobs/ @DataDog/ml-observability
138138
dd-trace-core/src/test/groovy/datadog/trace/llmobs/ @DataDog/ml-observability
139139

140+
# @DataDog/database-monitoring
141+
datadog/trace/bootstrap/instrumentation/dbm @DataDog/database-monitoring @DataDog/apm-idm-java
142+
140143
# @DataDog/rum
141144
/internal-api/src/main/java/datadog/trace/api/rum/ @DataDog/rum
142145
/internal-api/src/test/groovy/datadog/trace/api/rum/ @DataDog/rum

dd-trace-core/src/main/java/datadog/trace/core/database/SharedDBCommenter.java renamed to dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/dbm/SharedDBCommenter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package datadog.trace.core.database;
1+
package datadog.trace.bootstrap.instrumentation.dbm;
22

33
import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeSpan;
44

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/DBMCompatibleConnectionInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public String[] helperClassNames() {
8080
return new String[] {
8181
packageName + ".JDBCDecorator",
8282
packageName + ".SQLCommenter",
83-
"datadog.trace.core.database.SharedDBCommenter",
83+
"datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter",
8484
};
8585
}
8686

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
package datadog.trace.instrumentation.jdbc;
22

3-
import datadog.trace.core.database.SharedDBCommenter;
4-
import org.slf4j.Logger;
5-
import org.slf4j.LoggerFactory;
3+
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter;
64

75
public class SQLCommenter {
8-
private static final Logger log = LoggerFactory.getLogger(SQLCommenter.class);
96
// SQL-specific constants, rest defined in SharedDBCommenter
107
private static final char SPACE = ' ';
118
private static final String OPEN_COMMENT = "/*";

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/StatementInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public String[] helperClassNames() {
6161
return new String[] {
6262
packageName + ".JDBCDecorator",
6363
packageName + ".SQLCommenter",
64-
"datadog.trace.core.database.SharedDBCommenter",
64+
"datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter",
6565
};
6666
}
6767

dd-java-agent/instrumentation/mongo/common/src/main/java/datadog/trace/instrumentation/mongo/MongoCommentInjector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import datadog.trace.api.Config;
77
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
8-
import datadog.trace.core.database.SharedDBCommenter;
8+
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter;
99
import org.bson.BsonArray;
1010
import org.bson.BsonDocument;
1111
import org.bson.BsonString;

dd-java-agent/instrumentation/mongo/driver-3.1/src/main/java/datadog/trace/instrumentation/mongo/DefaultServerConnection31Instrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import datadog.trace.agent.tooling.Instrumenter;
1414
import datadog.trace.agent.tooling.InstrumenterModule;
1515
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
16-
import datadog.trace.core.database.SharedDBCommenter;
16+
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter;
1717
import net.bytebuddy.asm.Advice;
1818
import org.bson.BsonDocument;
1919

dd-java-agent/instrumentation/mongo/driver-4.0/src/main/java/datadog/trace/instrumentation/mongo/DefaultServerConnection40Instrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import datadog.trace.agent.tooling.Instrumenter;
1414
import datadog.trace.agent.tooling.InstrumenterModule;
1515
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
16-
import datadog.trace.core.database.SharedDBCommenter;
16+
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter;
1717
import net.bytebuddy.asm.Advice;
1818
import org.bson.BsonDocument;
1919

dd-java-agent/instrumentation/mongo/driver-4.0/src/test/groovy/MongoDBMCommentTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.core.database.SharedDBCommenter
1+
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter
22
import spock.lang.Specification
33

44
class MongoDBMCommentTest extends Specification {

dd-trace-core/src/test/groovy/datadog/trace/core/database/SharedDBCommenterTest.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package datadog.trace.core.database
22

3+
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter
34
import spock.lang.Specification
45

56
class SharedDBCommenterTest extends Specification {
@@ -139,4 +140,4 @@ class SharedDBCommenterTest extends Specification {
139140
assert part.contains("'")
140141
}
141142
}
142-
}
143+
}

0 commit comments

Comments
 (0)