Skip to content

Commit d41e3a6

Browse files
committed
Realign implementation with candidate upstream
1 parent ec3cca6 commit d41e3a6

14 files changed

+1459
-729
lines changed

utils/queue-utils/build.gradle.kts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,20 @@
1-
import de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis
21
import groovy.lang.Closure
32
import org.gradle.kotlin.dsl.extra
43

54
plugins {
65
`java-library`
76
id("me.champeau.jmh")
7+
id("dd-trace-java.test-jvm-contraints")
88
idea
99
}
1010

11-
val minJavaVersionForTests by extra(JavaVersion.VERSION_11)
12-
1311
apply(from = "$rootDir/gradle/java.gradle")
1412

1513
java {
1614
toolchain {
1715
languageVersion = JavaLanguageVersion.of(11)
1816
}
1917
}
20-
/*
21-
tasks.named<CheckForbiddenApis>("forbiddenApisMain_java11") {
22-
failOnMissingClasses = false
23-
}
24-
*/
25-
tasks.withType<Javadoc>().configureEach {
26-
javadocTool = javaToolchains.javadocToolFor(java.toolchain)
27-
}
2818

2919
fun AbstractCompile.configureCompiler(javaVersionInteger: Int, compatibilityVersion: JavaVersion? = null, unsetReleaseFlagReason: String? = null) {
3020
(project.extra["configureCompiler"] as Closure<*>).call(this, javaVersionInteger, compatibilityVersion, unsetReleaseFlagReason)
@@ -40,10 +30,14 @@ dependencies {
4030
api(project(":internal-api"))
4131
api(libs.jctools)
4232

43-
testImplementation(project(":dd-java-agent:testing"))
33+
testImplementation(libs.junit)
4434
testImplementation(libs.slf4j)
4535
}
4636

37+
testJvmConstraints {
38+
minJavaVersion = JavaVersion.VERSION_11
39+
}
40+
4741
idea {
4842
module {
4943
jdkName = "11"

utils/queue-utils/src/jmh/java/datadog/common/queue/JctoolsMPSCBlockingConsumerQueueBenchmark.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package datadog.common.queue;
22

3-
import java.util.concurrent.CountDownLatch;
43
import java.util.concurrent.TimeUnit;
54
import org.jctools.queues.MpscBlockingConsumerArrayQueue;
65
import org.openjdk.jmh.annotations.Benchmark;
@@ -29,8 +28,8 @@
2928
JctoolsMPSCBlockingConsumerQueueBenchmark.queueTest:produce 65536 thrpt 7,733 ops/us
3029
*/
3130
@BenchmarkMode(Mode.Throughput)
32-
@Warmup(iterations = 1, time = 30)
33-
@Measurement(iterations = 1, time = 30)
31+
@Warmup(iterations = 3, time = 10)
32+
@Measurement(iterations = 3, time = 10)
3433
@Fork(1)
3534
@OutputTimeUnit(TimeUnit.MICROSECONDS)
3635
@State(Scope.Benchmark)

utils/queue-utils/src/jmh/java/datadog/common/queue/JctoolsMPSCQueueBenchmark.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
JctoolsMPSCQueueBenchmark.queueTest:produce 65536 thrpt 7,219 ops/us
2929
*/
3030
@BenchmarkMode(Mode.Throughput)
31-
@Warmup(iterations = 1, time = 30)
32-
@Measurement(iterations = 1, time = 30)
31+
@Warmup(iterations = 3, time = 10)
32+
@Measurement(iterations = 3, time = 10)
3333
@Fork(1)
3434
@OutputTimeUnit(TimeUnit.MICROSECONDS)
3535
@State(Scope.Benchmark)

utils/queue-utils/src/jmh/java/datadog/common/queue/JctoolsSPSCQueueBenchmark.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
*/
3030
@BenchmarkMode(Mode.Throughput)
3131
@Warmup(iterations = 3, time = 10)
32-
@Measurement(iterations = 1, time = 30)
32+
@Measurement(iterations = 3, time = 10)
3333
@Fork(1)
3434
@OutputTimeUnit(TimeUnit.MICROSECONDS)
3535
@State(Scope.Benchmark)

utils/queue-utils/src/jmh/java/datadog/common/queue/MPSCBlockingConsumerQueueBenchmark.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package datadog.common.queue;
22

3-
import java.util.concurrent.CountDownLatch;
43
import java.util.concurrent.TimeUnit;
54
import org.openjdk.jmh.annotations.Benchmark;
65
import org.openjdk.jmh.annotations.BenchmarkMode;
@@ -28,8 +27,8 @@
2827
MPSCBlockingConsumerQueueBenchmark.queueTest:produce 65536 thrpt 7,485 ops/us
2928
*/
3029
@BenchmarkMode(Mode.Throughput)
31-
@Warmup(iterations = 1, time = 30)
32-
@Measurement(iterations = 1, time = 30)
30+
@Warmup(iterations = 3, time = 10)
31+
@Measurement(iterations = 3, time = 10)
3332
@Fork(1)
3433
@OutputTimeUnit(TimeUnit.MICROSECONDS)
3534
@State(Scope.Benchmark)

utils/queue-utils/src/jmh/java/datadog/common/queue/MPSCQueueBenchmark.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
MPSCQueueBenchmark.queueTest:produce 65536 thrpt 12,102 ops/us
2828
*/
2929
@BenchmarkMode(Mode.Throughput)
30-
@Warmup(iterations = 1, time = 30)
31-
@Measurement(iterations = 1, time = 30)
30+
@Warmup(iterations = 3, time = 10)
31+
@Measurement(iterations = 3, time = 10)
3232
@Fork(1)
3333
@OutputTimeUnit(TimeUnit.MICROSECONDS)
3434
@State(Scope.Benchmark)

utils/queue-utils/src/jmh/java/datadog/common/queue/SPSCQueueBenchmark.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*/
2929
@BenchmarkMode(Mode.Throughput)
3030
@Warmup(iterations = 3, time = 10)
31-
@Measurement(iterations = 1, time = 30)
31+
@Measurement(iterations = 3, time = 10)
3232
@Fork(1)
3333
@OutputTimeUnit(TimeUnit.MICROSECONDS)
3434
@State(Scope.Benchmark)

0 commit comments

Comments
 (0)