Skip to content

Commit d6d6049

Browse files
committed
chore(ot): Remove custom scope manager support
1 parent 54d4a6f commit d6d6049

File tree

9 files changed

+53
-860
lines changed

9 files changed

+53
-860
lines changed

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,6 @@ public CoreTracer build() {
497497
singleSpanSampler,
498498
injector,
499499
extractor,
500-
scopeManager,
501500
localRootSpanTags,
502501
defaultSpanTags,
503502
serviceNameMappings,
@@ -529,7 +528,6 @@ private CoreTracer(
529528
final SingleSpanSampler singleSpanSampler,
530529
final HttpCodec.Injector injector,
531530
final HttpCodec.Extractor extractor,
532-
final AgentScopeManager scopeManager,
533531
final Map<String, ?> localRootSpanTags,
534532
final Map<String, ?> defaultSpanTags,
535533
final Map<String, String> serviceNameMappings,
@@ -632,16 +630,13 @@ private CoreTracer(
632630
: Monitoring.DISABLED;
633631

634632
traceWriteTimer = performanceMonitoring.newThreadLocalTimer("trace.write");
635-
if (scopeManager == null) {
636-
this.scopeManager =
637-
new ContinuableScopeManager(
638-
config.getScopeDepthLimit(),
639-
config.isScopeStrictMode(),
640-
profilingContextIntegration,
641-
healthMetrics);
642-
} else {
643-
this.scopeManager = scopeManager;
644-
}
633+
634+
scopeManager =
635+
new ContinuableScopeManager(
636+
config.getScopeDepthLimit(),
637+
config.isScopeStrictMode(),
638+
profilingContextIntegration,
639+
healthMetrics);
645640

646641
externalAgentLauncher = new ExternalAgentLauncher(config);
647642

dd-trace-ot/src/main/java/datadog/opentracing/CustomScopeManagerWrapper.java

Lines changed: 0 additions & 268 deletions
This file was deleted.

dd-trace-ot/src/main/java/datadog/opentracing/DDTracer.java

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ public static class DDTracerBuilder {
8484
private Sampler sampler;
8585
private HttpCodec.Injector injector;
8686
private HttpCodec.Extractor extractor;
87-
private ScopeManager scopeManager;
8887
private Map<String, String> localRootSpanTags;
8988
private Map<String, String> defaultSpanTags;
9089
private Map<String, String> serviceNameMappings;
@@ -125,9 +124,7 @@ public DDTracerBuilder extractor(HttpCodec.Extractor extractor) {
125124

126125
@Deprecated
127126
public DDTracerBuilder scopeManager(ScopeManager scopeManager) {
128-
log.warn(
129-
"Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot");
130-
this.scopeManager = scopeManager;
127+
log.warn("Custom ScopeManagers are not supported");
131128
return this;
132129
}
133130

@@ -178,7 +175,6 @@ public DDTracer build() {
178175
sampler,
179176
injector,
180177
extractor,
181-
scopeManager,
182178
localRootSpanTags,
183179
defaultSpanTags,
184180
serviceNameMappings,
@@ -323,7 +319,6 @@ private DDTracer(
323319
final Sampler sampler,
324320
final HttpCodec.Injector injector,
325321
final HttpCodec.Extractor extractor,
326-
final ScopeManager scopeManager,
327322
final Map<String, String> localRootSpanTags,
328323
final Map<String, String> defaultSpanTags,
329324
final Map<String, String> serviceNameMappings,
@@ -376,11 +371,6 @@ private DDTracer(
376371
builder = builder.extractor(extractor);
377372
}
378373

379-
if (scopeManager != null) {
380-
this.scopeManager = scopeManager;
381-
builder = builder.scopeManager(new CustomScopeManagerWrapper(scopeManager, converter));
382-
}
383-
384374
if (localRootSpanTags != null) {
385375
builder = builder.localRootSpanTags(localRootSpanTags);
386376
}
@@ -410,9 +400,7 @@ private DDTracer(
410400
// FIXME [API] There's an unfortunate cycle between OTScopeManager and CoreTracer where they
411401
// depend on each other so CoreTracer
412402
// Perhaps api can change so that CoreTracer doesn't need to implement scope methods directly
413-
if (scopeManager == null) {
414-
this.scopeManager = new OTScopeManager(tracer, converter);
415-
}
403+
this.scopeManager = new OTScopeManager(tracer, converter);
416404

417405
if ((config != null && config.isLogsInjectionEnabled())
418406
|| (config == null && Config.get().isLogsInjectionEnabled())) {

0 commit comments

Comments
 (0)