Avoid expensive Class.getMethod call in code-origin advice

Author: mcculls

dd-java-agent/agent-debugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/DebuggerContext.java

@@ -3,7 +3,6 @@
 import datadog.trace.api.Config;
 import datadog.trace.bootstrap.debugger.util.TimeoutChecker;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
-import java.lang.reflect.Method;
 import java.time.Duration;
 import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
@@ -100,7 +99,7 @@ public interface ExceptionDebugger {
   public interface CodeOriginRecorder {
     String captureCodeOrigin(boolean entry);
 
-    String captureCodeOrigin(Method method, boolean entry);
+    String captureCodeOrigin(String methodToString, boolean entry);
   }
 
   private static volatile ProbeResolver probeResolver;
@@ -506,11 +505,11 @@ public static void captureCodeOrigin(boolean entry) {
     }
   }
 
-  public static void captureCodeOrigin(Method method, boolean entry) {
+  public static void captureCodeOrigin(String methodToString, boolean entry) {
     try {
       CodeOriginRecorder recorder = codeOriginRecorder;
       if (recorder != null) {
-        recorder.captureCodeOrigin(method, entry);
+        recorder.captureCodeOrigin(methodToString, entry);
       }
     } catch (Exception ex) {
       LOGGER.debug("Error in captureCodeOrigin: ", ex);

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/codeorigin/DefaultCodeOriginRecorder.java

@@ -20,7 +20,6 @@
 import datadog.trace.bootstrap.instrumentation.api.AgentTracer;
 import datadog.trace.util.AgentTaskScheduler;
 import datadog.trace.util.stacktrace.StackWalkerFactory;
-import java.lang.reflect.Method;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -82,12 +81,11 @@ public String captureCodeOrigin(boolean entry) {
   }
 
   @Override
-  public String captureCodeOrigin(Method method, boolean entry) {
-    String fingerprint = method.toString();
-    CodeOriginProbe probe = probesByFingerprint.get(fingerprint);
+  public String captureCodeOrigin(String methodToString, boolean entry) {
+    CodeOriginProbe probe = probesByFingerprint.get(methodToString);
     if (probe == null) {
-      probe = createProbe(fingerprint, entry, Where.of(method));
-      LOG.debug("Creating probe for method {}", fingerprint);
+      probe = createProbe(methodToString, entry, Where.of(methodToString));
+      LOG.debug("Creating probe for method {}", methodToString);
     }
     return probe.getId();
   }

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/probe/Where.java

@@ -1,22 +1,18 @@
 package com.datadog.debugger.probe;
 
-import static java.util.Arrays.stream;
-
 import com.datadog.debugger.agent.Generated;
 import com.datadog.debugger.instrumentation.Types;
 import com.datadog.debugger.util.ClassFileLines;
 import com.squareup.moshi.JsonAdapter;
 import com.squareup.moshi.JsonReader;
 import com.squareup.moshi.JsonWriter;
 import java.io.IOException;
-import java.lang.reflect.Method;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Objects;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
-import java.util.stream.Collectors;
 import org.objectweb.asm.Opcodes;
 import org.objectweb.asm.tree.MethodNode;
 
@@ -50,13 +46,16 @@ public static Where of(String typeName, String methodName, String signature, Str
     return new Where(typeName, methodName, signature, lines, null);
   }
 
-  public static Where of(Method method) {
-    return of(
-        method.getDeclaringClass().getName(),
-        method.getName(),
-        stream(method.getParameterTypes())
-            .map(Class::getTypeName)
-            .collect(Collectors.joining(", ", "(", ")")));
+  public static Where of(String methodToString) {
+    int signatureStart = methodToString.indexOf('(');
+    int methodNameStart = methodToString.lastIndexOf('.', signatureStart) + 1;
+    int declaringTypeStart = methodToString.lastIndexOf(' ', methodNameStart) + 1;
+    return new Where(
+        methodToString.substring(declaringTypeStart, methodNameStart - 1),
+        methodToString.substring(methodNameStart, signatureStart),
+        methodToString.substring(signatureStart),
+        (SourceLine[]) null,
+        null);
   }
 
   protected static SourceLine[] sourceLines(String[] defs) {

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/origin/CodeOriginTest.java

@@ -133,8 +133,8 @@ public void withDebug1() throws Exception {
     final String className = "com.datadog.debugger.CodeOrigin02";
     installProbes();
     final Class<?> testClass = compileAndLoadClass(className);
-    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("entry"), true);
-    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("exit"), false);
+    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("entry").toString(), true);
+    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("exit").toString(), false);
     checkResults(testClass, "fullTrace", 0);
     checkResults(testClass, "debug_1", 2);
   }
@@ -145,8 +145,8 @@ public void withLogProbe() throws Exception {
     installProbes(
         createProbeBuilder(PROBE_ID, CLASS_NAME, "entry", "()").captureSnapshot(true).build());
     final Class<?> testClass = compileAndLoadClass(CLASS_NAME);
-    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("entry"), true);
-    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("exit"), false);
+    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("entry").toString(), true);
+    codeOriginRecorder.captureCodeOrigin(testClass.getMethod("exit").toString(), false);
     checkResults(testClass, "debug_1", 3);
   }
 
@@ -230,7 +230,8 @@ public void testCaptureCodeOriginWithExplicitInfo()
     installProbes();
     CodeOriginProbe probe =
         codeOriginRecorder.getProbe(
-            codeOriginRecorder.captureCodeOrigin(testClass.getMethod("main", int.class), true));
+            codeOriginRecorder.captureCodeOrigin(
+                testClass.getMethod("main", int.class).toString(), true));
     assertNotNull(probe, "The probe should have been created.");
     assertTrue(probe.entrySpanProbe(), "Should be an entry probe.");
   }
@@ -242,9 +243,11 @@ public void testDuplicateInstrumentations()
     final Class<?> testClass = compileAndLoadClass(CLASS_NAME);
     installProbes();
     String probe1 =
-        codeOriginRecorder.captureCodeOrigin(testClass.getMethod("main", int.class), true);
+        codeOriginRecorder.captureCodeOrigin(
+            testClass.getMethod("main", int.class).toString(), true);
     String probe2 =
-        codeOriginRecorder.captureCodeOrigin(testClass.getMethod("main", int.class), true);
+        codeOriginRecorder.captureCodeOrigin(
+            testClass.getMethod("main", int.class).toString(), true);
     assertEquals(probe1, probe2);
   }
 

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/origin/CodeOriginTestAdvice.java

@@ -12,6 +12,6 @@ public class CodeOriginTestAdvice {
   @SuppressWarnings("bytebuddy-exception-suppression")
   public static void onEnter(@Advice.Origin final Method method) {
     marker();
-    captureCodeOrigin(method, true);
+    captureCodeOrigin(method.toString(), true);
   }
 }

dd-java-agent/agent-debugger/src/test/resources/com/datadog/debugger/CodeOrigin01.java

@@ -20,7 +20,7 @@ public static int main(String arg) throws ReflectiveOperationException {
     AgentSpan span = newSpan("main");
     AgentScope scope = tracerAPI.activateManualSpan(span);
     marker();
-    captureCodeOrigin(CodeOrigin01.class.getDeclaredMethod("main", String.class), true);
+    captureCodeOrigin(CodeOrigin01.class.getDeclaredMethod("main", String.class).toString(), true);
     if (arg.equals("debug_1")) {
       ((DDSpan) span.getLocalRootSpan()).setTag("_dd.p.debug", "1");
     } else if (arg.equals("debug_0")) {

dd-java-agent/instrumentation/grpc-1.5/src/main/java/datadog/trace/instrumentation/grpc/server/MethodHandlersInstrumentation.java

@@ -71,7 +71,9 @@ public static void onEnter(@Advice.Argument(0) Object serviceImpl) {
             try {
               marker();
               captureCodeOrigin(
-                  serviceClass.getDeclaredMethod(method.getName(), method.getParameterTypes()),
+                  serviceClass
+                      .getDeclaredMethod(method.getName(), method.getParameterTypes())
+                      .toString(),
                   true);
             } catch (Throwable e) {
               // service method not overridden on the impl.  skipping instrumentation.

dd-java-agent/instrumentation/micronaut/http-server-netty-4.0/src/test/groovy/MicronautTest.groovy

@@ -8,8 +8,6 @@ import datadog.trace.instrumentation.micronaut.v4_0.MicronautDecorator
 import datadog.trace.instrumentation.netty41.server.NettyHttpServerDecorator
 import test.MicronautServer
 
-import java.lang.reflect.Method
-
 import static datadog.trace.agent.test.base.HttpServerTest.ServerEndpoint.ERROR
 import static datadog.trace.agent.test.base.HttpServerTest.ServerEndpoint.EXCEPTION
 import static datadog.trace.agent.test.base.HttpServerTest.ServerEndpoint.NOT_FOUND
@@ -35,7 +33,7 @@ class MicronautTest extends HttpServerTest<Object> {
         }
 
         @Override
-        String captureCodeOrigin(Method method, boolean entry) {
+        String captureCodeOrigin(String methodToString, boolean entry) {
           invoked = true
           return "done"
         }

dd-java-agent/instrumentation/span-origin/src/main/java/datadog/trace/instrumentation/codeorigin/EntrySpanOriginAdvice.java

@@ -3,15 +3,14 @@
 import static datadog.trace.bootstrap.debugger.DebuggerContext.captureCodeOrigin;
 import static datadog.trace.bootstrap.debugger.DebuggerContext.marker;
 
-import java.lang.reflect.Method;
 import net.bytebuddy.asm.Advice;
 
 public class EntrySpanOriginAdvice {
 
   @Advice.OnMethodEnter
   @SuppressWarnings("bytebuddy-exception-suppression")
-  public static void onEnter(@Advice.Origin final Method method) {
+  public static void onEnter(@Advice.Origin final String methodToString) {
     marker();
-    captureCodeOrigin(method, true);
+    captureCodeOrigin(methodToString, true);
   }
 }

dd-java-agent/instrumentation/trace-annotation/src/main/java/datadog/trace/instrumentation/trace_annotation/TraceAdvice.java

@@ -17,7 +17,7 @@ public class TraceAdvice {
   public static AgentScope onEnter(@Advice.Origin final Method method) {
     AgentScope agentScope = activateSpan(DECORATE.startMethodSpan(method));
     marker();
-    captureCodeOrigin(method, true);
+    captureCodeOrigin(method.toString(), true);
     return agentScope;
   }