responding to PR comments

Author: mhlidd

dd-java-agent/src/main/java6/datadog/trace/bootstrap/AgentPreCheck.java

@@ -90,6 +90,10 @@ private static boolean compatible() {
   }
 
   // Reachable for testing
+  // System.getenv usage is necessary since class is designed to be Java 6 compatible, while
+  // Environment component is for Java 8+
+  // System.getenv usage is necessary since class is designed to be Java 6 compatible, while
+  // Environment component is for Java 8+
   @SuppressForbidden
   static boolean compatible(String javaVersion, String javaHome, PrintStream output) {
     int majorJavaVersion = parseJavaMajorVersion(javaVersion);

utils/config-utils/src/main/java/datadog/trace/api/telemetry/ConfigInversionMetricCollectorProvider.java

@@ -12,7 +12,7 @@ private ConfigInversionMetricCollectorProvider() {}
 
   public static ConfigInversionMetricCollector get() {
     if (INSTANCE == null) {
-      log.error(
+      log.debug(
           "ConfigInversionMetricCollector has not been registered. Defaulting to NoOp implementation.");
       // Return NoOp implementation for build tasks like instrumentJava that run before
       // implementation is registered

utils/config-utils/src/main/java/datadog/trace/config/inversion/ConfigHelper.java

@@ -85,7 +85,7 @@ public static String env(String key) {
     return get().getEnvironmentVariable(key);
   }
 
-  private Map<String, String> getEnvironmentVariables() {
+  public Map<String, String> getEnvironmentVariables() {
     if (configs != null) {
       return configs;
     }
@@ -129,7 +129,7 @@ private Map<String, String> getEnvironmentVariables() {
     return configs;
   }
 
-  private String getEnvironmentVariable(String name) {
+  public String getEnvironmentVariable(String name) {
     if (configs != null && configs.containsKey(name)) {
       return configs.get(name);
     }