Skip to content

Commit e037a8e

Browse files
committed
fixing config helper
1 parent e4374fb commit e037a8e

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

components/environment/src/generator/resources/supported-configurations.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1140,6 +1140,8 @@
11401140
"DD_TRACE_SPLIT_BY_TAGS": ["A"],
11411141
"DD_TRACE_SPRAY_ANALYTICS_ENABLED": ["A"],
11421142
"DD_TRACE_SPRAY_ANALYTICS_SAMPLE_RATE": ["A"],
1143+
"DD_TRACE_SPRAY_HTTP_ENABLED": ["A"],
1144+
"DD_TRACE_SPRAY_HTTP_SERVER_ENABLED": ["A"],
11431145
"DD_TRACE_SPRING_ASYNC_ENABLED": ["A"],
11441146
"DD_TRACE_SPRING_BEANS_ENABLED": ["A"],
11451147
"DD_TRACE_SPRING_BOOT_ENABLED": ["A"],
@@ -1639,6 +1641,7 @@
16391641
"DD_TRACE_PEKKO_HTTP_ENABLED": ["DD_TRACE_INTEGRATION_PEKKO_HTTP_ENABLED","DD_INTEGRATION_PEKKO_HTTP_ENABLED"],
16401642
"DD_TRACE_PEKKO_HTTP_SERVER_ANALYTICS_SAMPLE_RATE": ["DD_PEKKO_HTTP_SERVER_ANALYTICS_SAMPLE_RATE"],
16411643
"DD_TRACE_PEKKO_HTTP_SERVER_ENABLED": ["DD_TRACE_INTEGRATION_PEKKO_HTTP_SERVER_ENABLED","DD_INTEGRATION_PEKKO_HTTP_SERVER_ENABLED"],
1644+
"DD_TRACE_PEKKO_SCHEDULER_ENABLED": ["DD_TRACE_INTEGRATION_PEKKO_SCHEDULER_ENABLED","DD_INTEGRATION_PEKKO_SCHEDULER_ENABLED"],
16421645
"DD_TRACE_PLAY_ACTION_ENABLED": ["DD_TRACE_INTEGRATION_PLAY_ACTION_ENABLED","DD_INTEGRATION_PLAY_ACTION_ENABLED"],
16431646
"DD_TRACE_PLAY_ANALYTICS_SAMPLE_RATE": ["DD_PLAY_ANALYTICS_SAMPLE_RATE"],
16441647
"DD_TRACE_PLAY_ENABLED": ["DD_TRACE_INTEGRATION_PLAY_ENABLED","DD_INTEGRATION_PLAY_ENABLED"],
@@ -1733,6 +1736,8 @@
17331736
"DD_TRACE_SPARK_EXIT_ENABLED": ["DD_TRACE_INTEGRATION_SPARK_EXIT_ENABLED","DD_INTEGRATION_SPARK_EXIT_ENABLED"],
17341737
"DD_TRACE_SPARK_OPENLINEAGE_ENABLED": ["DD_TRACE_INTEGRATION_SPARK_OPENLINEAGE_ENABLED","DD_INTEGRATION_SPARK_OPENLINEAGE_ENABLED"],
17351738
"DD_TRACE_SPRAY_ANALYTICS_SAMPLE_RATE": ["DD_SPRAY_ANALYTICS_SAMPLE_RATE"],
1739+
"DD_TRACE_SPRAY_HTTP_ENABLED": ["DD_TRACE_INTEGRATION_SPRAY_HTTP_ENABLED","DD_INTEGRATION_SPRAY_HTTP_ENABLED"],
1740+
"DD_TRACE_SPRAY_HTTP_SERVER_ENABLED": ["DD_TRACE_INTEGRATION_SPRAY_HTTP_SERVER_ENABLED","DD_INTEGRATION_SPRAY_HTTP_SERVER_ENABLED"],
17361741
"DD_TRACE_SPRING_ASYNC_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_ASYNC_ENABLED","DD_INTEGRATION_SPRING_ASYNC_ENABLED"],
17371742
"DD_TRACE_SPRING_BEANS_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_BEANS_ENABLED","DD_INTEGRATION_SPRING_BEANS_ENABLED"],
17381743
"DD_TRACE_SPRING_BOOT_ENABLED": ["DD_TRACE_INTEGRATION_SPRING_BOOT_ENABLED","DD_INTEGRATION_SPRING_BOOT_ENABLED"],

components/environment/src/main/java/datadog/environment/ConfigHelper.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,8 @@ public static Map<String, String> getEnvironmentVariables() {
5757
}
5858

5959
public static String getEnvironmentVariable(String name) {
60-
if ((name.startsWith("DD_")
61-
|| name.startsWith("OTEL_")
62-
|| GeneratedSupportedConfigurations.ALIAS_MAPPING.containsKey(name))
60+
if ((name.startsWith("DD_") || name.startsWith("OTEL_"))
61+
&& !GeneratedSupportedConfigurations.ALIAS_MAPPING.containsKey(name)
6362
&& !GeneratedSupportedConfigurations.SUPPORTED.contains(name)
6463
&& configInversionStrict) {
6564
System.err.println(

components/environment/src/main/java/datadog/environment/EnvironmentVariables.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package datadog.environment;
22

3+
import de.thetaphi.forbiddenapis.SuppressForbidden;
34
import javax.annotation.Nonnull;
45
import javax.annotation.Nullable;
56

@@ -32,6 +33,7 @@ private EnvironmentVariables() {}
3233
* @return The environment variable value, {@code defaultValue} if missing, can't be retrieved or
3334
* the environment variable name is {@code null}.
3435
*/
36+
@SuppressForbidden
3537
public static String getOrDefault(@Nonnull String name, String defaultValue) {
3638
if (name == null) {
3739
return defaultValue;

gradle/jacoco.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ if (!project.ext.hasProperty('excludedClassesBranchCoverage')) {
3737
}
3838

3939
if (!project.ext.hasProperty('excludedClassesInstructionCoverage')) {
40-
project.ext.excludedClassesInstructionCoverage = []
40+
project.ext.excludedClassesInstructionCoverage = ["datadog.environment.GeneratedSupportedConfigurations"] // Generated static file
4141
}
4242

4343
// defaults can be overridden per project:

0 commit comments

Comments
 (0)