addressed comments

Signed-off-by: Nayeem Kamal <[email protected]>

Author: Nayeem Kamal

dd-java-agent/agent-llmobs/src/main/java/datadog/trace/llmobs/LLMObsSystem.java

@@ -193,15 +193,17 @@ public LLMObsSpan startWorkflowSpan(
     public LLMObsSpan startEmbeddingSpan(
         String spanName,
         @Nullable String mlApp,
-        @Nullable String mlProvider,
+        @Nullable String modelProvider,
+        @Nullable String modelName,
         @Nullable String sessionId) {
-      if (mlProvider == null) {
-        mlProvider = "custom";
+      if (modelProvider == null) {
+        modelProvider = "custom";
       }
       DDLLMObsSpan embeddingSpan =
           new DDLLMObsSpan(
               Tags.LLMOBS_EMBEDDING_SPAN_KIND, spanName, getMLApp(mlApp), sessionId, serviceName);
-      embeddingSpan.setTag(LLMObsTags.MODEL_PROVIDER, mlProvider);
+      embeddingSpan.setTag(LLMObsTags.MODEL_PROVIDER, modelProvider);
+      embeddingSpan.setTag(LLMObsTags.MODEL_NAME, modelName);
       return embeddingSpan;
     }
 

dd-trace-api/src/main/java/datadog/trace/api/llmobs/LLMObs.java

@@ -49,9 +49,10 @@ public static LLMObsSpan startWorkflowSpan(
   public LLMObsSpan startEmbeddingSpan(
       String spanName,
       @Nullable String mlApp,
-      @Nullable String mlProvider,
+      @Nullable String modelProvider,
+      @Nullable String modelName,
       @Nullable String sessionId) {
-    return SPAN_FACTORY.startEmbeddingSpan(spanName, mlApp, mlProvider, sessionId);
+    return SPAN_FACTORY.startEmbeddingSpan(spanName, mlApp, modelProvider, modelName, sessionId);
   }
 
   public LLMObsSpan startRetrievalSpan(
@@ -107,7 +108,8 @@ LLMObsSpan startWorkflowSpan(
     LLMObsSpan startEmbeddingSpan(
         String spanName,
         @Nullable String mlApp,
-        @Nullable String mlProvider,
+        @Nullable String modelProvider,
+        @Nullable String modelName,
         @Nullable String sessionId);
 
     LLMObsSpan startRetrievalSpan(

dd-trace-api/src/main/java/datadog/trace/api/llmobs/noop/NoOpLLMObsSpanFactory.java

@@ -39,7 +39,8 @@ public LLMObsSpan startWorkflowSpan(
   public LLMObsSpan startEmbeddingSpan(
       String spanName,
       @Nullable String mlApp,
-      @Nullable String mlProvider,
+      @Nullable String modelProvider,
+      @Nullable String modelName,
       @Nullable String sessionId) {
     return NoOpLLMObsSpan.INSTANCE;
   }