Method includeShadowJar was breaking shadowJar tasks laziness (#9626)

Author: bric3

dd-java-agent/agent-ci-visibility/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 buildscript {
   repositories {
     mavenLocal()
@@ -57,7 +59,7 @@ dependencies {
   testImplementation group: 'org.msgpack', name: 'jackson-dataformat-msgpack', version: '0.9.6'
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 }
 

dd-java-agent/agent-debugger/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 plugins {
   id 'com.gradleup.shadow'
 }
@@ -62,7 +64,7 @@ dependencies {
   testRuntimeOnly group: 'antlr', name: 'antlr', version: '2.7.7'
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
   dependencies {
     exclude(project(':dd-java-agent:agent-debugger:debugger-bootstrap'))

dd-java-agent/agent-iast/build.gradle

@@ -1,3 +1,4 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 import net.ltgt.gradle.errorprone.CheckSeverity
 
 plugins {
@@ -74,7 +75,7 @@ dependencies {
   errorprone('com.google.errorprone:error_prone_core:2.23.0')
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 }
 

dd-java-agent/agent-jmxfetch/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 import java.nio.file.Files
 import java.nio.file.attribute.BasicFileAttributes
 import java.util.stream.Collectors
@@ -23,7 +25,7 @@ dependencies {
   api project(':dd-java-agent:agent-bootstrap')
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 }
 

dd-java-agent/agent-llmobs/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 buildscript {
   repositories {
     mavenCentral()
@@ -30,7 +32,7 @@ dependencies {
   testImplementation project(':dd-java-agent:testing')
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 }
 

dd-java-agent/agent-logs-intake/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 plugins {
   id 'com.gradleup.shadow'
 }
@@ -15,7 +17,7 @@ dependencies {
   implementation project(':communication')
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 }
 

dd-java-agent/agent-otel/otel-bootstrap/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 plugins {
   id 'com.gradleup.shadow'
 }
@@ -65,7 +67,7 @@ tasks.named('compileJava') {
   dependsOn 'unpackJars'
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 
   include '*.jar'

dd-java-agent/agent-profiling/build.gradle

@@ -1,3 +1,5 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
+
 plugins {
   id 'com.gradleup.shadow'
 }
@@ -38,7 +40,7 @@ configurations {
   }
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   dependencies deps.excludeShared
 }
 

dd-java-agent/appsec/build.gradle

@@ -1,3 +1,4 @@
+import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
 import groovy.json.JsonOutput
 import groovy.json.JsonSlurper
 
@@ -25,7 +26,7 @@ dependencies {
   testImplementation libs.jackson.databind
 }
 
-shadowJar {
+tasks.named("shadowJar", ShadowJar) {
   exclude '**/*-dbgsym.zip'
   dependencies deps.excludeShared
 }

dd-java-agent/build.gradle

@@ -46,73 +46,75 @@ dependencies {
  * This general config is shared by all of them
  */
 
-ext.generalShadowJarConfig = {
-  mergeServiceFiles()
-
-  duplicatesStrategy = DuplicatesStrategy.FAIL
-
-  // Include AgentPreCheck compiled with Java 6.
-  from sourceSets.main_java6.output
-
-  // Remove some cruft from the final jar.
-  // These patterns should NOT include **/META-INF/maven/**/pom.properties, which is
-  // used to report our own dependencies, but we should remove the top-level metadata
-  // of vendored packages because those could trigger unwanted framework checks.
-  exclude '/META-INF/maven/org.slf4j/**'
-  exclude '/META-INF/maven/org.snakeyaml/**'
-  exclude '**/META-INF/maven/**/pom.xml'
-  exclude '**/META-INF/proguard/'
-  exclude '**/META-INF/*.kotlin_module'
-  exclude '**/module-info.class'
-  exclude '**/liblz4-java.so'
-  exclude '**/liblz4-java.dylib'
-  exclude '**/inst/META-INF/versions/**'
-  exclude '**/META-INF/versions/*/org/yaml/**'
-
-  // Replaced by 'instrumenter.index', no need to include original service file
-  exclude '**/META-INF/services/datadog.trace.agent.tooling.InstrumenterModule'
-
-  // Prevents conflict with other SLF4J instances. Important for premain.
-  relocate 'org.slf4j', 'datadog.slf4j'
-  // Prevent conflicts with flat class-path when using GraalVM native-images
-  relocate 'org.jctools', 'datadog.jctools'
-  relocate 'net.jpountz', 'datadog.jpountz'
-  // rewrite dependencies calling Logger.getLogger
-  relocate 'java.util.logging.Logger', 'datadog.trace.bootstrap.PatchLogger'
-  // patch JFFI loading mechanism to maintain isolation
-  exclude '**/com/kenai/jffi/Init.class'
-  relocate('com.kenai.jffi.Init', 'com.kenai.jffi.PatchInit')
-
-  // Minimize and relocate the airlift compressor dependency for ZSTD
-  exclude '**/io/airlift/compress/bzip2/**'
-  exclude '**/io/airlift/compress/deflate/**'
-  exclude '**/io/airlift/compress/gzip/**'
-  exclude '**/io/airlift/compress/hadoop/**'
-  exclude '**/io/airlift/compress/lz4/**'
-  exclude '**/io/airlift/compress/lzo/**'
-  exclude '**/io/airlift/compress/snappy/**'
-  relocate 'io.airlift', 'datadog.io.airlift'
-
-  final String projectName = "${project.name}"
-
-  // Prevents conflict with other instances, but doesn't relocate instrumentation
-  if (!projectName.equals('instrumentation')) {
-    relocate 'org.snakeyaml.engine', 'datadog.snakeyaml.engine'
-    relocate 'okhttp3', 'datadog.okhttp3'
-    relocate 'okio', 'datadog.okio'
-  }
+def generalShadowJarConfig(ShadowJar shadowJarTask) {
+  shadowJarTask.with {
+    mergeServiceFiles()
+
+    duplicatesStrategy = DuplicatesStrategy.FAIL
+
+    // Include AgentPreCheck compiled with Java 6.
+    from sourceSets.main_java6.output
+
+    // Remove some cruft from the final jar.
+    // These patterns should NOT include **/META-INF/maven/**/pom.properties, which is
+    // used to report our own dependencies, but we should remove the top-level metadata
+    // of vendored packages because those could trigger unwanted framework checks.
+    exclude '/META-INF/maven/org.slf4j/**'
+    exclude '/META-INF/maven/org.snakeyaml/**'
+    exclude '**/META-INF/maven/**/pom.xml'
+    exclude '**/META-INF/proguard/'
+    exclude '**/META-INF/*.kotlin_module'
+    exclude '**/module-info.class'
+    exclude '**/liblz4-java.so'
+    exclude '**/liblz4-java.dylib'
+    exclude '**/inst/META-INF/versions/**'
+    exclude '**/META-INF/versions/*/org/yaml/**'
+
+    // Replaced by 'instrumenter.index', no need to include original service file
+    exclude '**/META-INF/services/datadog.trace.agent.tooling.InstrumenterModule'
+
+    // Prevents conflict with other SLF4J instances. Important for premain.
+    relocate 'org.slf4j', 'datadog.slf4j'
+    // Prevent conflicts with flat class-path when using GraalVM native-images
+    relocate 'org.jctools', 'datadog.jctools'
+    relocate 'net.jpountz', 'datadog.jpountz'
+    // rewrite dependencies calling Logger.getLogger
+    relocate 'java.util.logging.Logger', 'datadog.trace.bootstrap.PatchLogger'
+    // patch JFFI loading mechanism to maintain isolation
+    exclude '**/com/kenai/jffi/Init.class'
+    relocate('com.kenai.jffi.Init', 'com.kenai.jffi.PatchInit')
+
+    // Minimize and relocate the airlift compressor dependency for ZSTD
+    exclude '**/io/airlift/compress/bzip2/**'
+    exclude '**/io/airlift/compress/deflate/**'
+    exclude '**/io/airlift/compress/gzip/**'
+    exclude '**/io/airlift/compress/hadoop/**'
+    exclude '**/io/airlift/compress/lz4/**'
+    exclude '**/io/airlift/compress/lzo/**'
+    exclude '**/io/airlift/compress/snappy/**'
+    relocate 'io.airlift', 'datadog.io.airlift'
+
+    final String projectName = "${project.name}"
+
+    // Prevents conflict with other instances, but doesn't relocate instrumentation
+    if (!projectName.equals('instrumentation')) {
+      relocate 'org.snakeyaml.engine', 'datadog.snakeyaml.engine'
+      relocate 'okhttp3', 'datadog.okhttp3'
+      relocate 'okio', 'datadog.okio'
+    }
 
-  if (!project.hasProperty("disableShadowRelocate") || !disableShadowRelocate) {
-    // shadow OT impl to prevent casts to implementation
-    relocate 'datadog.trace.common', 'datadog.trace.agent.common'
-    relocate 'datadog.trace.core', 'datadog.trace.agent.core'
-    relocate 'datadog.opentracing', 'datadog.trace.agent.ot'
-    // shadow things in internal API that has slf4j in the API and is accessed from core
-    relocate 'datadog.trace.relocate', 'datadog.trace.agent.relocate'
+    if (!project.hasProperty("disableShadowRelocate") || !disableShadowRelocate) {
+      // shadow OT impl to prevent casts to implementation
+      relocate 'datadog.trace.common', 'datadog.trace.agent.common'
+      relocate 'datadog.trace.core', 'datadog.trace.agent.core'
+      relocate 'datadog.opentracing', 'datadog.trace.agent.ot'
+      // shadow things in internal API that has slf4j in the API and is accessed from core
+      relocate 'datadog.trace.relocate', 'datadog.trace.agent.relocate'
+    }
   }
 }
 
-def includeShadowJar(TaskProvider<ShadowJar> shadowJarTask, String jarname) {
+def includeShadowJar(TaskProvider<ShadowJar> includedShadowJarTask, String destinationDir) {
   def opentracingFound = new AtomicBoolean()
   project.processResources {
     doFirst {
@@ -129,12 +131,12 @@ def includeShadowJar(TaskProvider<ShadowJar> shadowJarTask, String jarname) {
       }
     }
 
-    from(zipTree(shadowJarTask.get().archiveFile)) {
-      into jarname
+    from(zipTree(includedShadowJarTask.map { it.archiveFile })) {
+      into destinationDir
       rename '(^.*)\\.class$', '$1.classdata'
       // Rename LICENSE file since it clashes with license dir on non-case sensitive FSs (i.e. Mac)
       rename '^LICENSE$', 'LICENSE.renamed'
-      if (jarname == 'inst') {
+      if (destinationDir == 'inst') {
         // byte-buddy now ships classes optimized for Java8+ under META-INF/versions/9
         // since we target Java8+ we can promote these classes over the pre-Java8 ones
         duplicatesStrategy = DuplicatesStrategy.EXCLUDE
@@ -148,27 +150,29 @@ def includeShadowJar(TaskProvider<ShadowJar> shadowJarTask, String jarname) {
   }
 
   project.tasks.named("processResources") {
-    dependsOn shadowJarTask
+    dependsOn includedShadowJarTask
+  }
+
+  includedShadowJarTask.configure {
+    generalShadowJarConfig(it as ShadowJar)
   }
-  shadowJarTask.configure generalShadowJarConfig
 }
 
-def includeSubprojShadowJar(String projName, String jarname) {
-  evaluationDependsOn projName
-  def proj = project(projName)
-  includeShadowJar proj.tasks.named("shadowJar"), jarname
+def includeSubprojShadowJar(Project includedProjectJar, String destinationDir) {
+  evaluationDependsOn(includedProjectJar.path)
+  includeShadowJar(includedProjectJar.tasks.named("shadowJar", ShadowJar), destinationDir)
 }
 
-includeSubprojShadowJar ':dd-java-agent:instrumentation', 'inst'
-includeSubprojShadowJar ':dd-java-agent:agent-jmxfetch', 'metrics'
-includeSubprojShadowJar ':dd-java-agent:agent-profiling', 'profiling'
-includeSubprojShadowJar ':dd-java-agent:appsec', 'appsec'
-includeSubprojShadowJar ':dd-java-agent:agent-iast', 'iast'
-includeSubprojShadowJar ':dd-java-agent:agent-debugger', 'debugger'
-includeSubprojShadowJar ':dd-java-agent:agent-ci-visibility', 'ci-visibility'
-includeSubprojShadowJar ':dd-java-agent:agent-llmobs', 'llm-obs'
-includeSubprojShadowJar ':dd-java-agent:agent-logs-intake', 'logs-intake'
-includeSubprojShadowJar ':dd-java-agent:cws-tls', 'cws-tls'
+includeSubprojShadowJar(project(':dd-java-agent:instrumentation'), 'inst')
+includeSubprojShadowJar(project(':dd-java-agent:agent-jmxfetch'), 'metrics')
+includeSubprojShadowJar(project(':dd-java-agent:agent-profiling'), 'profiling')
+includeSubprojShadowJar(project(':dd-java-agent:appsec'), 'appsec')
+includeSubprojShadowJar(project(':dd-java-agent:agent-iast'), 'iast')
+includeSubprojShadowJar(project(':dd-java-agent:agent-debugger'), 'debugger')
+includeSubprojShadowJar(project(':dd-java-agent:agent-ci-visibility'), 'ci-visibility')
+includeSubprojShadowJar(project(':dd-java-agent:agent-llmobs'), 'llm-obs')
+includeSubprojShadowJar(project(':dd-java-agent:agent-logs-intake'), 'logs-intake')
+includeSubprojShadowJar(project(':dd-java-agent:cws-tls'), 'cws-tls')
 
 def sharedShadowJar = tasks.register('sharedShadowJar', ShadowJar) {
   configurations = [project.configurations.sharedShadowInclude]
@@ -200,7 +204,9 @@ def traceShadowJar = tasks.register('traceShadowJar', ShadowJar) {
 }
 includeShadowJar(traceShadowJar, 'trace')
 
-shadowJar generalShadowJarConfig >> {
+tasks.named("shadowJar", ShadowJar) {
+  generalShadowJarConfig(it)
+
   configurations = [project.configurations.shadowInclude]
 
   archiveClassifier = ''
@@ -352,7 +358,7 @@ tasks.register('checkAgentJarSize') {
   doLast {
     // Arbitrary limit to prevent unintentional increases to the agent jar size
     // Raise or lower as required
-    assert shadowJar.archiveFile.get().getAsFile().length() <= 32 * 1024 * 1024
+    assert tasks.named("shadowJar", ShadowJar).get().archiveFile.get().getAsFile().length() <= 32 * 1024 * 1024
   }
 
   dependsOn "shadowJar"