Skip to content

Commit e5e5427

Browse files
authored
Merge pull request #7716 from DataDog/mhlidd/server_error_statuses
Add support for `TRACE_HTTP_SERVER_ERROR_STATUSES`
2 parents 2305f07 + 6732dfa commit e5e5427

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

dd-trace-api/src/main/java/datadog/trace/api/config/TracerConfig.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ public final class TracerConfig {
6565
"trace.http.server.path-resource-name-mapping";
6666
public static final String TRACE_HTTP_CLIENT_PATH_RESOURCE_NAME_MAPPING =
6767
"trace.http.client.path-resource-name-mapping";
68-
public static final String HTTP_SERVER_ERROR_STATUSES = "http.server.error.statuses";
68+
// Use TRACE_HTTP_SERVER_ERROR_STATUSES instead
69+
@Deprecated public static final String HTTP_SERVER_ERROR_STATUSES = "http.server.error.statuses";
70+
public static final String TRACE_HTTP_SERVER_ERROR_STATUSES = "trace.http.server.error.statuses";
6971
public static final String HTTP_CLIENT_ERROR_STATUSES = "http.client.error.statuses";
7072

7173
public static final String SPLIT_BY_TAGS = "trace.split-by-tags";

internal-api/src/main/java/datadog/trace/api/Config.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,9 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
777777

778778
httpServerErrorStatuses =
779779
configProvider.getIntegerRange(
780-
HTTP_SERVER_ERROR_STATUSES, DEFAULT_HTTP_SERVER_ERROR_STATUSES);
780+
TRACE_HTTP_SERVER_ERROR_STATUSES,
781+
DEFAULT_HTTP_SERVER_ERROR_STATUSES,
782+
HTTP_SERVER_ERROR_STATUSES);
781783

782784
httpClientErrorStatuses =
783785
configProvider.getIntegerRange(

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ public Map<String, String> getMergedMapWithOptionalMappings(
309309
return merged;
310310
}
311311

312-
public BitSet getIntegerRange(final String key, final BitSet defaultValue) {
313-
final String value = getString(key);
312+
public BitSet getIntegerRange(final String key, final BitSet defaultValue, String... aliases) {
313+
final String value = getString(key, null, aliases);
314314
try {
315315
if (value != null) {
316316
return ConfigConverter.parseIntegerRangeSet(value, key);

0 commit comments

Comments
 (0)