feat: add test event finished FTR telemetry

Author: daniel-mohedano

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/AbstractTestSession.java

@@ -132,8 +132,7 @@ public AbstractTestSession(
         config.isAgentlessLogSubmissionEnabled() ? AgentlessLogSubmissionEnabled.TRUE : null,
         CIConstants.FAIL_FAST_TEST_ORDER.equalsIgnoreCase(config.getCiVisibilityTestOrder())
             ? FailFastTestOrderEnabled.TRUE
-            : null,
-        null);
+            : null);
 
     if (instrumentationType == InstrumentationType.MANUAL_API) {
       metricCollector.add(CiVisibilityCountMetric.MANUAL_API_EVENTS, 1, EventType.SESSION);

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/domain/TestImpl.java

@@ -20,6 +20,7 @@
 import datadog.trace.api.civisibility.telemetry.TagValue;
 import datadog.trace.api.civisibility.telemetry.tag.BrowserDriver;
 import datadog.trace.api.civisibility.telemetry.tag.EventType;
+import datadog.trace.api.civisibility.telemetry.tag.FailedTestReplayEnabled;
 import datadog.trace.api.civisibility.telemetry.tag.HasFailedAllRetries;
 import datadog.trace.api.civisibility.telemetry.tag.IsAttemptToFix;
 import datadog.trace.api.civisibility.telemetry.tag.IsDisabled;
@@ -305,7 +306,9 @@ public void end(@Nullable Long endTime) {
         span.getTag(Tags.TEST_IS_RETRY) != null ? IsRetry.TRUE : null,
         span.getTag(Tags.TEST_HAS_FAILED_ALL_RETRIES) != null ? HasFailedAllRetries.TRUE : null,
         retryReason instanceof TagValue ? (TagValue) retryReason : null,
-        null,
+        span.getTag(Tags.ERROR_DEBUG_INFO_CAPTURED) != null
+            ? FailedTestReplayEnabled.TestMetric.TRUE
+            : null,
         span.getTag(Tags.TEST_IS_RUM_ACTIVE) != null ? IsRum.TRUE : null,
         CIConstants.SELENIUM_BROWSER_DRIVER.equals(span.getTag(Tags.TEST_BROWSER_DRIVER))
             ? BrowserDriver.SELENIUM

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/exception/DefaultExceptionDebugger.java

@@ -13,6 +13,7 @@
 import datadog.trace.bootstrap.debugger.DebuggerContext;
 import datadog.trace.bootstrap.debugger.DebuggerContext.ClassNameFilter;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
+import datadog.trace.bootstrap.instrumentation.api.Tags;
 import datadog.trace.util.AgentTaskScheduler;
 import java.time.Duration;
 import java.util.ArrayDeque;
@@ -32,7 +33,6 @@ public class DefaultExceptionDebugger implements DebuggerContext.ExceptionDebugg
   public static final String DD_DEBUG_ERROR_EXCEPTION_ID = DD_DEBUG_ERROR_PREFIX + "exception_id";
   public static final String DD_DEBUG_ERROR_EXCEPTION_HASH =
       DD_DEBUG_ERROR_PREFIX + "exception_hash";
-  public static final String ERROR_DEBUG_INFO_CAPTURED = "error.debug_info_captured";
   public static final String SNAPSHOT_ID_TAG_FMT = DD_DEBUG_ERROR_PREFIX + "%d.snapshot_id";
 
   // Test Optimization / Failed Test Replay specific
@@ -179,19 +179,21 @@ private static void processSnapshotsAndSetTags(
       span.setTag(tagName, snapshot.getId());
       LOGGER.debug("add tag to span[{}]: {}: {}", span.getSpanId(), tagName, snapshot.getId());
 
-      StackTraceElement stackFrame = innerTrace[currentIdx];
-      String fileTag = String.format(TEST_DEBUG_ERROR_FILE_TAG_FMT, frameIndex);
-      String lineTag = String.format(TEST_DEBUG_ERROR_LINE_TAG_FMT, frameIndex);
-      span.setTag(fileTag, stackFrame.getFileName());
-      span.setTag(lineTag, stackFrame.getLineNumber());
+      if (Config.get().isCiVisibilityFailedTestReplayActive()) {
+        StackTraceElement stackFrame = innerTrace[currentIdx];
+        String fileTag = String.format(TEST_DEBUG_ERROR_FILE_TAG_FMT, frameIndex);
+        String lineTag = String.format(TEST_DEBUG_ERROR_LINE_TAG_FMT, frameIndex);
+        span.setTag(fileTag, stackFrame.getFileName());
+        span.setTag(lineTag, stackFrame.getLineNumber());
 
-      LOGGER.debug(
-          "add ftr debug tags to span[{}]: {}={}, {}={}",
-          span.getSpanId(),
-          fileTag,
-          stackFrame.getFileName(),
-          lineTag,
-          stackFrame.getLineNumber());
+        LOGGER.debug(
+            "add ftr debug tags to span[{}]: {}={}, {}={}",
+            span.getSpanId(),
+            fileTag,
+            stackFrame.getFileName(),
+            lineTag,
+            stackFrame.getLineNumber());
+      }
 
       if (!state.isSnapshotSent()) {
         DebuggerAgent.getSink().addSnapshot(snapshot);
@@ -206,7 +208,7 @@ private static void processSnapshotsAndSetTags(
           span.getSpanId(),
           DD_DEBUG_ERROR_EXCEPTION_ID,
           state.getExceptionId());
-      span.setTag(ERROR_DEBUG_INFO_CAPTURED, true);
+      span.setTag(Tags.ERROR_DEBUG_INFO_CAPTURED, true);
       span.setTag(DD_DEBUG_ERROR_EXCEPTION_HASH, fingerprint);
     }
   }

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/exception/ExceptionProbeInstrumentationTest.java

@@ -3,7 +3,6 @@
 import static com.datadog.debugger.agent.ConfigurationAcceptor.Source.REMOTE_CONFIG;
 import static com.datadog.debugger.exception.DefaultExceptionDebugger.DD_DEBUG_ERROR_EXCEPTION_HASH;
 import static com.datadog.debugger.exception.DefaultExceptionDebugger.DD_DEBUG_ERROR_EXCEPTION_ID;
-import static com.datadog.debugger.exception.DefaultExceptionDebugger.ERROR_DEBUG_INFO_CAPTURED;
 import static com.datadog.debugger.exception.DefaultExceptionDebugger.SNAPSHOT_ID_TAG_FMT;
 import static com.datadog.debugger.util.MoshiSnapshotTestHelper.getValue;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -38,6 +37,7 @@
 import datadog.trace.bootstrap.debugger.ProbeId;
 import datadog.trace.bootstrap.debugger.ProbeLocation;
 import datadog.trace.bootstrap.debugger.ProbeRateLimiter;
+import datadog.trace.bootstrap.instrumentation.api.Tags;
 import datadog.trace.core.CoreTracer;
 import java.io.IOException;
 import java.lang.instrument.ClassFileTransformer;
@@ -157,7 +157,7 @@ public void instrumentAndCaptureSnapshots() throws Exception {
     MutableSpan span = traceInterceptor.getFirstSpan();
     assertEquals(snapshot0.getExceptionId(), span.getTags().get(DD_DEBUG_ERROR_EXCEPTION_ID));
     assertEquals(fingerprint, span.getTags().get(DD_DEBUG_ERROR_EXCEPTION_HASH));
-    assertEquals(Boolean.TRUE, span.getTags().get(ERROR_DEBUG_INFO_CAPTURED));
+    assertEquals(Boolean.TRUE, span.getTags().get(Tags.ERROR_DEBUG_INFO_CAPTURED));
     assertEquals(snapshot0.getId(), span.getTags().get(String.format(SNAPSHOT_ID_TAG_FMT, 0)));
     assertEquals(1, probeSampler.getCallCount());
     assertEquals(1, globalSampler.getCallCount());
@@ -198,11 +198,11 @@ public void differentExceptionsSameStack() throws Exception {
     assertExceptionMsg("illegal argument", snapshot1);
     MutableSpan span0 = traceInterceptor.getAllTraces().get(0).get(0);
     assertEquals(snapshot0.getExceptionId(), span0.getTags().get(DD_DEBUG_ERROR_EXCEPTION_ID));
-    assertEquals(Boolean.TRUE, span0.getTags().get(ERROR_DEBUG_INFO_CAPTURED));
+    assertEquals(Boolean.TRUE, span0.getTags().get(Tags.ERROR_DEBUG_INFO_CAPTURED));
     assertEquals(snapshot0.getId(), span0.getTags().get(String.format(SNAPSHOT_ID_TAG_FMT, 0)));
     MutableSpan span1 = traceInterceptor.getAllTraces().get(1).get(0);
     assertEquals(snapshot1.getExceptionId(), span1.getTags().get(DD_DEBUG_ERROR_EXCEPTION_ID));
-    assertEquals(Boolean.TRUE, span1.getTags().get(ERROR_DEBUG_INFO_CAPTURED));
+    assertEquals(Boolean.TRUE, span1.getTags().get(Tags.ERROR_DEBUG_INFO_CAPTURED));
     assertEquals(snapshot1.getId(), span1.getTags().get(String.format(SNAPSHOT_ID_TAG_FMT, 0)));
   }
 

internal-api/src/main/java/datadog/trace/api/civisibility/telemetry/CiVisibilityCountMetric.java

@@ -54,8 +54,7 @@ public enum CiVisibilityCountMetric {
       Provider.class,
       AutoInjected.class,
       AgentlessLogSubmissionEnabled.class,
-      FailFastTestOrderEnabled.class,
-      FailedTestReplayEnabled.SessionMetric.class),
+      FailFastTestOrderEnabled.class),
   /** The number of events created */
   EVENT_CREATED(
       "event_created",

internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/Tags.java

@@ -107,6 +107,8 @@ public class Tags {
   public static final String TEST_TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED =
       "test.test_management.attempt_to_fix_passed";
 
+  public static final String ERROR_DEBUG_INFO_CAPTURED = "error.debug_info_captured";
+
   public static final String CI_PROVIDER_NAME = "ci.provider.name";
   public static final String CI_PIPELINE_ID = "ci.pipeline.id";
   public static final String CI_PIPELINE_NAME = "ci.pipeline.name";