Force JDK 8 as default in muzzle and instrument plugin

Author: smola

buildSrc/src/main/groovy/InstrumentPlugin.groovy

@@ -152,17 +152,16 @@ abstract class InstrumentTask extends DefaultTask {
   }
 
   private workQueue() {
-    if (this.javaVersion) {
-      def javaLauncher = this.javaToolchainService.launcherFor { spec ->
-        spec.languageVersion.set(JavaLanguageVersion.of(this.javaVersion))
-      }.get()
-      return this.workerExecutor.processIsolation { spec ->
-        spec.forkOptions { fork ->
-          fork.executable = javaLauncher.executablePath
-        }
+    if (!this.javaVersion) {
+      this.javaVersion = "8"
+    }
+    def javaLauncher = this.javaToolchainService.launcherFor { spec ->
+      spec.languageVersion.set(JavaLanguageVersion.of(this.javaVersion))
+    }.get()
+    return this.workerExecutor.processIsolation { spec ->
+      spec.forkOptions { fork ->
+        fork.executable = javaLauncher.executablePath
       }
-    } else {
-      return this.workerExecutor.noIsolation()
     }
   }
 }

buildSrc/src/main/groovy/MuzzlePlugin.groovy

@@ -722,18 +722,14 @@ abstract class MuzzleTask extends DefaultTask {
     MuzzleDirective muzzleDirective = null
   ) {
     def workQueue
-    String javaVersion = muzzleDirective?.javaVersion
-    if (javaVersion) {
-      def javaLauncher = javaToolchainService.launcherFor { spec ->
-        spec.languageVersion.set(JavaLanguageVersion.of(javaVersion))
-      }.get()
-      workQueue = workerExecutor.processIsolation { spec ->
-        spec.forkOptions { fork ->
-          fork.executable = javaLauncher.executablePath
-        }
+    String javaVersion = muzzleDirective?.javaVersion ?: "8"
+    def javaLauncher = javaToolchainService.launcherFor { spec ->
+      spec.languageVersion.set(JavaLanguageVersion.of(javaVersion))
+    }.get()
+    workQueue = workerExecutor.processIsolation { spec ->
+      spec.forkOptions { fork ->
+        fork.executable = javaLauncher.executablePath
       }
-    } else {
-      workQueue = workerExecutor.noIsolation()
     }
     workQueue.submit(MuzzleAction.class, parameters -> {
       parameters.buildStartedTime.set(invocationDetails.buildStartedTime)