Skip to content

Commit eca080e

Browse files
committed
Baggage tags unit tests have been moved to HttpServerDecoratorTest
1 parent af0a640 commit eca080e

File tree

1 file changed

+1
-27
lines changed

1 file changed

+1
-27
lines changed

dd-trace-core/src/test/groovy/datadog/trace/core/CoreSpanBuilderTest.groovy

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,14 @@ import static datadog.trace.api.DDTags.DJM_ENABLED
44
import static datadog.trace.api.DDTags.DSM_ENABLED
55
import static datadog.trace.api.DDTags.PROFILING_ENABLED
66
import static datadog.trace.api.DDTags.SCHEMA_VERSION_TAG_KEY
7-
import static datadog.trace.api.config.TracerConfig.TRACE_BAGGAGE_TAG_KEYS
87

98
import datadog.trace.api.Config
109
import datadog.trace.api.DDSpanId
1110
import datadog.trace.api.DDTraceId
1211
import datadog.trace.api.TagMap
1312
import datadog.trace.api.gateway.RequestContextSlot
14-
import datadog.trace.api.sampling.PrioritySampling
1513
import datadog.trace.api.naming.SpanNaming
14+
import datadog.trace.api.sampling.PrioritySampling
1615
import datadog.trace.bootstrap.instrumentation.api.AgentScope
1716
import datadog.trace.api.datastreams.NoopPathwayContext
1817
import datadog.trace.bootstrap.instrumentation.api.TagContext
@@ -493,31 +492,6 @@ class CoreSpanBuilderTest extends DDCoreSpecification {
493492
span1.finish()
494493
}
495494

496-
def "buildSpan should add baggage tags with different configurations"() {
497-
setup:
498-
injectSysConfig(TRACE_BAGGAGE_TAG_KEYS, baggageTagKeysConfig)
499-
def baggage = ["user.id": "alice", "session.id": "123", "region": "us-west-1", "env": "production"]
500-
def tagContext = new TagContext(null, null, null, baggage, PrioritySampling.UNSET, null, DATADOG, DDTraceId.ZERO)
501-
502-
when:
503-
def span = tracer.buildSpan("test", "test-op")
504-
.asChildOf(tagContext)
505-
.start()
506-
507-
then:
508-
// Filter span tags to only check baggage tags (those starting with "baggage.")
509-
def actualBaggageTags = span.tags.findAll { key, value -> key.startsWith("baggage.") }
510-
actualBaggageTags == expectedBaggageTags
511-
512-
cleanup:
513-
span.finish()
514-
515-
where:
516-
baggageTagKeysConfig | expectedBaggageTags
517-
"user.id" | ["baggage.user.id": "alice"]
518-
"user.id,session.id" | ["baggage.user.id": "alice", "baggage.session.id": "123"]
519-
}
520-
521495
def productTags() {
522496
def productTags = [
523497
(PROFILING_ENABLED) : Config.get().isProfilingEnabled() ? 1 : 0

0 commit comments

Comments
 (0)