Do not skip ErrorReportValve.report in any case (#7489)

Initial advice skipped the original method on <400 http status code and
responses not marked as errors. But we should not be changing the
original behavior by default.

Author: smola

dd-java-agent/instrumentation/tomcat-appsec-7/src/main/java/datadog/trace/instrumentation/tomcat7/ErrorReportValueAdvice.java

@@ -15,8 +15,8 @@
 
 public class ErrorReportValueAdvice {
 
-  @Advice.OnMethodEnter(suppress = Throwable.class, skipOn = Advice.OnNonDefaultValue.class)
-  public static boolean onEnter(
+  @Advice.OnMethodEnter(suppress = Throwable.class)
+  public static void onEnter(
       @Advice.Argument(value = 1) Response response,
       @Advice.Argument(value = 2) Throwable throwable,
       @Advice.Origin("#t") String className,
@@ -27,7 +27,7 @@ public static boolean onEnter(
     // Do nothing if the response hasn't been explicitly marked as in error
     //    and that error has not been reported.
     if (statusCode < 400 || statusCode == 404 || !response.isError()) {
-      return true; // skip original method
+      return;
     }
     if (throwable != null) {
       // Report IAST
@@ -45,12 +45,12 @@ public static boolean onEnter(
     final Config config = Config.get();
     if (config.getIastActivation() != ProductActivation.FULLY_ENABLED
         || !config.isIastStacktraceLeakSuppress()) {
-      return false;
+      return;
     }
 
     byte[] template = BlockingActionHelper.getTemplate(HTML);
     if (template == null) {
-      return false;
+      return;
     }
 
     try {
@@ -71,7 +71,5 @@ public static boolean onEnter(
     } catch (IOException | IllegalStateException e) {
       // Ignore
     }
-
-    return false;
   }
 }