feat: Remove Strings.escapeToJson method

Author: PerfectSlayer

internal-api/src/main/java/datadog/trace/util/Strings.java

@@ -16,70 +16,6 @@ public final class Strings {
     '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'
   };
 
-  public static String escapeToJson(String string) {
-    if (string == null || string.isEmpty()) {
-      return "";
-    }
-
-    final StringBuilder sb = new StringBuilder();
-    int sz = string.length();
-    for (int i = 0; i < sz; ++i) {
-      char ch = string.charAt(i);
-      if (ch > 4095) {
-        sb.append("\\u").append(hex(ch));
-      } else if (ch > 255) {
-        sb.append("\\u0").append(hex(ch));
-      } else if (ch > 127) {
-        sb.append("\\u00").append(hex(ch));
-      } else if (ch < ' ') {
-        switch (ch) {
-          case '\b':
-            sb.append((char) 92).append((char) 98);
-            break;
-          case '\t':
-            sb.append((char) 92).append((char) 116);
-            break;
-          case '\n':
-            sb.append((char) 92).append((char) 110);
-            break;
-          case '\u000b':
-          default:
-            if (ch > 15) {
-              sb.append("\\u00").append(hex(ch));
-            } else {
-              sb.append("\\u000").append(hex(ch));
-            }
-            break;
-          case '\f':
-            sb.append((char) 92).append((char) 102);
-            break;
-          case '\r':
-            sb.append((char) 92).append((char) 114);
-            break;
-        }
-      } else {
-        switch (ch) {
-          case '"':
-            sb.append((char) 92).append((char) 34);
-            break;
-          case '\'':
-            sb.append((char) 92).append((char) 39);
-            break;
-          case '/':
-            sb.append((char) 92).append((char) 47);
-            break;
-          case '\\':
-            sb.append((char) 92).append((char) 92);
-            break;
-          default:
-            sb.append(ch);
-        }
-      }
-    }
-
-    return sb.toString();
-  }
-
   public static String toEnvVar(String string) {
     return string.replace('.', '_').replace('-', '_').toUpperCase();
   }
@@ -255,8 +191,8 @@ public static String sha256(String input) throws NoSuchAlgorithmException {
     MessageDigest digest = MessageDigest.getInstance("SHA-256");
     byte[] hash = digest.digest(input.getBytes(StandardCharsets.UTF_8));
     StringBuilder hexString = new StringBuilder(2 * hash.length);
-    for (int i = 0; i < hash.length; i++) {
-      String hex = Integer.toHexString(0xFF & hash[i]);
+    for (byte b : hash) {
+      String hex = Integer.toHexString(0xFF & b);
       if (hex.length() == 1) {
         hexString.append('0');
       }

internal-api/src/test/groovy/datadog/trace/util/StringsTest.groovy

@@ -102,33 +102,6 @@ class StringsTest extends DDSpecification {
     // spotless:on
   }
 
-  def "test escape javascript"() {
-    when:
-    String escaped = Strings.escapeToJson(string)
-
-    then:
-    escaped == expected
-
-    where:
-    string                   | expected
-    null                     | ""
-    ""                       | ""
-    ((char) 4096).toString() | '\\u1000'
-    ((char) 256).toString()  | '\\u0100'
-    ((char) 128).toString()  | '\\u0080'
-    "\b"                     | "\\b"
-    "\t"                     | "\\t"
-    "\n"                     | "\\n"
-    "\f"                     | "\\f"
-    "\r"                     | "\\r"
-    '"'                      | '\\"'
-    '\''                     | '\\\''
-    '/'                      | '\\/'
-    '\\'                     | '\\\\'
-    "\u000b"                 | "\\u000B"
-    "a"                      | "a"
-  }
-
   def "test sha256"() {
     when:
     String sha256 = Strings.sha256(input)