Fix tests

Author: jbachorik

dd-java-agent/agent-profiling/profiling-controller/src/test/java/com/datadog/profiling/controller/TempLocationManagerTest.java

@@ -38,19 +38,14 @@ void testDefault() throws Exception {
   @Test
   void testFromConfig() throws Exception {
     Path myDir = Paths.get(System.getProperty("java.io.tmpdir"), "test1");
-    try {
-      Files.createDirectories(myDir);
-      Properties props = new Properties();
-      props.put(ProfilingConfig.PROFILING_TEMP_DIR, myDir.toString());
-      ConfigProvider configProvider = ConfigProvider.withPropertiesOverride(props);
-      TempLocationManager tempLocationManager = new TempLocationManager(configProvider);
-      Path tempDir = tempLocationManager.getTempDir();
-      assertNotNull(tempDir);
-      assertTrue(tempDir.toString().startsWith(myDir.toString()));
-    } finally {
-      // make sure to delete the test directory
-      Files.delete(myDir);
-    }
+    Files.createDirectories(myDir);
+    Properties props = new Properties();
+    props.put(ProfilingConfig.PROFILING_TEMP_DIR, myDir.toString());
+    ConfigProvider configProvider = ConfigProvider.withPropertiesOverride(props);
+    TempLocationManager tempLocationManager = new TempLocationManager(configProvider);
+    Path tempDir = tempLocationManager.getTempDir();
+    assertNotNull(tempDir);
+    assertTrue(tempDir.toString().startsWith(myDir.toString()));
   }
 
   @Test
@@ -66,18 +61,13 @@ void testFromConfigInvalid() {
   @Test
   void testFromConfigNotWritable() throws Exception {
     Path myDir = Paths.get(System.getProperty("java.io.tmpdir"), "test3");
-    try {
-      Files.createDirectories(
-          myDir,
-          PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("r-x------")));
-      Properties props = new Properties();
-      props.put(ProfilingConfig.PROFILING_TEMP_DIR, myDir.toString());
-      ConfigProvider configProvider = ConfigProvider.withPropertiesOverride(props);
-      TempLocationManager tempLocationManager = new TempLocationManager(configProvider);
-      assertThrows(IllegalStateException.class, tempLocationManager::getTempDir);
-    } finally {
-      // make sure to delete the test directory
-      Files.delete(myDir);
-    }
+    Files.createDirectories(
+        myDir,
+        PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("r-x------")));
+    Properties props = new Properties();
+    props.put(ProfilingConfig.PROFILING_TEMP_DIR, myDir.toString());
+    ConfigProvider configProvider = ConfigProvider.withPropertiesOverride(props);
+    TempLocationManager tempLocationManager = new TempLocationManager(configProvider);
+    assertThrows(IllegalStateException.class, tempLocationManager::getTempDir);
   }
 }