From 91af878da9b02a254783952a3fb12974faa9a492 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Wed, 8 Oct 2025 15:09:44 -0400 Subject: [PATCH 1/5] Try longer benchmark time --- .gitlab/benchmarks.yml | 2 +- benchmark/load/insecure-bank/k6.js | 6 +++--- benchmark/load/petclinic/k6.js | 6 +++--- benchmark/load/run.sh | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.gitlab/benchmarks.yml b/.gitlab/benchmarks.yml index 7127d9d995d..c91d5b22151 100644 --- a/.gitlab/benchmarks.yml +++ b/.gitlab/benchmarks.yml @@ -1,7 +1,7 @@ .benchmarks: stage: benchmarks interruptible: true - timeout: 1h + timeout: 3h tags: ["runner:apm-k8s-tweaked-metal"] image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:dd-trace-java-benchmarks needs: [ "build", "publish-artifacts-to-s3" ] diff --git a/benchmark/load/insecure-bank/k6.js b/benchmark/load/insecure-bank/k6.js index 2dc5ce582c6..19b3e10a8df 100644 --- a/benchmark/load/insecure-bank/k6.js +++ b/benchmark/load/insecure-bank/k6.js @@ -28,7 +28,7 @@ export const options = function (variants) { scenarios[`load--insecure-bank--${variant}--warmup`] = { executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors vus: 5, - duration: '20s', + duration: '120s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] @@ -38,8 +38,8 @@ export const options = function (variants) { scenarios[`load--insecure-bank--${variant}--high_load`] = { executor: 'constant-vus', vus: 5, - startTime: '22s', - duration: '15s', + startTime: '122s', + duration: '60s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] diff --git a/benchmark/load/petclinic/k6.js b/benchmark/load/petclinic/k6.js index a215ad7ea2d..f479b10cddb 100644 --- a/benchmark/load/petclinic/k6.js +++ b/benchmark/load/petclinic/k6.js @@ -28,7 +28,7 @@ export const options = function (variants) { scenarios[`load--petclinic--${variant}--warmup`] = { executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors vus: 5, - duration: '20s', + duration: '120s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] @@ -38,8 +38,8 @@ export const options = function (variants) { scenarios[`load--petclinic--${variant}--high_load`] = { executor: 'constant-vus', vus: 5, - startTime: '22s', - duration: '15s', + startTime: '122s', + duration: '60s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] diff --git a/benchmark/load/run.sh b/benchmark/load/run.sh index d43a28383d5..1336079fa3c 100755 --- a/benchmark/load/run.sh +++ b/benchmark/load/run.sh @@ -43,7 +43,7 @@ for app in *; do # Using profiler variants for healthcheck as they are the slowest if [ "${app}" == "petclinic" ]; then HEALTHCHECK_URL=http://localhost:8082 - REPETITIONS_COUNT=5 + REPETITIONS_COUNT=3 elif [ "${app}" == "insecure-bank" ]; then HEALTHCHECK_URL=http://localhost:8082/login REPETITIONS_COUNT=2 From a28ab07aec630072a12123fe65224c657bdc2bff Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Thu, 9 Oct 2025 10:30:07 -0500 Subject: [PATCH 2/5] Half warmup time --- benchmark/load/insecure-bank/k6.js | 4 ++-- benchmark/load/petclinic/k6.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/benchmark/load/insecure-bank/k6.js b/benchmark/load/insecure-bank/k6.js index 19b3e10a8df..bf59daabd29 100644 --- a/benchmark/load/insecure-bank/k6.js +++ b/benchmark/load/insecure-bank/k6.js @@ -28,7 +28,7 @@ export const options = function (variants) { scenarios[`load--insecure-bank--${variant}--warmup`] = { executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors vus: 5, - duration: '120s', + duration: '60s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] @@ -38,7 +38,7 @@ export const options = function (variants) { scenarios[`load--insecure-bank--${variant}--high_load`] = { executor: 'constant-vus', vus: 5, - startTime: '122s', + startTime: '62s', duration: '60s', gracefulStop: '2s', env: { diff --git a/benchmark/load/petclinic/k6.js b/benchmark/load/petclinic/k6.js index f479b10cddb..012905270c6 100644 --- a/benchmark/load/petclinic/k6.js +++ b/benchmark/load/petclinic/k6.js @@ -28,7 +28,7 @@ export const options = function (variants) { scenarios[`load--petclinic--${variant}--warmup`] = { executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors vus: 5, - duration: '120s', + duration: '60s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] @@ -38,7 +38,7 @@ export const options = function (variants) { scenarios[`load--petclinic--${variant}--high_load`] = { executor: 'constant-vus', vus: 5, - startTime: '122s', + startTime: '62s', duration: '60s', gracefulStop: '2s', env: { From cc722395d46a592f5085924e66f574eb906daf19 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Thu, 9 Oct 2025 16:25:54 -0500 Subject: [PATCH 3/5] Run benchmarks for longer --- benchmark/load/insecure-bank/k6.js | 2 +- benchmark/load/petclinic/k6.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/benchmark/load/insecure-bank/k6.js b/benchmark/load/insecure-bank/k6.js index bf59daabd29..df4b067f458 100644 --- a/benchmark/load/insecure-bank/k6.js +++ b/benchmark/load/insecure-bank/k6.js @@ -39,7 +39,7 @@ export const options = function (variants) { executor: 'constant-vus', vus: 5, startTime: '62s', - duration: '60s', + duration: '240s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] diff --git a/benchmark/load/petclinic/k6.js b/benchmark/load/petclinic/k6.js index 012905270c6..f6a90184ccb 100644 --- a/benchmark/load/petclinic/k6.js +++ b/benchmark/load/petclinic/k6.js @@ -39,7 +39,7 @@ export const options = function (variants) { executor: 'constant-vus', vus: 5, startTime: '62s', - duration: '60s', + duration: '240s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] From c5e6eccd0028a7b0d8bd1c2c143ca53155d47e2d Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Thu, 23 Oct 2025 17:25:45 -0400 Subject: [PATCH 4/5] Change to two reps and 165s warmup time --- benchmark/load/insecure-bank/k6.js | 6 +++--- benchmark/load/petclinic/k6.js | 6 +++--- benchmark/load/run.sh | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/benchmark/load/insecure-bank/k6.js b/benchmark/load/insecure-bank/k6.js index df4b067f458..2dd800fa7e5 100644 --- a/benchmark/load/insecure-bank/k6.js +++ b/benchmark/load/insecure-bank/k6.js @@ -28,7 +28,7 @@ export const options = function (variants) { scenarios[`load--insecure-bank--${variant}--warmup`] = { executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors vus: 5, - duration: '60s', + duration: '165s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] @@ -38,8 +38,8 @@ export const options = function (variants) { scenarios[`load--insecure-bank--${variant}--high_load`] = { executor: 'constant-vus', vus: 5, - startTime: '62s', - duration: '240s', + startTime: '167s', + duration: '15s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] diff --git a/benchmark/load/petclinic/k6.js b/benchmark/load/petclinic/k6.js index f6a90184ccb..debeab10a8e 100644 --- a/benchmark/load/petclinic/k6.js +++ b/benchmark/load/petclinic/k6.js @@ -28,7 +28,7 @@ export const options = function (variants) { scenarios[`load--petclinic--${variant}--warmup`] = { executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors vus: 5, - duration: '60s', + duration: '165s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] @@ -38,8 +38,8 @@ export const options = function (variants) { scenarios[`load--petclinic--${variant}--high_load`] = { executor: 'constant-vus', vus: 5, - startTime: '62s', - duration: '240s', + startTime: '167s', + duration: '15s', gracefulStop: '2s', env: { "APP_URL": variants[variant]["APP_URL"] diff --git a/benchmark/load/run.sh b/benchmark/load/run.sh index 1336079fa3c..5f2f265b045 100755 --- a/benchmark/load/run.sh +++ b/benchmark/load/run.sh @@ -43,7 +43,7 @@ for app in *; do # Using profiler variants for healthcheck as they are the slowest if [ "${app}" == "petclinic" ]; then HEALTHCHECK_URL=http://localhost:8082 - REPETITIONS_COUNT=3 + REPETITIONS_COUNT=2 elif [ "${app}" == "insecure-bank" ]; then HEALTHCHECK_URL=http://localhost:8082/login REPETITIONS_COUNT=2 From 1ab64de01732115f460129860a491c511421400c Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 24 Oct 2025 10:34:39 -0400 Subject: [PATCH 5/5] Revert timeout back to 1h --- .gitlab/benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/benchmarks.yml b/.gitlab/benchmarks.yml index c91d5b22151..7127d9d995d 100644 --- a/.gitlab/benchmarks.yml +++ b/.gitlab/benchmarks.yml @@ -1,7 +1,7 @@ .benchmarks: stage: benchmarks interruptible: true - timeout: 3h + timeout: 1h tags: ["runner:apm-k8s-tweaked-metal"] image: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:dd-trace-java-benchmarks needs: [ "build", "publish-artifacts-to-s3" ]