Skip to content

Commit 8ebe522

Browse files
bengltlhunter
authored andcommitted
get rid of --no-async-context-frame (#5726)
Co-authored-by: Thomas Hunter II <[email protected]>
1 parent b900f4a commit 8ebe522

File tree

4 files changed

+1
-38
lines changed

4 files changed

+1
-38
lines changed

.github/workflows/apm-integrations.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,6 @@ jobs:
166166
- run: yarn test:plugins:ci
167167
- uses: ./.github/actions/node/latest
168168
- run: yarn test:plugins:ci
169-
env:
170-
OPTIONS_OVERRIDE: 1
171169
- uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
172170

173171
confluentinc-kafka-javascript:

.github/workflows/debugger.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ jobs:
2929
- uses: ./.github/actions/install
3030
- run: yarn test:debugger:ci
3131
- run: yarn test:integration:debugger
32-
env:
33-
OPTIONS_OVERRIDE: 1
3432
- if: always()
3533
uses: ./.github/actions/testagent/logs
3634
with:

.github/workflows/serverless.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,7 @@ jobs:
3838
aws-sdk:
3939
strategy:
4040
matrix:
41-
include:
42-
- node-version: latest
43-
node-opts: --no-async-context-frame
44-
- node-version: oldest
45-
node-opts: ''
41+
node-version: [oldest, latest]
4642
runs-on: ubuntu-latest
4743
services:
4844
localstack:
@@ -86,8 +82,6 @@ jobs:
8682
version: ${{ matrix.node-version }}
8783
- uses: ./.github/actions/install
8884
- run: yarn test:plugins:ci
89-
env:
90-
NODE_OPTIONS: ${{ matrix.node-opts }}
9185
- if: always()
9286
uses: ./.github/actions/testagent/logs
9387
with:

packages/dd-trace/test/setup/core.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const sinon = require('sinon')
44
const chai = require('chai')
55
const sinonChai = require('sinon-chai')
66
const proxyquire = require('../proxyquire')
7-
const { NODE_MAJOR } = require('../../../../version')
87

98
chai.use(sinonChai)
109
chai.use(require('../asserts/profile'))
@@ -26,29 +25,3 @@ if (/^v\d+\.x$/.test(process.env.GITHUB_BASE_REF || '')) {
2625
process.env.DD_INJECTION_ENABLED = 'true'
2726
process.env.DD_INJECT_FORCE = 'true'
2827
}
29-
30-
// TODO(bengl): remove this block once we can properly support Node.js 24 without it
31-
if (NODE_MAJOR >= 24 && !process.env.OPTIONS_OVERRIDE) {
32-
const childProcess = require('child_process')
33-
const { exec, fork } = childProcess
34-
35-
function addAsyncContextFrame (fn, thisArg, args) {
36-
const opts = args[1]
37-
if (opts) {
38-
const env = opts.env ||= {}
39-
env.NODE_OPTIONS ||= ''
40-
if (!env.NODE_OPTIONS.includes('--no-async-context-frame')) {
41-
env.NODE_OPTIONS += ' --no-async-context-frame'
42-
}
43-
}
44-
return fn.apply(thisArg, args)
45-
}
46-
47-
childProcess.exec = function () {
48-
return addAsyncContextFrame(exec, this, arguments)
49-
}
50-
51-
childProcess.fork = function () {
52-
return addAsyncContextFrame(fork, this, arguments)
53-
}
54-
}

0 commit comments

Comments
 (0)