File tree Expand file tree Collapse file tree 4 files changed +5
-16
lines changed Expand file tree Collapse file tree 4 files changed +5
-16
lines changed Original file line number Diff line number Diff line change 124
124
"@opentelemetry/api" : " 1.8.0" ,
125
125
"@opentelemetry/core" : " ^1.14.0" ,
126
126
"crypto-randomuuid" : " ^1.0.0" ,
127
- "dc-polyfill" : " ^0.1.9 " ,
127
+ "dc-polyfill" : " ^0.1.10 " ,
128
128
"ignore" : " ^7.0.5" ,
129
129
"import-in-the-middle" : " ^1.14.2" ,
130
130
"istanbul-lib-coverage" : " ^3.2.2" ,
Original file line number Diff line number Diff line change @@ -35,10 +35,6 @@ class AppsecFsPlugin extends Plugin {
35
35
this . addBind ( 'apm:fs:operation:finish' , this . _onFsOperationFinishOrRenderEnd )
36
36
this . addBind ( 'tracing:datadog:express:response:render:start' , this . _onResponseRenderStart )
37
37
this . addBind ( 'tracing:datadog:express:response:render:end' , this . _onFsOperationFinishOrRenderEnd )
38
- // TODO Remove this when dc-polyfill is fixed&updated
39
- // hack to node 18 and early 20.x
40
- // with dc-polyfill addBind is not enough to force a channel.hasSubscribers === true
41
- this . addSub ( 'tracing:datadog:express:response:render:start' , ( ) => { } )
42
38
43
39
super . configure ( true )
44
40
}
Original file line number Diff line number Diff line change @@ -226,12 +226,6 @@ describe('AppsecFsPlugin', () => {
226
226
227
227
it ( 'should clean up store when finishing op' , ( ) => {
228
228
let count = 4
229
- // TODO Remove this when node 18 is unsupported or dc-polyfill is fixed&updated
230
- // hack to node 18 and early 20.x
231
- // with dc-polyfill addBind is not enough to force a channel.hasSubscribers === true
232
- const onStart = ( ) => { }
233
- opStartCh . subscribe ( onStart )
234
-
235
229
const onFinish = ( ) => {
236
230
const store = storage ( 'legacy' ) . getStore ( )
237
231
count --
@@ -251,7 +245,6 @@ describe('AppsecFsPlugin', () => {
251
245
assert . strictEqual ( count , 0 )
252
246
} finally {
253
247
opFinishCh . unsubscribe ( onFinish )
254
- opStartCh . unsubscribe ( onStart )
255
248
}
256
249
} )
257
250
} )
Original file line number Diff line number Diff line change @@ -1561,10 +1561,10 @@ data-view-byte-offset@^1.0.1:
1561
1561
es-errors "^1.3.0"
1562
1562
is-data-view "^1.0.1"
1563
1563
1564
- dc-polyfill@^0.1.9 :
1565
- version "0.1.9 "
1566
- resolved "https://registry.yarnpkg.com/dc-polyfill/-/dc-polyfill-0.1.9 .tgz#ee594f4366a6dcf006db1c1f9d3672f57a720856 "
1567
- integrity sha512-D5mJThEEk9hf+CJPwTf9JFsrWdlWp8Pccjxkhf7uUT/E/cU9Mx3ebWe2Bz2OawRmJ6WS9eaDPBkeBE4uOKq9uw ==
1564
+ dc-polyfill@^0.1.10 :
1565
+ version "0.1.10 "
1566
+ resolved "https://registry.yarnpkg.com/dc-polyfill/-/dc-polyfill-0.1.10 .tgz#6f2ada1a9e449587c363ca98cfb79b443cf74b70 "
1567
+ integrity sha512-9iSbB8XZ7aIrhUtWI5ulEOJ+IyUN+axquodHK+bZO4r7HfY/xwmo6I4fYYf+aiDom+WMcN/wnzCz+pKvHDDCug ==
1568
1568
1569
1569
debug@^3.2.7 :
1570
1570
version "3.2.7"
You can’t perform that action at this time.
0 commit comments