ci: fix express node v24 test (#6283)

Author: tlhunter

.github/workflows/apm-integrations.yml

@@ -307,7 +307,7 @@ jobs:
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: ./.github/actions/testagent/start
-      - uses: ./.github/actions/node/active-lts # TODO: change this to latest once we figure out the `fresh` bug
+      - uses: ./.github/actions/node/latest
       - uses: ./.github/actions/install
       - run: yarn test:plugins:ci
 

.github/workflows/appsec.yml

@@ -127,7 +127,7 @@ jobs:
       - uses: ./.github/actions/node/oldest-maintenance-lts
       - uses: ./.github/actions/install
       - run: yarn test:appsec:plugins:ci
-      - uses: ./.github/actions/node/active-lts # TODO: change this to latest once we figure out the `fresh` bug
+      - uses: ./.github/actions/node/latest
       - run: yarn test:appsec:plugins:ci
       - uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
 

packages/datadog-plugin-express/test/index.spec.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { NODE_MAJOR } = require('../../../version')
 const { AsyncLocalStorage } = require('async_hooks')
 const axios = require('axios')
 const semver = require('semver')
@@ -17,6 +18,12 @@ describe('Plugin', () => {
 
   describe('express', () => {
     withVersions('express', 'express', version => {
+    // Express.js 4.10.5 and below have a Node.js incompatibility in the `fresh` package RE res._headers missing
+      if (semver.intersects(version, '<=4.10.5') && NODE_MAJOR >= 24) {
+        describe.skip(`refusing to run tests as express@${version} is incompatible with Node.js ${NODE_MAJOR}`)
+        return
+      }
+
       beforeEach(() => {
         tracer = require('../../dd-trace')
       })

packages/dd-trace/test/appsec/iast/analyzers/code-injection-analyzer.express.plugin.spec.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const { NODE_MAJOR } = require('../../../../../../version')
+const semver = require('semver')
 const { prepareTestServerForIastInExpress } = require('../utils')
 const axios = require('axios')
 const path = require('path')
@@ -14,6 +16,11 @@ const { withVersions } = require('../../../setup/mocha')
 
 describe('Code injection vulnerability', () => {
   withVersions('express', 'express', version => {
+    if (semver.intersects(version, '<=4.10.5') && NODE_MAJOR >= 24) {
+      describe.skip(`refusing to run tests as express@${version} is incompatible with Node.js ${NODE_MAJOR}`)
+      return
+    }
+
     describe('Eval', () => {
       let i = 0
       let evalFunctionsPath

packages/dd-trace/test/appsec/iast/taint-tracking/sources/taint-tracking.express.plugin.spec.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { NODE_MAJOR } = require('../../../../../../../version')
 const axios = require('axios')
 const semver = require('semver')
 const agent = require('../../../../plugins/agent')
@@ -19,6 +20,11 @@ describe('URI sourcing with express', () => {
   let appListener
 
   withVersions('express', 'express', version => {
+    if (semver.intersects(version, '<=4.10.5') && NODE_MAJOR >= 24) {
+      describe.skip(`refusing to run tests as express@${version} is incompatible with Node.js ${NODE_MAJOR}`)
+      return
+    }
+
     before(() => {
       return agent.load(['http', 'express'], { client: false })
     })
@@ -78,6 +84,11 @@ describe('Path params sourcing with express', () => {
   let appListener
 
   withVersions('express', 'express', version => {
+    if (semver.intersects(version, '<=4.10.5') && NODE_MAJOR >= 24) {
+      describe.skip(`refusing to run tests as express@${version} is incompatible with Node.js ${NODE_MAJOR}`)
+      return
+    }
+
     const checkParamIsTaintedAndNext = (req, res, next, param, name) => {
       const store = storage('legacy').getStore()
       const iastContext = iastContextFunctions.getIastContext(store)

packages/dd-trace/test/appsec/index.express.plugin.spec.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const { NODE_MAJOR } = require('../../../../version')
+const semver = require('semver')
 const Axios = require('axios')
 const { assert } = require('chai')
 const path = require('path')
@@ -11,6 +13,11 @@ const { json } = require('../../src/appsec/blocked_templates')
 const { withVersions } = require('../setup/mocha')
 
 withVersions('express', 'express', version => {
+  if (semver.intersects(version, '<=4.10.5') && NODE_MAJOR >= 24) {
+    describe.skip(`refusing to run tests as express@${version} is incompatible with Node.js ${NODE_MAJOR}`)
+    return
+  }
+
   describe('Suspicious request blocking - path parameters', () => {
     let server, paramCallbackSpy, axios
 

packages/dd-trace/test/appsec/rasp/lfi.express.plugin.spec.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const { NODE_MAJOR } = require('../../../../../version')
+const semver = require('semver')
 const Axios = require('axios')
 const os = require('os')
 const fs = require('fs')
@@ -31,6 +33,11 @@ describe('RASP - lfi', () => {
   }
 
   withVersions('express', 'express', expressVersion => {
+    if (semver.intersects(expressVersion, '<=4.10.5') && NODE_MAJOR >= 24) {
+      describe.skip(`refusing to run tests as express@${expressVersion} is incompatible with Node.js ${NODE_MAJOR}`)
+      return
+    }
+
     withVersions('express', 'ejs', ejsVersion => {
       let app, server