From dbc257ee622cad142baa25492b770637b65c6bb1 Mon Sep 17 00:00:00 2001 From: rochdev Date: Thu, 7 Aug 2025 17:49:29 -0400 Subject: [PATCH 1/2] add gating and notification jobs for pre-release gates --- .gitlab/macrobenchmarks.yml | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/.gitlab/macrobenchmarks.yml b/.gitlab/macrobenchmarks.yml index 489b033f838..fe353c2bf60 100644 --- a/.gitlab/macrobenchmarks.yml +++ b/.gitlab/macrobenchmarks.yml @@ -1,5 +1,14 @@ +stages: + - test + - gate + - notify + +include: + project: 'DataDog/benchmarking-platform-tools' + file: 'images/templates/gitlab/notify-slo-breaches.template.yml' + .macrobenchmarks: - stage: macrobenchmarks + stage: test rules: - if: ($NIGHTLY_BENCHMARKS || $CI_PIPELINE_SOURCE != "schedule") && $CI_COMMIT_REF_NAME == "master" when: always @@ -69,3 +78,26 @@ only-tracing-with-runtime-metrics-enabled: variables: DD_BENCHMARKS_CONFIGURATION: only-tracing DD_RUNTIME_METRICS_ENABLED: "true" + +check-slo-breaches: + stage: gate + when: always + tags: ["arch:amd64"] + image: registry.ddbuild.io/images/benchmarking-platform-tools-ubuntu:latest + artifacts: + name: "artifacts" + when: always + paths: + - platform/artifacts/ + expire_in: 3 months + script: + - cd platform && (git init && git remote add origin https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/benchmarking-platform && git pull origin js/hapi) + - bp-runner bp-runner.fail-on-breach.yml + +notify-slo-breaches: + extends: .notify-slo-breaches + stage: notify + needs: ["check-slo-breaches"] + when: always + variables: + CHANNEL: "guild-dd-node-js" From 681afe2870e59c1a07903cf19844ba013c5e1674 Mon Sep 17 00:00:00 2001 From: rochdev Date: Thu, 7 Aug 2025 17:52:03 -0400 Subject: [PATCH 2/2] switch back to old stage name --- .gitlab/macrobenchmarks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab/macrobenchmarks.yml b/.gitlab/macrobenchmarks.yml index fe353c2bf60..239bc5c8c3e 100644 --- a/.gitlab/macrobenchmarks.yml +++ b/.gitlab/macrobenchmarks.yml @@ -1,5 +1,5 @@ stages: - - test + - macrobenchmarks - gate - notify @@ -8,7 +8,7 @@ include: file: 'images/templates/gitlab/notify-slo-breaches.template.yml' .macrobenchmarks: - stage: test + stage: macrobenchmarks rules: - if: ($NIGHTLY_BENCHMARKS || $CI_PIPELINE_SOURCE != "schedule") && $CI_COMMIT_REF_NAME == "master" when: always