Fix build on macos (probs with case insensitivity)

Author: cataphract

.github/CODEOWNERS

@@ -17,4 +17,4 @@ compile_rust.sh @Datadog/libdatadog-apm
 # Release files
 Cargo.lock @DataDog/apm-php @DataDog/profiling-php @Datadog/libdatadog-apm
 package.xml @DataDog/apm-php @DataDog/profiling-php @Datadog/asm-php
-VERSION @DataDog/apm-php @DataDog/profiling-php @Datadog/asm-php
+VERSION.txt @DataDog/apm-php @DataDog/profiling-php @Datadog/asm-php

.gitlab/append-build-id.sh

@@ -14,7 +14,7 @@ fi
 if [[ "$CI_COMMIT_BRANCH" =~ "ddtrace-" ]] ; then
   echo "Release branch detected; not adding git sha1 to version number."
 else
-  version=$(cat VERSION)
+  version=$(cat VERSION.txt)
   # if we have e.g. a beta suffix, just strip it
   if [[ $version == *-* ]]; then
     version=${version%-*}
@@ -26,6 +26,6 @@ else
     version=$(export IFS=.; (echo "${parts[*]}"))
   fi
   version="$version+$githash"
-  echo -n "$version" > VERSION
+  echo -n "$version" > VERSION.txt
   echo "Set version number to $version."
 fi

Makefile

@@ -35,7 +35,7 @@ ASSUME_COMPILED := ${DD_TRACE_ASSUME_COMPILED}
 MAX_TEST_PARALLELISM ?= $(shell nproc)
 ALL_TEST_ENV_OVERRIDE := $(shell [ -n "${DD_TRACE_DOCKER_DEBUG}" ] && echo DD_TRACE_IGNORE_AGENT_SAMPLING_RATES=1) DD_TRACE_GIT_METADATA_ENABLED=0 DD_CRASHTRACKER_RECEIVER_TIMEOUT_MS=15000
 
-VERSION := $(shell cat VERSION)
+VERSION := $(shell cat VERSION.txt)
 
 INI_DIR := $(shell ASAN_OPTIONS=detect_leaks=0 php -d ddtrace.disable=1 -i | awk -F"=>" '/Scan this dir for additional .ini files/ {print $$2}')
 INI_FILE := $(INI_DIR)/ddtrace.ini
@@ -106,7 +106,7 @@ JUNIT_RESULTS_DIR := $(shell pwd)
 
 all: $(BUILD_DIR)/configure $(SO_FILE)
 
-$(BUILD_DIR)/configure: $(M4_FILES) $(BUILD_DIR)/ddtrace.sym $(BUILD_DIR)/VERSION
+$(BUILD_DIR)/configure: $(M4_FILES) $(BUILD_DIR)/ddtrace.sym $(BUILD_DIR)/VERSION.txt
 	$(Q) (cd $(BUILD_DIR); phpize && $(SED_I) 's/\/FAILED/\/\\bFAILED/' $(BUILD_DIR)/run-tests.php) # Fix PHP 5.4 exit code bug when running selected tests (FAILED vs XFAILED)
 
 $(BUILD_DIR)/run-tests.php: $(if $(ASSUME_COMPILED),, $(BUILD_DIR)/configure)

VERSION VERSION.txtVERSION renamed to VERSION.txt

@@ -10,7 +10,7 @@ endforeach()
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/../cmake/Modules")
 
-file(READ "../VERSION" appsec_version)
+file(READ "../VERSION.txt" appsec_version)
 string(STRIP "${appsec_version}" appsec_version)
 set(CMAKE_APPSEC_VERSION ${appsec_version})
 string(REGEX MATCH "^[^+a-z]*" appsec_short_version "${appsec_version}")

appsec/CMakeLists.txt

@@ -35,7 +35,7 @@ add_custom_target(ddtrace_exports
 )
 endif()
 
-file(READ "${CMAKE_SOURCE_DIR}/../VERSION" VERSION_CONTENTS)
+file(READ "${CMAKE_SOURCE_DIR}/../VERSION.txt" VERSION_CONTENTS)
 string(STRIP "${VERSION_CONTENTS}" PHP_DDTRACE_VERSION)
 file(MAKE_DIRECTORY "${CMAKE_BINARY_DIR}/gen_ddtrace/ext")
 set(VERSION_H_PATH "${CMAKE_BINARY_DIR}/gen_ddtrace/ext/version.h")
@@ -46,7 +46,7 @@ add_custom_command(
     COMMAND ${CMAKE_COMMAND} -E remove -f "${VERSION_H_PATH}"
     COMMAND ${CMAKE_COMMAND} -E touch "${VERSION_H_PATH}"
     COMMAND printf "\\#ifndef PHP_DDTRACE_VERSION\\\\n\\#define PHP_DDTRACE_VERSION \"%s\"\\\\n\\#endif" "'\"${PHP_DDTRACE_VERSION}\"'" >> "${VERSION_H_PATH}"
-    DEPENDS "${CMAKE_SOURCE_DIR}/../VERSION"
+    DEPENDS "${CMAKE_SOURCE_DIR}/../VERSION.txt"
     COMMENT "Generating version.h"
 )
 add_custom_target(update_version_h ALL DEPENDS "${VERSION_H_PATH}")

appsec/cmake/ddtrace.cmake

@@ -23,12 +23,12 @@ fn main() {
     }
 
     // Read the version from the VERSION file
-    let version = fs::read_to_string("../VERSION")
+    let version = fs::read_to_string("../VERSION.txt")
         .expect("Failed to read VERSION file")
         .trim()
         .to_string();
     println!("cargo:rustc-env=PROFILER_VERSION={version}");
-    println!("cargo:rerun-if-changed=../VERSION");
+    println!("cargo:rerun-if-changed=../VERSION.txt");
 
     let php_config_includes = std::str::from_utf8(php_config_includes_output.stdout.as_slice())
         .expect("`php-config`'s stdout to be valid utf8");