Skip to content

Commit 0e123f2

Browse files
mergify[bot]Kyle-VerhoogP403n1x87
authored
backport CI fixes to 0.48 (#2350)
* fix(ci): pass environment through riot (#2283) * fix(ci): pass environment through riot riot 0.5 fixed environment variables which actually exposed a misconfiguration we had. * fix django test case (cherry picked from commit a21a627) * Bump rediscluster docker images to 6.2 (#2306) The version being used as well as a bunch of others have been removed from dockerhub for some reason: https://github.com/Grokzen/docker-redis-cluster#redis-major-version-support-and-dockerhub-availability (cherry picked from commit 660fcf4) * fix: avoid latest release of mysql-connector-python (#2336) The latest release of mysql-connector-python seems to introduce a regressin on Python 2.7 so we temporarily prenvet tox from installing it. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Gabriele N. Tornetta <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 14595b7 commit 0e123f2

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ python27_image: &python27_image circleci/python:2.7
1515
ddtrace_dev_image: &ddtrace_dev_image datadog/dd-trace-py:latest
1616
datadog_agent_image: &datadog_agent_image datadog/agent:latest
1717
redis_image: &redis_image redis:4.0-alpine
18-
rediscluster_image: &rediscluster_image grokzen/redis-cluster:4.0.9
18+
rediscluster_image: &rediscluster_image grokzen/redis-cluster:6.2.0
1919
memcached_image: &memcached_image memcached:1.5-alpine
2020
cassandra_image: &cassandra_image cassandra:3.11.7
2121
consul_image: &consul_image consul:1.6.0
@@ -164,7 +164,7 @@ commands:
164164
- run:
165165
environment:
166166
DD_TRACE_AGENT_URL: http://localhost:9126
167-
command: "echo -p2.7,-p3.5,-p3.6,-p3.7,-p3.8,-p3.9 | tr ',' '\n' | circleci tests split | xargs ./scripts/ddtest riot -v run -s '<< parameters.pattern >>'"
167+
command: "echo -p2.7,-p3.5,-p3.6,-p3.7,-p3.8,-p3.9 | tr ',' '\n' | circleci tests split | xargs ./scripts/ddtest riot -v run --pass-env -s '<< parameters.pattern >>'"
168168
- unless:
169169
condition:
170170
<< parameters.snapshot >>

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ services:
3939
ports:
4040
- "127.0.0.1:6379:6379"
4141
rediscluster:
42-
image: grokzen/redis-cluster:4.0.9
42+
image: grokzen/redis-cluster:6.2.0
4343
environment:
4444
- IP=0.0.0.0
4545
ports:

riotfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ def select_pys(min_version=min(SUPPORTED_PYTHON_VERSIONS), max_version=max(SUPPO
493493
pkgs={
494494
"sqlalchemy": ["~=1.0.0", "~=1.1.0", "~=1.2.0", "~=1.3.0", latest],
495495
"psycopg2": ["~=2.8.0"],
496-
"mysql-connector-python": latest,
496+
"mysql-connector-python": [">=8,<8.0.24"],
497497
},
498498
),
499499
],

tests/utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -434,10 +434,10 @@ class DummyTracer(Tracer):
434434

435435
def __init__(self):
436436
super(DummyTracer, self).__init__()
437-
self._update_writer()
437+
self._update_writer(getattr(self.writer, "agent_url", None))
438438

439-
def _update_writer(self):
440-
self.writer = DummyWriter()
439+
def _update_writer(self, agent_url):
440+
self.writer = DummyWriter(agent_url)
441441

442442
def pop(self):
443443
# type: () -> List[Span]
@@ -450,7 +450,7 @@ def pop_traces(self):
450450
def configure(self, *args, **kwargs):
451451
super(DummyTracer, self).configure(*args, **kwargs)
452452
# `.configure()` may reset the writer
453-
self._update_writer()
453+
self._update_writer(self.writer.agent_url)
454454

455455

456456
class TestSpan(Span):

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,8 @@ deps =
249249
molten07: molten>=0.7,<0.8
250250
molten10: molten>=1.0,<1.1
251251
mongoengine: mongoengine
252-
mysqlconnector: mysql-connector-python
253-
mysqlconnector80: mysql-connector-python>=8.0,<8.1
252+
mysqlconnector: mysql-connector-python<8.0.24
253+
mysqlconnector80: mysql-connector-python>=8.0,<8.0.24
254254
mysqldb: mysql-python
255255
mysqldb12: mysql-python>=1.2,<1.3
256256
mysqlclient: mysqlclient

0 commit comments

Comments
 (0)