chore(tracer): remove deprecated collect_metrics arg (#2555) (#2710)

* chore(tracer): remove deprecated collect_metrics arg

The `collect_metrics` argument of the `Tracer.configure` method was
marked for deprecation and set for removal with v0.51.

* remove unnecessary type hint ignores

Co-authored-by: Kyle Verhoog <[email protected]>
Co-authored-by: Tahir H. Butt <[email protected]>
(cherry picked from commit ddca338)

Co-authored-by: Gabriele N. Tornetta <[email protected]>

Author: mergify[bot]

ddtrace/bootstrap/sitecustomize.py

@@ -99,11 +99,7 @@ def update_patched_modules():
     if priority_sampling:
         opts["priority_sampling"] = asbool(priority_sampling)
 
-    # FIXME: Remove as part of the deprecation of collect_metrics
-    opts["collect_metrics"] = asbool(get_env("runtime_metrics", "enabled"))
-
-    if opts:
-        tracer.configure(**opts)
+    tracer.configure(**opts)
 
     if patch:
         update_patched_modules()

ddtrace/tracer.py

@@ -247,7 +247,6 @@ def current_trace_context(self, *args, **kwargs):
         return None
 
     # TODO: deprecate this method and make sure users create a new tracer if they need different parameters
-    @debtcollector.removals.removed_kwarg("collect_metrics", removal_version="0.51")
     def configure(
         self,
         enabled=None,  # type: Optional[bool]
@@ -260,7 +259,6 @@ def configure(
         wrap_executor=None,  # type: Optional[Callable]
         priority_sampling=None,  # type: Optional[bool]
         settings=None,  # type: Optional[Dict[str, Any]]
-        collect_metrics=None,  # type: Optional[bool]
         dogstatsd_url=None,  # type: Optional[str]
         writer=None,  # type: Optional[TraceWriter]
         partial_flush_enabled=None,  # type: Optional[bool]
@@ -286,7 +284,6 @@ def configure(
             from the default value
         :param priority_sampling: enable priority sampling, this is required for
             complete distributed tracing support. Enabled by default.
-        :param collect_metrics: Whether to enable runtime metrics collection.
         :param str dogstatsd_url: URL for UDP or Unix socket connection to DogStatsD
         """
         if enabled is not None:
@@ -376,18 +373,6 @@ def configure(
         if wrap_executor is not None:
             self._wrap_executor = wrap_executor
 
-        runtime_metrics_was_running = False
-        # FIXME: Import RuntimeWorker here to avoid circular imports. This will
-        # be gone together with the collect_metrics attribute soon.
-        from .internal.runtime.runtime_metrics import RuntimeWorker
-
-        if RuntimeWorker._instance is not None:
-            runtime_metrics_was_running = True
-            RuntimeWorker.disable()
-
-        if (collect_metrics is None and runtime_metrics_was_running) or collect_metrics:
-            RuntimeWorker.enable(tracer=self, dogstatsd_url=self._dogstatsd_url)
-
         if debug_mode or asbool(environ.get("DD_TRACE_STARTUP_LOGS", False)):
             try:
                 info = debug.collect(self)

docs/advanced_usage.rst

@@ -652,7 +652,7 @@ To enable tracing with manual instrumentation and configuration, configure uWSGI
 
 
   patch_all()
-  tracer.configure(collect_metrics=True)
+  tracer.configure()
 
   def application(env, start_response):
       with tracer.trace("uwsgi-app"):

releasenotes/notes/remove-deprecated-collect-metrics-82d9bbff853a6704.yaml

@@ -0,0 +1,5 @@
+---
+deprecations:
+  - |
+    Removed the ``collect_metrics`` argument from ``Tracer.configure``. See the
+    release notes for v0.49.0 for the migration instructions.

tests/tracer/runtime/test_runtime_metrics.py

@@ -1,7 +1,6 @@
 import contextlib
 import os
 import time
-import warnings
 
 import mock
 
@@ -132,21 +131,6 @@ def test_only_root_span_runtime_internal_span_types(self):
                 assert root.get_tag("language") == "python"
                 assert child.get_tag("language") is None
 
-    def test_only_root_span_runtime_internal_span_types_with_tracer_config(self):
-        with warnings.catch_warnings(record=True) as w:
-            warnings.simplefilter("always")
-            self.tracer.configure(collect_metrics=True)
-            for span_type in ("custom", "template", "web", "worker"):
-                with self.start_span("root", span_type=span_type) as root:
-                    with self.start_span("child", child_of=root) as child:
-                        pass
-                assert root.get_tag("language") == "python"
-                assert child.get_tag("language") is None
-            self.tracer.configure(collect_metrics=False)
-
-            self.assertEqual(len(w), 2)
-            self.assertTrue(all(issubclass(_.category, DeprecationWarning) for _ in w))
-
     def test_span_no_runtime_tags(self):
         with self.start_span("root") as root:
             with self.start_span("child", child_of=root.context) as child: