Skip to content

Commit 181d6e9

Browse files
github-actions[bot]tylfinemmettbutler
authored
fix(symdb): switch _shallow to shallow in install [backport 3.8] (#13528)
Backport 58bd69c from #13522 to 3.8. This fixes a bug introduced by #12957 where the shallow mode for SymDB was introduced. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Tyler Finethy <[email protected]> Co-authored-by: Emmett Butler <[email protected]>
1 parent 5a941c1 commit 181d6e9

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

ddtrace/internal/symbol_db/symbols.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,5 +668,5 @@ def _upload_context(context: ScopeContext) -> None:
668668

669669
@classmethod
670670
def install(cls, shallow=True):
671-
cls._shallow = shallow
671+
cls.shallow = shallow
672672
return super().install()
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
dynamic instrumentation: fixes an issue where only module scopes were being uploaded,
5+
preventing method probes from being created.

tests/internal/symbol_db/test_symbols.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,8 @@ def _upload_context(context):
270270

271271
SymbolDatabaseUploader._upload_context = staticmethod(_upload_context)
272272

273-
SymbolDatabaseUploader.install()
273+
SymbolDatabaseUploader.install(shallow=False)
274+
assert SymbolDatabaseUploader.shallow is False
274275

275276
def get_scope(contexts, name):
276277
for context in (_.to_json() for _ in contexts):

0 commit comments

Comments
 (0)