[django] trace errors from views

Author: Emanuele Palazzetti

tests/contrib/django/app/views.py

@@ -1,8 +1,9 @@
 """
 Class based views used for Django tests.
 """
+from django.http import HttpResponse
 from django.conf.urls import url
-from django.views.generic import ListView
+from django.views.generic import ListView, TemplateView
 from django.contrib.auth.models import User
 
 
@@ -11,7 +12,13 @@ class UserList(ListView):
     template_name = 'users_list.html'
 
 
+class ForbiddenView(TemplateView):
+    def get(self, request, *args, **kwargs):
+        return HttpResponse(status=403)
+
+
 # use this url patterns for tests
 urlpatterns = [
-    url(r'^users/$', UserList.as_view(), name='users-list')
+    url(r'^users/$', UserList.as_view(), name='users-list'),
+    url(r'^fail-view/$', ForbiddenView.as_view(), name='forbidden-view'),
 ]

tests/contrib/django/test_middleware.py

@@ -57,3 +57,16 @@ def test_middleware_trace_request(self):
         eq_(sp_request.get_tag('http.url'), '/users/')
         eq_(sp_request.get_tag('django.user.is_authenticated'), 'False')
         eq_(sp_request.get_tag('http.method'), 'GET')
+
+    def test_middleware_trace_errors(self):
+        # ensures that the internals are properly traced
+        url = reverse('forbidden-view')
+        response = self.client.get(url)
+        eq_(response.status_code, 403)
+
+        # check for spans
+        spans = self.tracer.writer.pop()
+        eq_(len(spans), 1)
+        span = spans[0]
+        eq_(span.get_tag('http.status_code'), '403')
+        eq_(span.get_tag('http.url'), '/fail-view/')